From: Krzysztof Kozlowski <krzk@kernel.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: realtek,rt5514: Convert to dtschema
Date: Fri, 14 Jun 2024 10:31:42 +0200 [thread overview]
Message-ID: <59487896-1ce0-4422-bafb-a0f6f9ef065c@kernel.org> (raw)
In-Reply-To: <20240614033812.51312-2-animeshagarwal28@gmail.com>
On 14/06/2024 05:38, Animesh Agarwal wrote:
> +maintainers:
> + - Animesh Agarwal <animeshagarwal28@gmail.com>
Missing ref to spi peri props.
> +
> +properties:
> + compatible:
> + const: realtek,rt5514
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: Master clock to the CODEC
> +
> + clock-names:
> + items:
> + - const: mclk
> +
> + interrupts:
> + maxItems: 1
> + description: The interrupt number to the cpu.
> +
> + realtek,dmic-init-delay-ms:
> + description: Set the DMIC initial delay (ms) to wait it ready for I2C.
wakeup-source and maybe other properties. I don't think you tested DTS.
unevaluatedProperties: false.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-14 8:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 3:38 [PATCH 0/2] ASoC: dt-bindings: Convert realtek CODEC bindings to DT schema Animesh Agarwal
2024-06-14 3:38 ` [PATCH 1/2] ASoC: dt-bindings: realtek,rt5514: Convert to dtschema Animesh Agarwal
2024-06-14 8:31 ` Krzysztof Kozlowski [this message]
2024-06-14 18:20 ` kernel test robot
2024-06-14 3:38 ` [PATCH 2/2] ASoC: dt-bindings: realtek,rt5631: " Animesh Agarwal
2024-06-14 8:34 ` Krzysztof Kozlowski
2024-06-16 0:40 ` kernel test robot
2024-06-14 8:32 ` [PATCH 0/2] ASoC: dt-bindings: Convert realtek CODEC bindings to DT schema Krzysztof Kozlowski
2024-06-17 11:18 ` Daniel Baluta
2024-06-17 12:09 ` Krzysztof Kozlowski
2024-06-17 12:14 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59487896-1ce0-4422-bafb-a0f6f9ef065c@kernel.org \
--to=krzk@kernel.org \
--cc=animeshagarwal28@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).