From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90E11C433FE for ; Fri, 18 Nov 2022 09:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241832AbiKRJQp (ORCPT ); Fri, 18 Nov 2022 04:16:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241857AbiKRJQ1 (ORCPT ); Fri, 18 Nov 2022 04:16:27 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80DE691C02 for ; Fri, 18 Nov 2022 01:16:25 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id bj12so11421342ejb.13 for ; Fri, 18 Nov 2022 01:16:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=nVpY7HTKInpub0ujYpomEMwnoXj914wvun46oA4sJoQ=; b=Xhz5XNfb3dS5vE01xwDhnNS0x2PKi9Dzud0k5uLCkF+WlXcrZ2l9BFeK45mVVkeMpB eV/utXTP5NvGug9m/u8SIswHG8qrJ/wBLeE5S0ih9JRXCoOWZBmktGi2CCabJB2OIQsi zTKoG0vFSNTUJqCijBx7QEARh3NVMx6SYSTlPWa9wdYBdeP3RKsxA9BEq3nfnBd7WJVF 5lD4x8aOVmkv7G+X4HX6ohElmiR8U1KxHElicjDykNs2+ZJtGAng3cGrljPw2RhdXjMD m6T6e2AMZnMm3BE6zdbrudXsD1PWC+75pdQKZ4knW+52vEydTMDgWIIkjvZAewcTSMTD xdOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=nVpY7HTKInpub0ujYpomEMwnoXj914wvun46oA4sJoQ=; b=qfUSj+oX6MfN9hh6PqYh7Nyc+PGuX0dppDc99nqV2Bg1f9Ni93AWGtoD/dBMhcfeaw XETFp/lRgzP+t0U8xyQppdPvM6NLuOCDcTVLou2VJA9KlEqRe6FnJtrQ1JzLFLE6+xX7 dHy3aG7XPFXqRUt9IvuPFa/2SmKVihYLy+4jTgn6s9SoucZwhcFyXj+Yo7fu5ZHNU/bW kPEjUaFIB/1Hqpm+vsa/V48IwAByj0OBDa4WfIrnS1WUDPkrYq3NFpcuncSkx+RhUfpV LPXkGF8IBGKVCy9llJq9DY1ZJHawcF17pP+wL4cgf72dVcUyWbaUXQ7Pzmi5UNEvgj8T IDwA== X-Gm-Message-State: ANoB5pny5xVdkYTr5t8u3tSBTiIDzKLP11JAKpWObQTvGybI0J7ZGvq6 6MyvQ+IQ79U6m14nyVV7esaW+SofWs+Gf6Ya X-Google-Smtp-Source: AA0mqf64rijyM5vvOY6oiWPW2G22yh6wist43cUewN9SRMFYULPK04Q0dJfkBi0jDPRyfCFrLbqmfg== X-Received: by 2002:a17:906:8c4:b0:7ae:fbe6:e7ca with SMTP id o4-20020a17090608c400b007aefbe6e7camr5334368eje.408.1668762983966; Fri, 18 Nov 2022 01:16:23 -0800 (PST) Received: from [192.168.31.208] ([194.29.137.22]) by smtp.gmail.com with ESMTPSA id a25-20020a50ff19000000b00461bd82581asm1545121edu.84.2022.11.18.01.16.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 01:16:23 -0800 (PST) Message-ID: <594be897-f710-fb62-0882-8a7f01b21bfe@linaro.org> Date: Fri, 18 Nov 2022 10:16:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 10/13] arm64: dts: qcom: sm8450: add spmi node From: Konrad Dybcio To: Vinod Koul , Dmitry Baryshkov Cc: Krzysztof Kozlowski , Bjorn Andersson , Stephen Boyd , linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20211209103505.197453-1-vkoul@kernel.org> <20211209103505.197453-11-vkoul@kernel.org> <5035b6a3-164b-afa0-b714-4deb886f9f90@linaro.org> <9f696023-f2b4-ccd0-34a0-6f4d5848e862@linaro.org> <8c1428a6-f268-cb03-3e55-887d30236924@linaro.org> <3af48606-731f-6047-92ca-80435f401ae3@linaro.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/11/2022 15:57, Konrad Dybcio wrote: > > > On 26/10/2022 07:33, Vinod Koul wrote: >> On 24-10-22, 21:58, Dmitry Baryshkov wrote: >>> On Mon, 24 Oct 2022 at 21:56, Krzysztof Kozlowski >>> wrote: >>>> >>>> On 24/10/2022 12:48, Dmitry Baryshkov wrote: >>>>> On 24/10/2022 19:46, Krzysztof Kozlowski wrote: >>>>>> On 24/10/2022 12:45, Dmitry Baryshkov wrote: >>>>>>> On 24/10/2022 17:56, Krzysztof Kozlowski wrote: >>>>>>>> On 09/12/2021 05:35, Vinod Koul wrote: >>>>>>>>> Add the spmi bus as found in the SM8450 SoC >>>>>>>>> >>>>>>>>> Signed-off-by: Vinod Koul >>>>>>>>> Reviewed-by: Konrad Dybcio >>>>>>>>> --- >>>>>>>>>     arch/arm64/boot/dts/qcom/sm8450.dtsi | 18 ++++++++++++++++++ >>>>>>>>>     1 file changed, 18 insertions(+) >>>>>>>>> >>>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>>>>> b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>>>>> index f75de777f6ea..b80e34fd3fe1 100644 >>>>>>>>> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>>>>> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi >>>>>>>>> @@ -645,6 +645,24 @@ pdc: interrupt-controller@b220000 { >>>>>>>>>                            interrupt-controller; >>>>>>>>>                    }; >>>>>>>>> >>>>>>>>> +         spmi_bus: spmi@c42d000 { >>>>>>>>> +                 compatible = "qcom,spmi-pmic-arb"; >>>>>>>>> +                 reg = <0x0 0x0c400000 0x0 0x00003000>, >>>>>>>>> +                       <0x0 0x0c500000 0x0 0x00400000>, >>>>>>>>> +                       <0x0 0x0c440000 0x0 0x00080000>, >>>>>>>>> +                       <0x0 0x0c4c0000 0x0 0x00010000>, >>>>>>>>> +                       <0x0 0x0c42d000 0x0 0x00010000>; >>>>>>>> >>>>>>>> This is a patch from December 2021. Is there anything blocking >>>>>>>> it from >>>>>>>> being merged? >>>>>>>> >>>>>>>> The same applies to several other patches here. >>>>>>> >>>>>>> As far as I know, Stephen still didn't pick up the spmi-pmic-arb >>>>>>> support >>>>>>> for the PMIC on the SM8450 platform. Thus we also can not merge >>>>>>> the DT >>>>>>> parts. >>>>>> >>>>>> Why we cannot merge DTS? How is DTS with new nodes depending on any >>>>>> driver changes? >>>>> >>>>> In this particular case, there was an open question, what should be >>>>> the >>>>> bindings for the PMIC ARB v7. >>>> >>>> Ah, so it is about PMIC ARB v7 bindings? Then it's reasonable to wait >>>> with this one. I just had an impression that it's about driver >>>> changes... >>> >>> Yes, it's about binding. Thus we have been waiting for quite some time. >> >> Yes sadly Steven has stopped responding to emails or IRC.. I am not >> sure whats going on! >> >> Even the SPMI tree is not being actively maintained with only few >> patches which were picked in last cycle since this year! > It's in -next now and 8450 boots and works fine. If the binding > situation has been resolved, I say merge this ASAP! :) > > Konrad With a small nit: it needs to be rebased, and should come between aoss_qmp: and ipcc: address-wise (ipcc wasn't around a year ago in this DT, it seems). Also most (all?) other nodes in the DT use reg = <0 [..]> instead of reg = <0x0 [..]> so that could be fixed up as well. Konrad >>