From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77530C433F5 for ; Thu, 7 Apr 2022 06:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241378AbiDGGvE (ORCPT ); Thu, 7 Apr 2022 02:51:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241379AbiDGGvC (ORCPT ); Thu, 7 Apr 2022 02:51:02 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AAD4E6C60 for ; Wed, 6 Apr 2022 23:49:03 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id p15so8773193ejc.7 for ; Wed, 06 Apr 2022 23:49:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=ig1etyDF68tf5y4+B0bKhTRY5wsKZ9GD0NtPhkq4h5I=; b=xrLUcHHwKuNTh4APSk1UhhZeFKYx5/K1fJIzae4MIT/Bg1RYnwCOSqstuf/ZYismFz 3CE2yBy2HCiEUJAT/uhluRStnRmtIzabcvauHCUnncDJ8Tef7BPXRE24Slg8eoVuPEed Gjt/OGqI/n7/B0coJmgJrd9Sxx2WmltbunSffJZ7Avw2PXYdaqFgGx6F1GEcu7Rd9r+i Fw3vnDg6Ki+RhIKBcblCZ0hVP5wkbBQBAwZTDUoZVPnkzJZad9y/K6Q/zJlo6TuTbnoe lrCllXvX3vtSI0HhWwYw6WHEmtKRUglMA43DnsjdHGD2e2igUDPwa5MqXOMJ5ezBnman /JbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=ig1etyDF68tf5y4+B0bKhTRY5wsKZ9GD0NtPhkq4h5I=; b=KjhyxtD+jAhTUnP+/1S7C0Upk/xaPkCYeihZcywLdPtdRm0Xt8vnzhSBltFd7cjkGe b/B2tgE9HvTRdx7gSJ9IiDtDDJra7GUzGIYfI7/9Uzj45eakreGVB2cXlpMNxPOyDoEZ xrsM0uD2nLOxq8/CztWJVsuf1tovt+Ep6fLVPp3XWiMgoggGz1nMj7x5U9GUAVj97q5/ 25xImGyENWGs9dwmwi3McahsKcwZ4VD1p751HZ6VyWdApZyEHnZYLNAu2CRQYpOKqiYJ ubfhRzifnVzuUo4Hm64iB0IGarSD8ZKOHjcJs2RKU3ZM8/p9JHldBwmaHVpv2yCBgV3j rg2Q== X-Gm-Message-State: AOAM533ufXexkVEV2AqWWYY0UzhJ1SZ6M4zZy411Qzemmb/aP4QXbLpu qXoS7OpekPrlGikhn/W/HaWIVA== X-Google-Smtp-Source: ABdhPJyI+a19I669vtBg9dpBsKeqt/6i1D7etaTUE8OFw7G4q33l4BRlM1qJgUjqaoH0PJSjKLZYdA== X-Received: by 2002:a17:907:608d:b0:6e7:f1d1:ff42 with SMTP id ht13-20020a170907608d00b006e7f1d1ff42mr12405023ejc.620.1649314142185; Wed, 06 Apr 2022 23:49:02 -0700 (PDT) Received: from [192.168.0.185] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id s10-20020a50daca000000b0041cc361b1c9sm5877690edj.68.2022.04.06.23.49.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 23:49:01 -0700 (PDT) Message-ID: <594c124d-403f-56f1-b9fb-f48042d7056b@linaro.org> Date: Thu, 7 Apr 2022 08:49:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/3] dt-bindings: display: mediatek: Correct disp_aal binding for MT8183 Content-Language: en-US To: Rex-BC Chen , chunkuang.hu@kernel.org, robh+dt@kernel.org, krzk+dt@kernel.org Cc: matthias.bgg@gmail.com, p.zabel@pengutronix.de, airlied@linux.ie, yongqiang.niu@mediatek.com, jason-jh.lin@mediatek.com, nancy.lin@mediatek.com, allen-kh.cheng@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220406094654.29722-1-rex-bc.chen@mediatek.com> <20220406094654.29722-2-rex-bc.chen@mediatek.com> <397e30c2-18c3-93d6-16f5-b113be77f51a@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07/04/2022 08:22, Rex-BC Chen wrote: > On Wed, 2022-04-06 at 16:44 +0200, Krzysztof Kozlowski wrote: >> On 06/04/2022 11:46, Rex-BC Chen wrote: >>> The driver data of MT8183 and MT8173 are different. >>> The value of has_gamma for MT8173 is true while the value of MT8183 >>> is >>> false. Therefore, the compatible of disp_aal for MT8183 is not >>> suitable >>> for the compatible for MT8173. >> >> Just because one feature is not supported, it does not mean they are >> incompatible, which you claim in the patch below. Are you sure they >> are >> really incompatible and MT8173 fallback cannot be used? >> >> >> Best regards, >> Krzysztof > > Hello Krzysztof, > > Thanks for your review. > > The difference of disp_aal for each MediaTek SoCs is "has_gamma". > And we only control this variable for different MediaTek SoCs. > > The value of has_gamma for MT8173 is true. > The value of has_gamma for MT8183 is false. (Moreover, the driver data > is null for MT8183) > > From this situation, I think it's not compatible between MT8173 and > MT8183. You repeated the commit msg without bringing any new information... but let it be, I assume setting gamma on MTT8183 is incorrect or produces wrong results. Best regards, Krzysztof