From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: linux@roeck-us.net, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, linux-usb@vger.kernel.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
caleb.connolly@linaro.org, konrad.dybcio@linaro.org,
subbaram@quicinc.com, jackp@quicinc.com,
robertom@qti.qualcomm.com,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Wesley Cheng <wcheng@codeaurora.org>
Subject: Re: [PATCH v5 14/14] phy: qcom-qmp: Register as a typec switch for orientation detection
Date: Tue, 18 Apr 2023 17:54:00 +0100 [thread overview]
Message-ID: <594e4217-2594-1f8d-130c-c676dcc2b3ad@linaro.org> (raw)
In-Reply-To: <20230418125723.r7fkxgrs2ncxbb7j@ripper>
On 18/04/2023 13:57, Bjorn Andersson wrote:
>> + dev_dbg(qmp->dev, "Toggling orientation current %d requested %d\n",
>> + qmp->orientation, orientation);
>> +
>> + qmp->orientation = orientation;
>> +
>> + if (orientation == TYPEC_ORIENTATION_NONE) {
>> + if (qmp->init_count)
>> + ret = qmp_combo_dp_power_off(dp_phy);
>> + } else {
>> + if (!qmp->init_count)
>> + ret = qmp_combo_dp_power_on(dp_phy);
>> + }
> This sequence is crashing my laptop, need some more time to debug the
> actual cause.
>
> Regards,
> Bjorn
>
https://git.codelinaro.org/bryan.odonoghue/kernel/-/tree/linux-next-23-04-17-pm8150b-tcpm-qcom-wrapper-typec-mux
This works for me on sm8250 nicely - I can transition from device to
host and back again in both orientations - I'm about to send out V6 with
this contained, I haven't tried/enabled it on x13s yet though.
https://git.codelinaro.org/bryan.odonoghue/kernel/-/commit/2c80c630636f1739bde4c1aac2b20940b84daf71
---
bod
next prev parent reply other threads:[~2023-04-18 16:54 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 11:34 [PATCH v5 00/14] Add Qualcomm PMIC TPCM support Bryan O'Donoghue
2023-04-13 11:34 ` [PATCH v5 01/14] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark reg as required Bryan O'Donoghue
2023-04-16 17:43 ` Krzysztof Kozlowski
2023-04-13 11:34 ` [PATCH v5 02/14] dt-bindings: regulator: qcom,usb-vbus-regulator: Mark regulator-*-microamp required Bryan O'Donoghue
2023-04-13 11:34 ` [PATCH v5 03/14] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add orientation-switch as optional Bryan O'Donoghue
2023-04-13 11:34 ` [PATCH v5 04/14] dt-bindings: phy: qcom,sc7180-qmp-usb3-dp-phy: Add ports as an optional Bryan O'Donoghue
2023-04-14 7:23 ` Marijn Suijten
2023-04-16 17:47 ` Krzysztof Kozlowski
2023-04-17 0:09 ` Bryan O'Donoghue
2023-04-17 6:16 ` Krzysztof Kozlowski
2023-04-13 11:34 ` [PATCH v5 05/14] dt-bindings: usb: Add Qualcomm PMIC Type-C YAML schema Bryan O'Donoghue
2023-04-14 7:27 ` Marijn Suijten
2023-04-16 17:49 ` Krzysztof Kozlowski
2023-04-13 11:34 ` [PATCH v5 06/14] dt-bindings: mfd: qcom,spmi-pmic: Add typec to SPMI device types Bryan O'Donoghue
2023-04-16 17:50 ` Krzysztof Kozlowski
2023-04-13 11:34 ` [PATCH v5 07/14] arm64: dts: qcom: sm8250: Define ports for qmpphy orientation-switching Bryan O'Donoghue
2023-04-13 11:34 ` [PATCH v5 08/14] arm64: dts: qcom: pm8150b: Add a TCPM description Bryan O'Donoghue
2023-04-13 11:34 ` [PATCH v5 09/14] arm64: dts: qcom: qrb5165-rb5: Switch on Type-C VBUS boost Bryan O'Donoghue
2023-04-13 11:34 ` [PATCH v5 10/14] arm64: dts: qcom: qrb5165-rb5: Switch on basic TCPM Bryan O'Donoghue
2023-04-13 11:34 ` [PATCH v5 11/14] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM usb-role-switching for usb_1 Bryan O'Donoghue
2023-04-22 14:52 ` Konrad Dybcio
2023-04-22 14:53 ` Konrad Dybcio
2023-04-13 11:34 ` [PATCH v5 12/14] arm64: dts: qcom: qrb5165-rb5: Switch on TCPM orientation-switch for usb_1_qmpphy Bryan O'Donoghue
2023-04-13 11:34 ` [PATCH v5 13/14] usb: typec: qcom: Add Qualcomm PMIC TCPM support Bryan O'Donoghue
2023-04-24 13:11 ` Heikki Krogerus
2023-04-24 13:48 ` Bryan O'Donoghue
2023-04-13 11:34 ` [PATCH v5 14/14] phy: qcom-qmp: Register as a typec switch for orientation detection Bryan O'Donoghue
2023-04-18 12:57 ` Bjorn Andersson
2023-04-18 16:54 ` Bryan O'Donoghue [this message]
2023-04-13 14:19 ` [PATCH v5 00/14] Add Qualcomm PMIC TPCM support Luca Weiss
2023-04-13 15:08 ` Bryan O'Donoghue
2023-04-14 6:51 ` Luca Weiss
2023-04-17 0:30 ` Bryan O'Donoghue
2023-04-17 7:35 ` Luca Weiss
2023-04-17 10:04 ` Bryan O'Donoghue
2023-04-17 10:11 ` Bryan O'Donoghue
2023-04-21 10:26 ` Luca Weiss
2023-04-22 22:16 ` Bryan O'Donoghue
2023-04-25 7:29 ` Luca Weiss
2023-09-20 2:13 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=594e4217-2594-1f8d-130c-c676dcc2b3ad@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jackp@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robertom@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=subbaram@quicinc.com \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).