From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Karel Balej <karelb@gimli.ms.mff.cuni.cz>,
Karel Balej <balejk@matfyz.cz>, Lee Jones <lee@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Duje Mihanović" <duje.mihanovic@skole.hr>,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [RFC PATCH 3/5] dt-bindings: regulator: add documentation entry for 88pm88x-regulator
Date: Thu, 4 Jan 2024 10:26:10 +0100 [thread overview]
Message-ID: <596216f2-d6c7-4432-938f-e73a969ec2da@linaro.org> (raw)
In-Reply-To: <9cecc4bd-34ec-4b34-b0c8-de02473f038a@linaro.org>
On 04/01/2024 10:25, Krzysztof Kozlowski wrote:
> On 28/12/2023 10:39, Karel Balej wrote:
>> From: Karel Balej <balejk@matfyz.cz>
>>
>
> A nit, subject: drop second/last, redundant "documentation entry". The
> "dt-bindings" prefix is already stating that these are bindings.
>
>> The Marvell 88PM88X PMICs provide regulators among other things.
>> Document how to use them.
>
>
> You did not document them in the bindings. You just added example to
> make it complete. Where is the binding change?
>
> What's more, I have doubts that you tested it.
I found your other patchset - now I am 100% sure you did not test it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-04 9:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 9:39 [RFC PATCH 0/5] regulator: support for Marvell 88PM886 LDOs and bucks Karel Balej
2023-12-28 9:39 ` [RFC PATCH 1/5] mfd: 88pm88x: differences with respect to the PMIC RFC series Karel Balej
2024-01-11 10:54 ` Lee Jones
2024-01-11 15:06 ` Karel Balej
2024-01-11 15:25 ` Lee Jones
2024-01-11 15:36 ` Karel Balej
2024-01-12 7:58 ` Lee Jones
2023-12-28 9:39 ` [RFC PATCH 2/5] mfd: 88pm88x: initialize the regulators regmaps Karel Balej
2023-12-28 9:39 ` [RFC PATCH 3/5] dt-bindings: regulator: add documentation entry for 88pm88x-regulator Karel Balej
2024-01-04 9:25 ` Krzysztof Kozlowski
2024-01-04 9:26 ` Krzysztof Kozlowski [this message]
2023-12-28 9:39 ` [RFC PATCH 4/5] regulator: add 88pm88x regulators driver Karel Balej
2024-01-05 15:18 ` Mark Brown
2024-01-07 9:49 ` Karel Balej
2024-01-07 10:34 ` Krzysztof Kozlowski
2024-01-07 12:46 ` Karel Balej
2024-01-07 15:26 ` Mark Brown
2024-01-07 10:35 ` Krzysztof Kozlowski
2024-01-07 13:02 ` Karel Balej
2023-12-28 9:39 ` [RFC PATCH 5/5] MAINTAINERS: add entries for the " Karel Balej
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=596216f2-d6c7-4432-938f-e73a969ec2da@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=balejk@matfyz.cz \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=duje.mihanovic@skole.hr \
--cc=karelb@gimli.ms.mff.cuni.cz \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).