From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BE75C001B3 for ; Wed, 5 Jul 2023 07:11:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232146AbjGEHLv (ORCPT ); Wed, 5 Jul 2023 03:11:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231598AbjGEHLu (ORCPT ); Wed, 5 Jul 2023 03:11:50 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B4B4197 for ; Wed, 5 Jul 2023 00:11:49 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-51e292cf214so23567a12.2 for ; Wed, 05 Jul 2023 00:11:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688541108; x=1691133108; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WX0WQA8HY3Ymz7UH7Yi3Ieb+P0qOXYqrfKwH/sPJabs=; b=P0JOrfTD0q7ZHjY5IOju9DyPynfZK6LfPQ72KB/m00RTGvWkPesx2OKB/jZgHugBkB QVeme2IiJ5n9GW+8xLwh8vU+UJy7xHY4w3rtTk+YvQnBWxANlXkEdBx8bMZsWvIS7MCI U4UCyDwn8G5FI13IlIDN5lMZVBREdIZmcPPhvfwFZYSzuErqQhdjvGILLBBUsJ1IePSk jpqsez32AaVjSkAZizs+NmDP4z7EeISbgQRvaRyTJ4i/DyHeBPKYI38KWb76Xv9kLdoP KBRdkjmskKx1A8tzWLqYclk5w6SLYKg687/qQvOui0ItRD1v9UH5pWuEK34ZccmEQnVk aNdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688541108; x=1691133108; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WX0WQA8HY3Ymz7UH7Yi3Ieb+P0qOXYqrfKwH/sPJabs=; b=JlTg8OTFFXN+NXPOQMRN9HdKrVzdXYf6fAtVzj636l88SuQ6i5p8iBJYU4IfDnIwII Mx3wTn+S/KH6kfBz81iUVvcj8Hnmt9UuD7uwO846bDAQBX8fJMe/IMpm/8s9q5hWj91T JfT//3tkT6MsaN6WsBSmdALVTmXm4cVtKIG6ygBXavV2TdC3xUup2vHLYmvmWwtExo1x xIu9C5Aa+19HTNbJOwfvgJWF+cQ7F/Beyi3h8wK8L233pjuGB9FosCPgFZFSsj3Ewykm 3r9zuyILnnSgkW01yMuuFxGTkU0+DBWeKHRdRJdIt3taJIKmNvPgLs0wilS4tEykqdkK LdMw== X-Gm-Message-State: ABy/qLa/RP3YHPmGyA/Wz/ko5V+P5dQgp+z4T3WXlFF9npkXuq7GY67b FQoCjyGQlo+TBJ4D60q266MB8A== X-Google-Smtp-Source: APBJJlHOsPDM5DNg9y1IPD7Tqyg5hcpZ5XP4/BQMReGoYnghFMp8qzeO0uyGvCySn5432Yyb1XldGA== X-Received: by 2002:aa7:c544:0:b0:51d:ec12:32f8 with SMTP id s4-20020aa7c544000000b0051dec1232f8mr10241219edr.40.1688541107574; Wed, 05 Jul 2023 00:11:47 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id ca9-20020aa7cd69000000b0051dad094faasm9354972edb.36.2023.07.05.00.11.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jul 2023 00:11:47 -0700 (PDT) Message-ID: <596e25d8-2e8b-8d6b-b6b8-9b56b58602bd@linaro.org> Date: Wed, 5 Jul 2023 09:11:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 2/2] leds: pca995x: Add support for PCA995X chips Content-Language: en-US To: Marek Vasut , linux-leds@vger.kernel.org Cc: Isai Gaspar , Conor Dooley , Krzysztof Kozlowski , Lee Jones , Pavel Machek , Rob Herring , devicetree@vger.kernel.org References: <20230705000407.153005-1-marex@denx.de> <20230705000407.153005-2-marex@denx.de> From: Krzysztof Kozlowski In-Reply-To: <20230705000407.153005-2-marex@denx.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/07/2023 02:04, Marek Vasut wrote: > From: Isai Gaspar > > The PCA995x chips are I2C controlled LED drivers. Each chip has > up to 16 outputs, each one with an individual 8-bit resolution > PWM for brightness control. > > Signed-off-by: Isai Gaspar > Signed-off-by: Marek Vasut # Basically rewrite the driver ... > + > +static struct i2c_driver pca995x_driver = { > + .driver = { > + .name = "leds-pca995x", > + .owner = THIS_MODULE, > + .of_match_table = of_match_ptr(pca995x_of_match), Drop of_match_ptr(), it will cause warnings and is not really helpful. Best regards, Krzysztof