From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A64DE24A077; Thu, 13 Feb 2025 19:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739476668; cv=pass; b=R3t3H0EnkdzV8RGt6YP06j43ZqgQcZ05aezc8PoxMntO/NaTLBhNwyb+NDLZRqyyy2SqUzhlvgTK6pQzb0/TtvxSq+gWE/x4wu1z+wVCUQ2FrJw4SJ7ZozDwQu/DD/PyT4UFCEWng5/7yF8pUbg+rO35oSJv0joTuNAnBYYaYtY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739476668; c=relaxed/simple; bh=UUG74ONh30vCq5cOPe65Lz2sQ6Akmb5m/0N/paSXXRQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cXqfV2hMxv57sv4JZhBhBJ6i7hRetXsHw2wl4khLkXwzhIO6jfxHTBDC9u1A4jbX/oOIG1gnwJbZM2SFZQese7LDS44553V0F8kzqjATOt1t0MXNPZ4RzyGBczEEOYgQwbVzmp1HOUeqwU920q9AGn5rt5aSw8KtNCbADtCOpQ8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=detlev.casanova@collabora.com header.b=Q8JxXioJ; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=detlev.casanova@collabora.com header.b="Q8JxXioJ" ARC-Seal: i=1; a=rsa-sha256; t=1739476614; cv=none; d=zohomail.com; s=zohoarc; b=esEGgr+Zc+tPVkIqhiCRV6/3ZsxDc/b/7YtkV3+NUknz0FJERHv4WjoZqgMDr0iDTIxSacyj5IPlCpt8EstN0ogUpvFHCO6Ksp0+hnliTj7wgOIMrvQdvM58YdUb1EBBZDXO2aeKLvNS2t5IrlANkgPMrKZlEmuKcOaOeJOaMv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1739476614; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=O9GUvvUpHX6LI0qZKWX7RNV6qQdN4u6UV5/FG212X8k=; b=UBUcN6htqFck41lfia/orvBJrZzH5gpvWL+MwUU7ojHmx+66zbMewaJEXL/ZRJyWve49TjgYNRjL2P0vaAdPK2OYYJgowrz0ZFKSyBDU4zl/aH4Konvn2RGJLFn2VQxYQEZY8au4FdJ9Et/985IvHoaa7AOjOSVVPHPx7dX1MR8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=detlev.casanova@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1739476614; s=zohomail; d=collabora.com; i=detlev.casanova@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Transfer-Encoding:Content-Type:Message-Id:Reply-To; bh=O9GUvvUpHX6LI0qZKWX7RNV6qQdN4u6UV5/FG212X8k=; b=Q8JxXioJ4lXs0iSCkgZYzAYIWz6Xdvv38+VFAq1AWFxHY2R8ItKJ6JvNt55lWScE bpnnMnehSwgma3fPFQvuLapE7XTGq1PPmnWWSzq/gNM0A7aBnTrD2ix6ArooKh8Cw+X dB7WkHBWQz34nQuKkmOdnyO8Fk0bPKmBcNhiK1XE= Received: by mx.zohomail.com with SMTPS id 1739476611230565.2581804087819; Thu, 13 Feb 2025 11:56:51 -0800 (PST) From: Detlev Casanova To: Jonas Karlman Cc: linux-kernel@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Dragan Simic , Chris Morgan , Kever Yang , Tim Lunn , FUKAUMI Naoki , Michael Riesch , Weizhao Ouyang , Elon Zhang , Alexey Charkov , Stephen Chen , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH v2 2/2] arm64: dts: rockchip: Add Radxa ROCK 4D device tree Date: Thu, 13 Feb 2025 14:56:48 -0500 Message-ID: <5973630.DvuYhMxLoT@trenzalore> In-Reply-To: References: <20250213145921.133412-1-detlev.casanova@collabora.com> <20250213145921.133412-3-detlev.casanova@collabora.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-ZohoMailClient: External Hi Jonas, On Thursday, 13 February 2025 10:48:10 EST Jonas Karlman wrote: > Hi Detlev, > > On 2025-02-13 15:57, Detlev Casanova wrote: > > From: Stephen Chen > > > > The Radxa ROCK 4D board is based on the Rockchip rk3576 SoC. > > > > The device tree adds support for basic devices: > > - UART > > - SD Card > > - Ethernet > > - USB > > - RTC > > > > It has 4 USB ports but only 3 are usable as the top left one is used > > for maskrom. > > > > It has a USB-C port that is only used for powering the board. > > > > Signed-off-by: Stephen Chen > > Signed-off-by: Detlev Casanova > > --- > > > > arch/arm64/boot/dts/rockchip/Makefile | 1 + > > .../boot/dts/rockchip/rk3576-rock-4d.dts | 651 ++++++++++++++++++ > > 2 files changed, 652 insertions(+) > > create mode 100644 arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts > > > > diff --git a/arch/arm64/boot/dts/rockchip/Makefile > > b/arch/arm64/boot/dts/rockchip/Makefile index > > def1222c1907e..a112aeb37948a 100644 > > --- a/arch/arm64/boot/dts/rockchip/Makefile > > +++ b/arch/arm64/boot/dts/rockchip/Makefile > > @@ -132,6 +132,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += > > rk3568-wolfvision-pf5-display-vz.dtbo> > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-io-expander.dtbo > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-sige5.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-evb1-v10.dtb > > > > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-rock-4d.dtb > > > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3582-radxa-e52c.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-sige7.dtb > > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-w3.dtb > > > > diff --git a/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts > > b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts new file mode 100644 > > index 0000000000000..f356742f9d643 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/rockchip/rk3576-rock-4d.dts > > @@ -0,0 +1,651 @@ > > [snip] > > > +&gmac0 { > > + phy-mode = "rgmii-id"; > > + clock_in_out = "output"; > > + > > + snps,reset-gpio = <&gpio2 RK_PB5 GPIO_ACTIVE_LOW>; > > + snps,reset-active-low; > > + snps,reset-delays-us = <0 20000 100000>; > > The snps,reset- props are deprecated and should be changed to reset- > props in the phy node. Arg, second time I use deprectated props on new things. Are there plans or ways to make dtbs_check warn about those ? > > + > > + pinctrl-names = "default"; > > + pinctrl-0 = <ð0m0_miim > > + ð0m0_tx_bus2 > > + ð0m0_rx_bus2 > > + ð0m0_rgmii_clk > > + ð0m0_rgmii_bus > > + ðm0_clk0_25m_out>; > > + > > + phy-handle = <&rgmii_phy0>; > > + status = "okay"; > > +}; > > [snip] > > > +&mdio0 { > > + rgmii_phy0: phy@1 { > > Maybe ethernet-phy@1 ? Indeed. > > + compatible = "ethernet-phy-ieee802.3-c22"; > > + reg = <0x1>; > > + clocks = <&cru REFCLKO25M_GMAC0_OUT>; > > Please add reset- props here. > > Changing to use reset- props may cause issue if a RTL8211F PHY is used > on the board. Use a ethernet-phy-id compatible or mainline U-Boot to > ensure the Ethernet PHY can be discovered during probe. Using downstream u-boot, with the RTL8211F PHY, linux can still detect the PHY and use it correctly, even with reset-* props at the PHY level. I guess I can keep those there then, unless the issues you mention are more subtle than that ? Detlev.