From: Krzysztof Kozlowski <krzk@kernel.org>
To: Magnus Damm <damm@opensource.se>, linux-renesas-soc@vger.kernel.org
Cc: robh@kernel.org, geert+renesas@glider.be,
devicetree@vger.kernel.org, conor+dt@kernel.org,
linux-kernel@vger.kernel.org, wsa+renesas@sang-engineering.com,
sergei.shtylyov@gmail.com, p.zabel@pengutronix.de
Subject: Re: [PATCH v2 3/4] memory: renesas-rpc-if: Add RZ/A1 and RZ/A2 support
Date: Sat, 12 Jul 2025 18:48:22 +0200 [thread overview]
Message-ID: <5977e5d9-c369-47f4-a35f-bc5c9488d5bc@kernel.org> (raw)
In-Reply-To: <175232759314.19062.13901247607746044271.sendpatchset@1.0.0.127.in-addr.arpa>
On 12/07/2025 15:39, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Add RZ/A1 and RZ/A2 compat strings to the rpc-if driver. Also make the
> reset controller optional. This is because RZ/A1 does not have any reset
> bits assigned to the device so there is no reset controller available.
That's different ABI and if you tested bindings, you would see warnings.
My previous instruction was really important so I am disappointed that
you replied that you are not going to test bindings or your DTS patches.
Fix the bindings.
> +
> static const struct of_device_id rpcif_of_match[] = {
> + { .compatible = "renesas,r7s72100-rpc-if", .data = &rpcif_info_rz_a },
> + { .compatible = "renesas,r7s9210-rpc-if", .data = &rpcif_info_rz_a },
So devices are compatible. Express it with proper fallbacks and don't
create redundant entries.
Or explain in the binding WHY they are not compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-12 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-12 13:39 [PATCH v2 0/4] Add RZ/A1 and RZ/A2 support to the rpc-if driver Magnus Damm
2025-07-12 13:39 ` [PATCH v2 1/4] dt-bindings: memory-controllers: renesas,rpc-if: Add RZ/A1 and RZ/A2 compat strings Magnus Damm
2025-07-12 16:45 ` Krzysztof Kozlowski
2025-07-12 19:06 ` Rob Herring (Arm)
2025-07-12 13:39 ` [PATCH v2 2/4] ARM: dts: renesas: r7s72100: add rpc-if nodes Magnus Damm
2025-07-12 13:39 ` [PATCH v2 3/4] ARM: dts: renesas: r7s9210: add rpc-if node Magnus Damm
2025-07-12 13:39 ` [PATCH v2 3/4] memory: renesas-rpc-if: Add RZ/A1 and RZ/A2 support Magnus Damm
2025-07-12 16:48 ` Krzysztof Kozlowski [this message]
2025-07-30 13:24 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5977e5d9-c369-47f4-a35f-bc5c9488d5bc@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=damm@opensource.se \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).