From mboxrd@z Thu Jan 1 00:00:00 1970 From: jeffy Subject: Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi Date: Mon, 18 Sep 2017 09:22:21 +0800 Message-ID: <59BF1FCD.3060501@rock-chips.com> References: <20170906025010.10750-1-jeffy.chen@rock-chips.com> <20170913172452.rqy2umufkuh26fzj@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170913172452.rqy2umufkuh26fzj@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: linux-kernel@vger.kernel.org, dgreid@chromium.org, heiko@sntech.de, briannorris@chromium.org, mka@chromium.org, dianders@chromium.org, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood , Mark Brown , Mark Rutland List-Id: devicetree@vger.kernel.org Hi Rob, Thanks for your reply. On 09/14/2017 01:24 AM, Rob Herring wrote: > On Wed, Sep 06, 2017 at 10:50:09AM +0800, Jeffy Chen wrote: >> diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt >> index 929ca6756b02..841a1159e234 100644 >> --- a/Documentation/devicetree/bindings/sound/rt5514.txt >> +++ b/Documentation/devicetree/bindings/sound/rt5514.txt >> @@ -4,7 +4,7 @@ This device supports I2C only. > > SPI support should be added to this document. ok, will do. > >> >> Required properties: >> >> -- compatible : "realtek,rt5514". >> +- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c". > > There's no need for the -spi or -i2c compatibles. This is implied by > being a child of those controllers. heiko mentioned i should add it in the binding in: https://patchwork.kernel.org/patch/9918987/