From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Rowand Subject: Re: [PATCH] of: overlay: move resolve phandles into of_overlay_apply() Date: Mon, 16 Oct 2017 17:24:01 -0700 Message-ID: <59E54DA1.4050909@gmail.com> References: <1507683745-17499-1-git-send-email-frowand.list@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Rob Herring Cc: Pantelis Antoniou , David Airlie , Jyri Sarha , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Mark Rutland , Tomi Valkeinen , dri-devel List-Id: devicetree@vger.kernel.org On 10/16/17 13:46, Rob Herring wrote: > On Tue, Oct 10, 2017 at 8:02 PM, wrote: >> From: Frank Rowand >> >> Move more code into of_overlay_apply() so that it does not have >> to be duplicated by each caller of of_overlay_apply(). >> >> The test in of_resolve_phandles() that the overlay tree is detached is >> temporarily disabled so that old style overlay unittests do not fail. >> >> Signed-off-by: Frank Rowand >> --- >> >> This patch applies on top of the series: "[PATCH 00/12] of: overlay: clean >> up device tree overlay code". >> >> While reviewing "[PATCH 09/12] of: overlay: avoid race condition between >> applying multiple overlays", Rob asked if of_resolve_phandles() could be >> moved into of_overlay_apply(). This patch is what is involved in doing so. > > Looks fine. Can you squash this into patch 9 and resend the series (or > at least 9-12). The rest all looks fine to me. > > Rob > Thanks, I'll do that. -Frank