From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Marc Gonzalez <mgonzalez@freebox.fr>,
AML <linux-amlogic@lists.infradead.org>,
DT <devicetree@vger.kernel.org>
Cc: Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Pierre-Hugues Husson <phhusson@freebox.fr>
Subject: Re: [RFC PATCH v1] arm64: dts: amlogic: Add Freebox fbx8am boards
Date: Tue, 6 Feb 2024 14:30:43 +0100 [thread overview]
Message-ID: <59ef3824-13d3-40af-9a3a-9b1ec8add9d3@linaro.org> (raw)
In-Reply-To: <b69a2132-25c0-4acd-808e-d134f5034e58@linaro.org>
Hi,
On 06/02/2024 14:22, Krzysztof Kozlowski wrote:
> On 06/02/2024 14:12, Marc Gonzalez wrote:
>> From: Pierre-Hugues Husson <phhusson@freebox.fr>
>>
>> The fbx8am boards are based on the Amlogic Meson G12A S905X2 SoC,
>> and the SEI510 board design.
>>
>> Signed-off-by: Pierre-Hugues Husson <phhusson@freebox.fr>
>> Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
>> ---
>> Request For Comments to spot obvious mistakes before formal submission
>> NB: on IRC, narmstrong mentioned:
>>> adding dtbos for variants seems to be the new preferred way to handle such case
>>> the fdtoverlay utility works well for this case
>
> Please run scripts/checkpatch.pl and fix reported warnings. Some
> warnings can be ignored, but the code here looks like it needs a fix.
> Feel free to get in touch if the warning is not clear.
I don't have checkpatch errors, I'm running with `--strict --terse`.
I do have some dtbs_check errors, but those are expected since they are not specific to this patchset.
Neil
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2024-02-06 13:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 13:12 [RFC PATCH v1] arm64: dts: amlogic: Add Freebox fbx8am boards Marc Gonzalez
2024-02-06 13:22 ` Krzysztof Kozlowski
2024-02-06 13:30 ` Neil Armstrong [this message]
2024-02-06 13:33 ` Krzysztof Kozlowski
2024-02-06 13:55 ` Marc Gonzalez
2024-02-06 14:01 ` Neil Armstrong
2024-02-06 13:31 ` Marc Gonzalez
2024-02-06 13:34 ` Krzysztof Kozlowski
2024-02-06 13:38 ` Neil Armstrong
2024-02-07 18:37 ` Marc Gonzalez
2024-02-12 15:14 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59ef3824-13d3-40af-9a3a-9b1ec8add9d3@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mgonzalez@freebox.fr \
--cc=phhusson@freebox.fr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox