From: Wei Xu <xuwei5@hisilicon.com>
To: Leo Yan <leo.yan@linaro.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Kevin Wang <jean.wangtao@linaro.org>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [PATCH] arm64: dts: Hi3660: Remove 'CPU_NAP' idle state
Date: Fri, 2 Mar 2018 15:57:39 +0000 [thread overview]
Message-ID: <5A997473.40706@hisilicon.com> (raw)
In-Reply-To: <20180228050803.GB20745@leoy-ThinkPad-T440>
Hi Leo,
On 2018/2/28 5:08, Leo Yan wrote:
> Hi Wei,
>
> On Tue, Jan 09, 2018 at 12:32:42PM +0800, Leo Yan wrote:
>> Thanks a lot for Vincent Guittot careful work to find bug for 'CPU_NAP'
>> idle state. At early time, the CPU CA73 CPU_NAP idle state has been
>> supported on Hikey960. Later we found the system has the hang issue
>> and for resolving this issue Hisilicon released new MCU firmware, but
>> unfortunately the new MCU firmware has side effect and results in the
>> CA73 CPU cannot really enter CPU_NAP state and roll back to WFI state.
>>
>> After discussion we cannot see the possibility to enable CA73 CPU_NAP
>> state anymore on Hikey960, based on this conclusion we should remove
>> this state from DT binding.
>>
>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>> Cc: Kevin Wang <jean.wangtao@linaro.org>
>> Cc: Vincent Guittot <vincent.guittot@linaro.org>
>> Signed-off-by: Leo Yan <leo.yan@linaro.org>
>
> Could you help to pick up this patch? Thanks!
Applied into hisilicon dt tree.
Thanks!
Best Regards,
Wei
>
>> ---
>> arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 32 ++++---------------------------
>> 1 file changed, 4 insertions(+), 28 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
>> index ab0b95b..8fddf0d 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi
>> @@ -96,11 +96,7 @@
>> reg = <0x0 0x100>;
>> enable-method = "psci";
>> next-level-cache = <&A73_L2>;
>> - cpu-idle-states = <
>> - &CPU_NAP
>> - &CPU_SLEEP
>> - &CLUSTER_SLEEP_1
>> - >;
>> + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_1>;
>> };
>>
>> cpu5: cpu@101 {
>> @@ -109,11 +105,7 @@
>> reg = <0x0 0x101>;
>> enable-method = "psci";
>> next-level-cache = <&A73_L2>;
>> - cpu-idle-states = <
>> - &CPU_NAP
>> - &CPU_SLEEP
>> - &CLUSTER_SLEEP_1
>> - >;
>> + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_1>;
>> };
>>
>> cpu6: cpu@102 {
>> @@ -122,11 +114,7 @@
>> reg = <0x0 0x102>;
>> enable-method = "psci";
>> next-level-cache = <&A73_L2>;
>> - cpu-idle-states = <
>> - &CPU_NAP
>> - &CPU_SLEEP
>> - &CLUSTER_SLEEP_1
>> - >;
>> + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_1>;
>> };
>>
>> cpu7: cpu@103 {
>> @@ -135,24 +123,12 @@
>> reg = <0x0 0x103>;
>> enable-method = "psci";
>> next-level-cache = <&A73_L2>;
>> - cpu-idle-states = <
>> - &CPU_NAP
>> - &CPU_SLEEP
>> - &CLUSTER_SLEEP_1
>> - >;
>> + cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP_1>;
>> };
>>
>> idle-states {
>> entry-method = "psci";
>>
>> - CPU_NAP: cpu-nap {
>> - compatible = "arm,idle-state";
>> - arm,psci-suspend-param = <0x0000001>;
>> - entry-latency-us = <7>;
>> - exit-latency-us = <2>;
>> - min-residency-us = <15>;
>> - };
>> -
>> CPU_SLEEP: cpu-sleep {
>> compatible = "arm,idle-state";
>> local-timer-stop;
>> --
>> 2.7.4
>>
>
> .
>
prev parent reply other threads:[~2018-03-02 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 4:32 [PATCH] arm64: dts: Hi3660: Remove 'CPU_NAP' idle state Leo Yan
[not found] ` <1515472362-19979-1-git-send-email-leo.yan-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-10 8:38 ` Vincent Guittot
2018-02-28 5:08 ` Leo Yan
2018-03-02 15:57 ` Wei Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5A997473.40706@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jean.wangtao@linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).