From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Xu Subject: Re: [PATCH 05/10] ARM64: dts: hi6220: Remove "cooling-{min|max}-level" for CPU nodes Date: Fri, 2 Mar 2018 16:03:54 +0000 Message-ID: <5A9975EA.3010306@hisilicon.com> References: <68740229a7397336ae92bad65f69a58c91819c37.1518166039.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <68740229a7397336ae92bad65f69a58c91819c37.1518166039.git.viresh.kumar@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar , Rafael Wysocki Cc: linux-pm@vger.kernel.org, Vincent Guittot , Eduardo Valentin , Mark Rutland , Rob Herring , Zhang Rui , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, daniel.lezcano@linaro.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Viresh, On 2018/2/9 8:58, Viresh Kumar wrote: > The "cooling-min-level" and "cooling-max-level" properties are not > parsed by any part of the kernel currently and the max cooling state of > a CPU cooling device is found by referring to the cpufreq table instead. > > Moreover, the entries are incorrect here as min level is 4 and the max > level is 0. > > Remove the unused properties from the CPU nodes. > > Signed-off-by: Viresh Kumar > --- Applied into hisilicon dt tree. Thanks! BR, Wei > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > index 6a180d1926e8..fca8e4ee98e7 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi > @@ -88,8 +88,6 @@ > next-level-cache = <&CLUSTER0_L2>; > clocks = <&stub_clock 0>; > operating-points-v2 = <&cpu_opp_table>; > - cooling-min-level = <4>; > - cooling-max-level = <0>; > #cooling-cells = <2>; /* min followed by max */ > cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; > dynamic-power-coefficient = <311>; >