From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Xu Subject: Re: [PATCH 3/6] arm64: dts: hisilicon: Add missing cooling device properties for CPUs Date: Sat, 26 May 2018 19:21:40 +0100 Message-ID: <5B09A5B4.4050904@hisilicon.com> References: <0754957a2c3842cf4e36fa27231d327fd8d6d499.1527225682.git.viresh.kumar@linaro.org> <5B09A0B4.2080400@hisilicon.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5B09A0B4.2080400@hisilicon.com> Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar , arm@kernel.org, Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon Cc: Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Viresh, On 2018/5/26 19:00, Wei Xu wrote: > Hi Viresh, > > On 2018/5/25 6:40, Viresh Kumar wrote: >> The cooling device properties, like "#cooling-cells" and >> "dynamic-power-coefficient", should either be present for all the CPUs >> of a cluster or none. If these are present only for a subset of CPUs of >> a cluster then things will start falling apart as soon as the CPUs are >> brought online in a different order. For example, this will happen >> because the operating system looks for such properties in the CPU node >> it is trying to bring up, so that it can register a cooling device. >> >> Add such missing properties. >> >> Do minor rearrangement as well to keep ordering consistent. >> >> Signed-off-by: Viresh Kumar > > Thanks! > Applied to the hisilicon fix tree. Sorry for the noise! It seems this patch is still under discussion. I will drop it firstly. Best Regards, Wei > > Best Regards, > Wei > >> --- >> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 16 +++++++++++++++- >> 1 file changed, 15 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> index 586b281cd531..247024df714f 100644 >> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi >> @@ -88,8 +88,8 @@ >> next-level-cache = <&CLUSTER0_L2>; >> clocks = <&stub_clock 0>; >> operating-points-v2 = <&cpu_opp_table>; >> - #cooling-cells = <2>; /* min followed by max */ >> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; >> + #cooling-cells = <2>; /* min followed by max */ >> dynamic-power-coefficient = <311>; >> }; >> >> @@ -101,6 +101,8 @@ >> next-level-cache = <&CLUSTER0_L2>; >> operating-points-v2 = <&cpu_opp_table>; >> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; >> + #cooling-cells = <2>; /* min followed by max */ >> + dynamic-power-coefficient = <311>; >> }; >> >> cpu2: cpu@2 { >> @@ -111,6 +113,8 @@ >> next-level-cache = <&CLUSTER0_L2>; >> operating-points-v2 = <&cpu_opp_table>; >> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; >> + #cooling-cells = <2>; /* min followed by max */ >> + dynamic-power-coefficient = <311>; >> }; >> >> cpu3: cpu@3 { >> @@ -121,6 +125,8 @@ >> next-level-cache = <&CLUSTER0_L2>; >> operating-points-v2 = <&cpu_opp_table>; >> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; >> + #cooling-cells = <2>; /* min followed by max */ >> + dynamic-power-coefficient = <311>; >> }; >> >> cpu4: cpu@100 { >> @@ -131,6 +137,8 @@ >> next-level-cache = <&CLUSTER1_L2>; >> operating-points-v2 = <&cpu_opp_table>; >> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; >> + #cooling-cells = <2>; /* min followed by max */ >> + dynamic-power-coefficient = <311>; >> }; >> >> cpu5: cpu@101 { >> @@ -141,6 +149,8 @@ >> next-level-cache = <&CLUSTER1_L2>; >> operating-points-v2 = <&cpu_opp_table>; >> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; >> + #cooling-cells = <2>; /* min followed by max */ >> + dynamic-power-coefficient = <311>; >> }; >> >> cpu6: cpu@102 { >> @@ -151,6 +161,8 @@ >> next-level-cache = <&CLUSTER1_L2>; >> operating-points-v2 = <&cpu_opp_table>; >> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; >> + #cooling-cells = <2>; /* min followed by max */ >> + dynamic-power-coefficient = <311>; >> }; >> >> cpu7: cpu@103 { >> @@ -161,6 +173,8 @@ >> next-level-cache = <&CLUSTER1_L2>; >> operating-points-v2 = <&cpu_opp_table>; >> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; >> + #cooling-cells = <2>; /* min followed by max */ >> + dynamic-power-coefficient = <311>; >> }; >> >> CLUSTER0_L2: l2-cache0 { >>