From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Subject: Re: [PATCH] Add device file bindings for MAPLE Date: Thu, 1 Aug 2013 11:05:09 -0500 Message-ID: <5C32ABF4-ECC3-4F1C-82D0-EA3AD9053575@kernel.crashing.org> References: <1375354963-11219-1-git-send-email-shaveta@freescale.com> Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1375354963-11219-1-git-send-email-shaveta@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Shaveta Leekha Cc: devicetree-discuss@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org List-Id: devicetree@vger.kernel.org On Aug 1, 2013, at 6:02 AM, Shaveta Leekha wrote: > Signed-off-by: Shaveta Leekha > --- > .../devicetree/bindings/powerpc/fsl/maple.txt | 30 ++++++++++++++++++++ > 1 files changed, 30 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/maple.txt > > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/maple.txt b/Documentation/devicetree/bindings/powerpc/fsl/maple.txt > new file mode 100644 > index 0000000..da51c5f > --- /dev/null > +++ b/Documentation/devicetree/bindings/powerpc/fsl/maple.txt > @@ -0,0 +1,30 @@ > +* Freescale MAPLE Multi Accelerator Platform Engine Baseband 3 > + (MAPLE-B3)device nodes > + > +Supported chips: > +Example: B4860 > + > +Required properties: > + > +- compatible: Should contain "fsl,maple-b3-liodn" as the value > + This identifies Multi Accelerator Platform Engine > + Baseband 3 block.This representation is required > + for doing the PAMU/LIODN programming on the Linux side. This compatible makes no sense, we shouldn't be marking a full HW block with some name that is just intended for LIODN convenance. Is this version 3 of the block? If so a name like "fsl,maple-v3" or "fsl,maple-v3.0" would be more appropriate. - k > + > +- reg: offset and length of the register set for the device > + > +Devices that have LIODNs need to specify links to the parent PAMU controller > +(the actual PAMU controller that this device is connected to) and a pointer to > +the LIODN register, if applicable. Does Maple not have any IRQs associated with it? If you are going to have a minimal binding, at least cover the basics associated with a device. > + > +- fsl,iommu-parent > + : > + This property should be present > + > +Example: > + /* B4860 */ > + maple@800000 { > + compatible = "fsl,maple-b3-liodn"; > + reg = <0x8000000 0x10000>; > + fsl,iommu-parent = <&pamu1>; > + }; > -- > 1.7.6.GIT > > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev