From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhou Yanjie Subject: Re: [PATCH 4/4] MMC: Ingenic: Add support for JZ4760 and support for LPM. Date: Sun, 6 Oct 2019 13:58:22 +0800 Message-ID: <5D99827E.9070505@zoho.com> References: <1567669089-88693-1-git-send-email-zhouyanjie@zoho.com> <1567669089-88693-5-git-send-email-zhouyanjie@zoho.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ulf Hansson Cc: linux-mips@vger.kernel.org, Linux Kernel Mailing List , "linux-mmc@vger.kernel.org" , DTML , Paul Burton , Linus Walleij , Paul Cercueil , Mathieu Malaterre , YueHaibing , Ezequiel Garcia , Rob Herring , Mark Rutland , syq@debian.org, jiaxun.yang@flygoat.com List-Id: devicetree@vger.kernel.org Hi Uffe, On 2019=E5=B9=B410=E6=9C=8803=E6=97=A5 18:00, Ulf Hansson wrote: > On Thu, 5 Sep 2019 at 09:40, Zhou Yanjie wrote: >> 1.add support for probing mmc driver on the JZ4760 Soc from Ingenic. >> 2.add support for Low Power Mode of Ingenic's MMC/SD Controller. > Normally we try to make "one" change per patch, unless there are some > good reasons not to. > > In this case, it seems like you should rather split this patch into > two separate pieces. Can you please do that? OK,I'll split it in v2. > > Additionally, please change the prefix for the commit message header > to start with "mmc: jz4740:" sure, it will be change in v2. > > [...] > > Kind regards > Uffe Thanks and best regards!