From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Subject: Re: [PATCH] libfdt: Add support for using aliases in fdt_path_offset() Date: Thu, 14 Aug 2008 07:02:54 -0500 Message-ID: <5DCA3107-7574-4E1F-9160-B2257BFE3F81@kernel.crashing.org> References: <20080814041557.GE18344@yookeroo.seuss> Mime-Version: 1.0 (Apple Message framework v926) Content-Type: text/plain; charset="us-ascii"; Format="flowed"; DelSp="yes" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080814041557.GE18344@yookeroo.seuss> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: David Gibson Cc: linuxppc-dev@ozlabs.org, Jon Loeliger , devicetree-discuss@ozlabs.org List-Id: devicetree@vger.kernel.org On Aug 13, 2008, at 11:15 PM, David Gibson wrote: > On Wed, Aug 13, 2008 at 10:52:26PM -0500, Kumar Gala wrote: >> If the path doesn't start with '/' check to see if it matches some >> alias >> under "/aliases" and substitute the matching alias value in the path >> and retry the lookup. > > Kumar, this is broken. If you match an alias you only follow the path > one level down from there. i.e. you will correctly resolve > 'somealias' and 'somealias/foo', but not 'somealias/foo/bar'. I'm not clear on what cases you are suggesting fail. - k