Re: [PATCH 1/4] Documentation: dt-bindings: iio: Add max961x

[Jonathan Cameron <jic23@kernel.org>]

On 25/02/17 15:34, Geert Uytterhoeven wrote:
> Hi Jonathan,
> 
> On Sat, Feb 25, 2017 at 4:19 PM, Jonathan Cameron <jic23@kernel.org> wrote:
>> On 24/02/17 15:48, jacopo mondi wrote:
>>> On 24/02/2017 16:33, Lars-Peter Clausen wrote:
>>>> On 02/24/2017 04:22 PM, Geert Uytterhoeven wrote:
>>>>> On Fri, Feb 24, 2017 at 4:05 PM, Jacopo Mondi <jacopo+renesas@jmondi.org> wrote:
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/devicetree/bindings/iio/adc/max961x.txt
>>>>>> @@ -0,0 +1,27 @@
>>>>>> +* Maxim max9611/max9612 current sense amplifier with 12-bits ADC interface
>>>>>> +
>>>>>> +Maxim max9611/max9612 is an high-side current sense amplifier with integrated
>>>>>> +12-bits ADC communicating over I2c bus.
>>>>>> +The device node for this driver shall be a child of a I2c controller.
>>>>>> +
>>>>>> +Required properties
>>>>>> +  - compatible: Should be "maxim,max961x"
>>>>>> +  - reg: The 7-bits long I2c address of the device
>>>>>> +  - shunt-resistor: Resistor value, in uOhm, of the current sense shunt
>>>>>> +                   resistor.
>>>>>
>>>>> shunt-resistor-micro-ohms?
>>>>
>>>> I'll take this one further:
>>>>
>>>> maxim,shunt-resistor-micro-ohms?
>>>>
>>>> Although there is precedence for just 'shunt-resistor' in the ina2xx bindings.
>>>>
>>>
>>> And that's where I took "inspiration" from :)
>> Which raises another open question.  Why IIO rather than hwmon like the ina2xx?
> 
> Actually we have both drivers/hwmon/ina2xx.c and drivers/iio/adc/ina2xx-adc.c.
Oops,. I'd forgotten about that.

Need that discussion to happen though before I take it into IIO though.
> 
>> Whether we are better going for the existing binding without units, or
>> 'fixing' that is a question for the device tree maintainers.  I guess that
>> one snuck through.
> 
> ltc4151 uses shunt-resistor-micro-ohms.
> sgtl5000 uses micbias-resistor-k-ohms.
> 
> So there's precedence for everything ;-)
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>