From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8FEF444705; Thu, 3 Sep 2026 08:14:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788423267; cv=none; b=irXS/d0rJKrYiZULnsDrBrOtaseSWaNFqA83OAmGpllOCvZRYfn/SkKolqTP0EYCddqccAa7t59XpBaDo3GariO4sH21YluzeYYRoGIrYPTaRMI5b0w9OLvUoIGqcibb1lQXgO7sAAoSOlQvv3vEuYdexqrrkhJQto1SqSpTCb4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788423267; c=relaxed/simple; bh=rWyBiQvB7n5CN5RlRrY4rVWbEHWQvYAoOZe3ttybowE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rnBAS5EGkoBuD75WMRJuyMvuqna1R53Xy10rB4d74AjWoJalBZas4DYriPpWlkIRyxiMPqqSni0d+wdEuXcN7UlycJyDbnU7o0MfEXZfMTE/IAHJ/hawZmunBpMqTaN5A+ZF0ojsyQFWFKw6S8qtoJKfqbOPu5ut/w7lFm6rj1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BQ9AOF+X; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BQ9AOF+X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E0D91F000E9; Thu, 3 Sep 2026 08:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788423265; bh=lfiktVcA3WoDPS6LtdsBA19LLQB2OOe4eJAn9/Nw4Is=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=BQ9AOF+XjuYiQrsvSEtmDeAnaeFuhBtsvsjZceFIy8oz2bQ/VW0b8cRggVLeh+SQ8 wzSorWt+s2/9YKNnnTl1n7QaBQWWFH/y2QwL/jnjTaY1RF+xljeL/9dMqi9SuAiuqs tYAui1wQcS44I1dEmyGRPtj3DZBz9mJWGj8lLxx6rB1+FxuvAWITIecmh4nF9ixlz/ ILBRsdWO9bP55CcFU3YzYq4b3G1ufK8tN/BOY8tYYnOSicE2C6bFBXo2+3dHhtcXWh YzNsEl/ojAgETq7nlJXlrKpOgVhb6tm5e4QnoyNllJqQFjJl4BTiwZ9b8p6cyTrC0q gsKCDW7rQMiwg== Message-ID: <5a3c4409-9398-4341-a478-96915ca2d65b@kernel.org> Date: Thu, 3 Sep 2026 10:14:20 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers To: Krishna Kurapati , Konrad Dybcio Cc: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260828081542.52796-1-krishna.kurapati@oss.qualcomm.com> <20260831-messy-ebony-warthog-cfd727@quoll> <6af2e860-ba7a-4f86-a0e7-872a312b47e4@oss.qualcomm.com> <3574212b-1a4b-486a-97df-1d6ae7895097@kernel.org> <80f21ab6-3d4e-445a-b156-7326b0e92998@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGPBBMBCgA5AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJp2mE8AAoJEBuTQ307QWKbeaIP /ihHTkTW4KsN/DQ945JJbyu5tI0J80Wue7QyyLPglyKfhgb5cLLNPpOC8cCIJsc7+W3i2P38 s2c1cOH6CYGE7E9ur3Vfme8NW2S2I/Z8VC7bZnzyS23wT17LrsdS/qCpx4o8U+pt/xdXDKph EGRYrIEmMpUWvyYzyYKGIe25FtaayIIKpq8eZYyFcp2f/sG5IkOW5uZzHPMPdcm87jU7fyuQ rAU2vx9r+ulUfQ/q9Z2roC/ode3l7t2pN7BCBCsUDp6JCrUyZrtT1e7EbA0ZRP3aOBNk2P2E DQOgJGjGdO5Yx2Y9LFtltu6JbsBJHi1syGRX3AtQYOMc4Y1WGoeZJmMlvKj2ZqqXNkcWi2DS IQEWB0uW6CqFsBBIMGDa+6OzdaVO/uAVXWDWml02Men3CILdI1MbVjoh8ECqYUY7OQ+JJvNN vnliuq5WM3Ghd3jg/LZZrxXjdIginRHFQCjIJYLKpLZWm1/iDFedcfzqRNYmTtqscdCNHW41 oT3Z7BmO9xwdjuwBS6nmS6JJwkbf5Ot2QR4pB/DRU7ZwjT1qHe+9r9gF32wXVQatHNGK/VVu sfwOnkdxCWkp/qb2gdQRmZh+SedStWshigH6sNfuHBloF/q+hjMRc8b2m326OZdrbSHwY1Sz vti8Hn7n8NjdHO9LKB7BIdjkA9DA5WsqOuVCzsFNBFVDXDQBEADNkrQYSREUL4D3Gws46JEo Z9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLueMNsWLJBv BaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6eiOMheesVS 5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wAGldWsRxb f3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA6z6lBZn0 WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9YegxWKvX XHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt91pFzBSO IpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gUBLHFTg2h YnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/JoFzZ4B0 p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu4vXVFBYI GmpyNPYzRm0QPwARAQABwsF2BBgBCgAgAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmna YUkACgkQG5NDfTtBYptX+BAApg32CkxwNucNEi8WfWA8oKkW0y8YDuY6ORMo9FWNGiT/OTy0 vyJrLocrpn86zwfjVp+eCrssPYh8eqJfnWqmYv6ACQtHPYzPZQ3mSo8H97Z01oUxITzCxpXm ZkLgPIqtDPcC2E3dPM/fVxcyowM8XsaMA9wcsaUYrta8toOq2b9tKcjleKMfMrm0gQ9u7wUc QbLkwj6TCLOwucb07GXzLTNF9PZmaDUpKAZjMjmrW+le+SFvQbhamx0rxLWPR0NWntXpbCn+ +ACch03p/JyTBVktxFsFyCt7pTPE1kEaeuXBTe/a2D9iQvRxRW19LvuO2e59/u1wYUiH/orz wbIC2S4dBsPAPihL3ztOU1yE86GPyQtSE0kU+/7snnLt4QGi6PChf3t5gnNjAzjUUovO8rgI c+5yN5heq5loYHgK6OQ9OlHzsPHO9e9MOQcKlFycs1pyijFGzDwdNUm/SchK8iWT2QApTx4A K9bCVaboTA2T77QYkRcRJYSsO1alGX0ome/hMLD1daXlkrNUp1HWa3K4iytLRXjCSIorWiGs n+q3krnpXu3TFkA8qtOFZMdnIiFuiq1yLT8hptsV5xh1TA2nsVvSYiaCr3q4s4BKjS/KrLDb qoxzw8ISjdUp4pA85vb6YLCmb39NgidD+7PmAr65lBNveIFynTgsja1rRQ4= In-Reply-To: <80f21ab6-3d4e-445a-b156-7326b0e92998@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 03/09/2026 10:11, Krishna Kurapati wrote: > > > On 9/3/2026 12:11 PM, Krzysztof Kozlowski wrote: >> On 02/09/2026 16:10, Konrad Dybcio wrote: >>> On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote: >>>> On 31/08/2026 11:03, Krishna Kurapati wrote: >>>>> >>>>> >>>>> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote: >>>>>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote: >>>>>>> Currently for Glymur non-multiport USB controllers, number of interrupts >>>>>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be >>>>>>> present. >>> >>> [...] >>> >>>>>>> - qcom,eliza-dwc3 >>>>>>> + - qcom,glymur-dwc3 >>>>>>> - qcom,ipq4019-dwc3 >>>>>>> - qcom,ipq8064-dwc3 >>>>>>> - qcom,kaanapali-dwc3 >>>>>> >>>>>> This changes the ABI without an explanation. >>>>>> >>>>> As per the harware specification, the controllers do have both >>>>> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that >>>>> info. Will update the commit message accordingly. >>>>> >>>> >>>> So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was >>>> incomplete? Lack of context here is not helping. >>>> >>>> If they have these IRQs but it does not matter, then it is not a good >>>> reason to change ABI and you should just add the clock as optional to >>>> the end. Was this binding already released? I think yes. >>> >>> IIUC the intent of the patch is to allow specifying the currently >>> missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]). >>> Bundling the DT change would have made that easier. >> >> This does not answer my concerns. So repeating: patch is changing ABI >> without an explanation. This means contributor needs to provide >> explanation for the ABI change in terms of actual impact. >> > From a functional standpoint, there would be no effect. I was trying to > make the bindings reflect that the hardware has hs_phy_irq. If there is no functional impact, so before everything was fine and now is fine as well, then usual expectations is to make it backwards-compatible way, so grow the list with minItems. Best regards, Krzysztof