* [PATCH v4 1/2] arm64: dts: rockchip: Add EmbedFire LubanCat 1
@ 2022-12-21 5:46 Yuteng Zhong
2022-12-21 5:52 ` [PATCH v4 2/2] dt-bindings: arm: " Yuteng Zhong
2022-12-21 8:15 ` [PATCH v4 1/2] arm64: dts: " Krzysztof Kozlowski
0 siblings, 2 replies; 10+ messages in thread
From: Yuteng Zhong @ 2022-12-21 5:46 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Peter Geis, Krzysztof Kozlowski, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip, Yuteng Zhong,
DHDAXCW
from: DHDAXCW <lasstp5011@gmail.com>
LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd.
Mini Linux Card Type Cheap Computer Development Board
It has the following characteristics:
- MicroSD card slot, onboard eMMC flash memory
- 1GbE Realtek RTL8211F Ethernet Transceiver
- 1 USB Type-C port (power and USB2.0 OTG)
- 1 USB 3.0 Host port
- 3 USB 2.0 Host ports
- 1 HDMI
- 1 infrared receiver
- 1 MIPI DSI
- 1 MIPI CSI
- 1 x 4-section headphone jack
- Mini PCIe socket (USB or PCIe)
- 1 SIM Card slot
- 1 SYS LED and 1 PWR LED
- 40-pin GPIO expansion header
Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
---
Changed in V2:
- Remove RNG node
Changed in V3:
- Sent E-mail with a wrong attachment
Changed in V4:
- Modify all node names
---
arch/arm64/boot/dts/rockchip/Makefile | 1 +
.../boot/dts/rockchip/rk3566-lubancat-1.dts | 598 ++++++++++++++++++
2 files changed, 599 insertions(+)
create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
index 0a76a2ebb5f6..e52bda04d45a 100644
--- a/arch/arm64/boot/dts/rockchip/Makefile
+++ b/arch/arm64/boot/dts/rockchip/Makefile
@@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
new file mode 100644
index 000000000000..443fcfabbd16
--- /dev/null
+++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
@@ -0,0 +1,598 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+* Copyright (c) 2021 Rockchip Electronics Co., Ltd.
+*/
+
+/dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
+#include <dt-bindings/pinctrl/rockchip.h>
+#include <dt-bindings/soc/rockchip,vop2.h>
+#include "rk3566.dtsi"
+
+/ {
+ model = "EmbedFire LubanCat 1";
+ compatible = "embedfire,lubancat-1", "rockchip,rk3566";
+
+ aliases {
+ ethernet0 = &gmac1;
+ mmc0 = &sdmmc0;
+ mmc1 = &sdhci;
+ };
+
+ chosen: chosen {
+ stdout-path = "serial2:1500000n8";
+ };
+
+ gmac1_clkin: external-gmac1-clock {
+ compatible = "fixed-clock";
+ clock-frequency = <125000000>;
+ clock-output-names = "gmac1_clkin";
+ #clock-cells = <0>;
+ };
+
+ hdmi-con {
+ compatible = "hdmi-connector";
+ type = "a";
+
+ port {
+ hdmi_con_in: endpoint {
+ remote-endpoint = <&hdmi_out_con>;
+ };
+ };
+ };
+
+ gpio-leds {
+ compatible = "gpio-leds";
+
+ sys_led: sys-led {
+ label = "sys_led";
+ linux,default-trigger = "heartbeat";
+ default-state = "on";
+ gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sys_led_pin>;
+ };
+ };
+
+ usb_5v: usb-5v-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "usb_5v";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ };
+
+ vcc5v0_sys: vcc5v0-sys-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc5v0_sys";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ vin-supply = <&usb_5v>;
+ };
+
+ vcc3v3_sys: vcc3v3-sys {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc3v3_sys";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ vin-supply = <&vcc5v0_sys>;
+ };
+
+ vcc3v3_pcie: vcc3v3-pcie-regulator {
+ compatible = "regulator-fixed";
+ regulator-name = "vcc3v3_pcie";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ enable-active-high;
+ gpio = <&gpio0 RK_PD3 GPIO_ACTIVE_HIGH>;
+ startup-delay-us = <5000>;
+ vin-supply = <&vcc5v0_sys>;
+ };
+
+ vcc5v0_usb20_host: vcc5v0-usb20-host-regulator {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ gpio = <&gpio2 RK_PB6 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&vcc5v0_usb20_host_en>;
+ regulator-name = "vcc5v0_usb20_host";
+ regulator-always-on;
+ };
+
+ vcc5v0_usb30_host: vcc5v0-usb30-host-regulator {
+ compatible = "regulator-fixed";
+ enable-active-high;
+ gpio = <&gpio2 RK_PB5 GPIO_ACTIVE_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&vcc5v0_usb30_host_en>;
+ regulator-name = "vcc5v0_usb30_host";
+ regulator-always-on;
+ };
+};
+
+&uart2 {
+ status = "okay";
+};
+
+&combphy1 {
+ status = "okay";
+};
+
+&combphy2 {
+ status = "okay";
+};
+
+&cpu0 {
+ cpu-supply = <&vdd_cpu>;
+};
+
+&cpu1 {
+ cpu-supply = <&vdd_cpu>;
+};
+
+&cpu2 {
+ cpu-supply = <&vdd_cpu>;
+};
+
+&cpu3 {
+ cpu-supply = <&vdd_cpu>;
+};
+
+&gpu {
+ mali-supply = <&vdd_gpu>;
+ status = "okay";
+};
+
+&hdmi {
+ avdd-0v9-supply = <&vdda0v9_image>;
+ avdd-1v8-supply = <&vcca1v8_image>;
+ status = "okay";
+};
+
+&hdmi_in {
+ hdmi_in_vp0: endpoint {
+ remote-endpoint = <&vp0_out_hdmi>;
+ };
+};
+
+&hdmi_out {
+ hdmi_out_con: endpoint {
+ remote-endpoint = <&hdmi_con_in>;
+ };
+};
+
+&hdmi_sound {
+ status = "okay";
+};
+
+&i2c0 {
+ status = "okay";
+
+ vdd_cpu: regulator@1c {
+ compatible = "tcs,tcs4525";
+ reg = <0x1c>;
+ fcs,suspend-voltage-selector = <1>;
+ regulator-name = "vdd_cpu";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <800000>;
+ regulator-max-microvolt = <1150000>;
+ regulator-ramp-delay = <2300>;
+ vin-supply = <&vcc5v0_sys>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ rk809: pmic@20 {
+ compatible = "rockchip,rk809";
+ reg = <0x20>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PA3 IRQ_TYPE_LEVEL_LOW>;
+ clock-output-names = "rk808-clkout1", "rk808-clkout2";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&pmic_int>;
+ rockchip,system-power-controller;
+ wakeup-source;
+ #clock-cells = <1>;
+
+ vcc1-supply = <&vcc3v3_sys>;
+ vcc2-supply = <&vcc3v3_sys>;
+ vcc3-supply = <&vcc3v3_sys>;
+ vcc4-supply = <&vcc3v3_sys>;
+ vcc5-supply = <&vcc3v3_sys>;
+ vcc6-supply = <&vcc3v3_sys>;
+ vcc7-supply = <&vcc3v3_sys>;
+ vcc8-supply = <&vcc3v3_sys>;
+ vcc9-supply = <&vcc3v3_sys>;
+
+ regulators {
+ vdd_logic: DCDC_REG1 {
+ regulator-name = "vdd_logic";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-init-microvolt = <900000>;
+ regulator-ramp-delay = <6001>;
+ regulator-initial-mode = <0x2>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdd_gpu: DCDC_REG2 {
+ regulator-name = "vdd_gpu";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-init-microvolt = <900000>;
+ regulator-ramp-delay = <6001>;
+ regulator-initial-mode = <0x2>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc_ddr: DCDC_REG3 {
+ regulator-name = "vcc_ddr";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-initial-mode = <0x2>;
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ };
+ };
+
+ vdd_npu: DCDC_REG4 {
+ regulator-name = "vdd_npu";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1350000>;
+ regulator-init-microvolt = <900000>;
+ regulator-ramp-delay = <6001>;
+ regulator-initial-mode = <0x2>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc_1v8: DCDC_REG5 {
+ regulator-name = "vcc_1v8";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdda0v9_image: LDO_REG1 {
+ regulator-name = "vdda0v9_image";
+ regulator-boot-on;
+ regulator-always-on;
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <900000>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdda_0v9: LDO_REG2 {
+ regulator-name = "vdda_0v9";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <900000>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vdda0v9_pmu: LDO_REG3 {
+ regulator-name = "vdda0v9_pmu";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <900000>;
+ regulator-max-microvolt = <900000>;
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <900000>;
+ };
+ };
+
+ vccio_acodec: LDO_REG4 {
+ regulator-name = "vccio_acodec";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vccio_sd: LDO_REG5 {
+ regulator-name = "vccio_sd";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc3v3_pmu: LDO_REG6 {
+ regulator-name = "vcc3v3_pmu";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <3300000>;
+ };
+ };
+
+ vcca_1v8: LDO_REG7 {
+ regulator-name = "vcca_1v8";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcca1v8_pmu: LDO_REG8 {
+ regulator-name = "vcca1v8_pmu";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+
+ regulator-state-mem {
+ regulator-on-in-suspend;
+ regulator-suspend-microvolt = <1800000>;
+ };
+ };
+
+ vcca1v8_image: LDO_REG9 {
+ regulator-name = "vcca1v8_image";
+ regulator-always-on;
+ regulator-boot-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc_3v3: SWITCH_REG1 {
+ regulator-name = "vcc_3v3";
+ regulator-always-on;
+ regulator-boot-on;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+
+ vcc3v3_sd: SWITCH_REG2 {
+ regulator-name = "vcc3v3_sd";
+ regulator-always-on;
+ regulator-boot-on;
+
+ regulator-state-mem {
+ regulator-off-in-suspend;
+ };
+ };
+ };
+ };
+};
+
+&i2s1_8ch {
+ rockchip,trcm-sync-tx-only;
+ status = "okay";
+};
+
+&gmac1 {
+ phy-mode = "rgmii";
+ clock_in_out = "output";
+ snps,reset-gpio = <&gpio2 RK_PB0 GPIO_ACTIVE_LOW>;
+ snps,reset-active-low;
+ /* Reset time is 100ms, 100ms */
+ snps,reset-delays-us = <0 75000 100000>;
+ assigned-clocks = <&cru SCLK_GMAC1_RX_TX>, <&cru SCLK_GMAC1>;
+ assigned-clock-parents = <&cru SCLK_GMAC1_RGMII_SPEED>, <&cru CLK_MAC1_2TOP>;
+ assigned-clock-rates = <0>, <125000000>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&gmac1m1_miim
+ &gmac1m1_tx_bus2_level3
+ &gmac1m1_rx_bus2
+ &gmac1m1_rgmii_clk_level2
+ &gmac1m1_rgmii_bus_level3>;
+ tx_delay = <0x1a>;
+ rx_delay = <0x0c>;
+ phy-handle = <&rgmii_phy1>;
+ status = "okay";
+};
+
+&mdio1 {
+ rgmii_phy1: phy@0 {
+ compatible = "ethernet-phy-ieee802.3-c22";
+ reg = <0x0>;
+ };
+};
+
+&pcie2x1 {
+ reset-gpios = <&gpio0 RK_PB6 GPIO_ACTIVE_HIGH>;
+ disable-gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
+ vpcie3v3-supply = <&vcc3v3_pcie>;
+ status = "okay";
+};
+
+&pinctrl {
+ leds {
+ sys_led_pin: sys-status-led-pin {
+ rockchip,pins = <0 RK_PC7 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+
+ usb {
+ vcc5v0_usb20_host_en: vcc5v0-usb20-host-en {
+ rockchip,pins = <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+
+ vcc5v0_usb30_host_en: vcc5v0-usb30-host-en {
+ rockchip,pins = <2 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+
+ pmic {
+ pmic_int: pmic_int {
+ rockchip,pins =
+ <0 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;
+ };
+ };
+};
+
+&pmu_io_domains {
+ pmuio2-supply = <&vcc3v3_pmu>;
+ vccio1-supply = <&vccio_acodec>;
+ vccio3-supply = <&vccio_sd>;
+ vccio4-supply = <&vcc_3v3>;
+ vccio5-supply = <&vcc_3v3>;
+ vccio6-supply = <&vcc_1v8>;
+ vccio7-supply = <&vcc_3v3>;
+ status = "okay";
+};
+
+&saradc {
+ vref-supply = <&vcca_1v8>;
+ status = "okay";
+};
+
+&tsadc {
+ rockchip,hw-tshut-mode = <1>;
+ rockchip,hw-tshut-polarity = <0>;
+ status = "okay";
+};
+
+&sdhci {
+ assigned-clocks = <&cru BCLK_EMMC>, <&cru TCLK_EMMC>, <&cru CCLK_EMMC>;
+ assigned-clock-rates = <200000000>, <24000000>, <200000000>;
+ bus-width = <8>;
+ max-frequency = <200000000>;
+ mmc-hs200-1_8v;
+ non-removable;
+ pinctrl-names = "default";
+ pinctrl-0 = <&emmc_bus8 &emmc_clk &emmc_cmd>;
+ supports-emmc;
+ status = "okay";
+};
+
+&sdmmc0 {
+ max-frequency = <150000000>;
+ supports-sd;
+ bus-width = <4>;
+ cap-mmc-highspeed;
+ cap-sd-highspeed;
+ disable-wp;
+ sd-uhs-sdr104;
+ vmmc-supply = <&vcc3v3_sd>;
+ vqmmc-supply = <&vccio_sd>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
+ status = "okay";
+};
+
+/* USB OTG/USB Host_1 USB 2.0 Comb */
+&usb2phy0 {
+ status = "okay";
+};
+
+&usb2phy0_host {
+ status = "okay";
+};
+
+&usb2phy0_otg {
+ status = "okay";
+};
+
+&usb_host0_ehci {
+ status = "okay";
+};
+
+&usb_host0_ohci {
+ status = "okay";
+};
+
+/* USB Host_2/USB Host_3 USB 2.0 Comb */
+&usb2phy1 {
+ status = "okay";
+};
+
+&usb2phy1_host {
+ status = "okay";
+};
+
+&usb2phy1_otg {
+ status = "okay";
+};
+
+&usb_host1_ehci {
+ status = "okay";
+};
+
+&usb_host1_ohci {
+ status = "okay";
+};
+
+/* USB3.0 Host */
+&usb_host1_xhci {
+ status = "okay";
+};
+
+&vop {
+ assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>;
+ assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>;
+ status = "okay";
+};
+
+&vop_mmu {
+ status = "okay";
+};
+
+&vp0 {
+ vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 {
+ reg = <ROCKCHIP_VOP2_EP_HDMI0>;
+ remote-endpoint = <&hdmi_in_vp0>;
+ };
+};
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1
2022-12-21 5:46 [PATCH v4 1/2] arm64: dts: rockchip: Add EmbedFire LubanCat 1 Yuteng Zhong
@ 2022-12-21 5:52 ` Yuteng Zhong
2022-12-21 8:16 ` Krzysztof Kozlowski
2022-12-21 8:15 ` [PATCH v4 1/2] arm64: dts: " Krzysztof Kozlowski
1 sibling, 1 reply; 10+ messages in thread
From: Yuteng Zhong @ 2022-12-21 5:52 UTC (permalink / raw)
To: Heiko Stuebner
Cc: Rob Herring, Peter Geis, Krzysztof Kozlowski, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip, Yuteng Zhong,
DHDAXCW
from: DHDAXCW <lasstp5011@gmail.com>
LubanCat 1 is a Rockchip RK3566 SBC based
is developed by EmbedFire Electronics Co., Ltd.
Mini Linux Card Type Cheap Computer Development Board
Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 88ff4422a8c1..84d39a3a8843 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -781,6 +781,11 @@ properties:
- const: rockchip,rk3568-bpi-r2pro
- const: rockchip,rk3568
+ - description: EmbedFire LubanCat 1
+ items:
+ - const: embedfire,lubancat-1
+ - const: rockchip,rk3566
+
additionalProperties: true
...
--
2.27.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v4 1/2] arm64: dts: rockchip: Add EmbedFire LubanCat 1
2022-12-21 5:46 [PATCH v4 1/2] arm64: dts: rockchip: Add EmbedFire LubanCat 1 Yuteng Zhong
2022-12-21 5:52 ` [PATCH v4 2/2] dt-bindings: arm: " Yuteng Zhong
@ 2022-12-21 8:15 ` Krzysztof Kozlowski
2022-12-21 9:44 ` ty
1 sibling, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-21 8:15 UTC (permalink / raw)
To: Yuteng Zhong, Heiko Stuebner
Cc: Rob Herring, Peter Geis, Krzysztof Kozlowski, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip, DHDAXCW
On 21/12/2022 06:46, Yuteng Zhong wrote:
> from: DHDAXCW <lasstp5011@gmail.com>
>
> LubanCat 1 is a Rockchip RK3566 SBC based
> is developed by EmbedFire Electronics Co., Ltd.
> Mini Linux Card Type Cheap Computer Development Board
>
> It has the following characteristics:
> - MicroSD card slot, onboard eMMC flash memory
> - 1GbE Realtek RTL8211F Ethernet Transceiver
> - 1 USB Type-C port (power and USB2.0 OTG)
> - 1 USB 3.0 Host port
> - 3 USB 2.0 Host ports
> - 1 HDMI
> - 1 infrared receiver
> - 1 MIPI DSI
> - 1 MIPI CSI
> - 1 x 4-section headphone jack
> - Mini PCIe socket (USB or PCIe)
> - 1 SIM Card slot
> - 1 SYS LED and 1 PWR LED
> - 40-pin GPIO expansion header
>
> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
> ---
>
> Changed in V2:
> - Remove RNG node
> Changed in V3:
> - Sent E-mail with a wrong attachment
> Changed in V4:
> - Modify all node names
>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3566-lubancat-1.dts | 598 ++++++++++++++++++
> 2 files changed, 599 insertions(+)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index 0a76a2ebb5f6..e52bda04d45a 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> new file mode 100644
> index 000000000000..443fcfabbd16
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> @@ -0,0 +1,598 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> +* Copyright (c) 2021 Rockchip Electronics Co., Ltd.
> +*/
> +
> +/dts-v1/;
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> +#include <dt-bindings/pinctrl/rockchip.h>
> +#include <dt-bindings/soc/rockchip,vop2.h>
> +#include "rk3566.dtsi"
> +
> +/ {
> + model = "EmbedFire LubanCat 1";
> + compatible = "embedfire,lubancat-1", "rockchip,rk3566";
> +
> + aliases {
> + ethernet0 = &gmac1;
> + mmc0 = &sdmmc0;
> + mmc1 = &sdhci;
> + };
> +
> + chosen: chosen {
> + stdout-path = "serial2:1500000n8";
> + };
> +
> + gmac1_clkin: external-gmac1-clock {
> + compatible = "fixed-clock";
> + clock-frequency = <125000000>;
> + clock-output-names = "gmac1_clkin";
> + #clock-cells = <0>;
> + };
> +
> + hdmi-con {
> + compatible = "hdmi-connector";
> + type = "a";
> +
> + port {
> + hdmi_con_in: endpoint {
> + remote-endpoint = <&hdmi_out_con>;
> + };
> + };
> + };
> +
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + sys_led: sys-led {
> + label = "sys_led";
> + linux,default-trigger = "heartbeat";
> + default-state = "on";
> + gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&sys_led_pin>;
> + };
> + };
> +
> + usb_5v: usb-5v-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "usb_5v";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + };
> +
> + vcc5v0_sys: vcc5v0-sys-regulator {
> + compatible = "regulator-fixed";
> + regulator-name = "vcc5v0_sys";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + vin-supply = <&usb_5v>;
> + };
> +
> + vcc3v3_sys: vcc3v3-sys {
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
> + compatible = "regulator-fixed";
> + regulator-name = "vcc3v3_sys";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + vin-supply = <&vcc5v0_sys>;
> + };
> +
> + vcc3v3_pcie: vcc3v3-pcie-regulator {
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1
2022-12-21 5:52 ` [PATCH v4 2/2] dt-bindings: arm: " Yuteng Zhong
@ 2022-12-21 8:16 ` Krzysztof Kozlowski
2022-12-21 10:46 ` ty
0 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-21 8:16 UTC (permalink / raw)
To: Yuteng Zhong, Heiko Stuebner
Cc: Rob Herring, Peter Geis, Krzysztof Kozlowski, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip, DHDAXCW
On 21/12/2022 06:52, Yuteng Zhong wrote:
> from: DHDAXCW <lasstp5011@gmail.com>
>
> LubanCat 1 is a Rockchip RK3566 SBC based
> is developed by EmbedFire Electronics Co., Ltd.
> Mini Linux Card Type Cheap Computer Development Board
This is a friendly reminder during the review process.
It seems my previous comments were not fully addressed. Maybe my
feedback got lost between the quotes, maybe you just forgot to apply it.
Please go back to the previous discussion and either implement all
requested changes or keep discussing them.
Thank you.
>
> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 88ff4422a8c1..84d39a3a8843 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -781,6 +781,11 @@ properties:
> - const: rockchip,rk3568-bpi-r2pro
> - const: rockchip,rk3568
>
> + - description: EmbedFire LubanCat 1
> + items:
> + - const: embedfire,lubancat-1
> + - const: rockchip,rk3566
Here as well.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 1/2] arm64: dts: rockchip: Add EmbedFire LubanCat 1
2022-12-21 8:15 ` [PATCH v4 1/2] arm64: dts: " Krzysztof Kozlowski
@ 2022-12-21 9:44 ` ty
0 siblings, 0 replies; 10+ messages in thread
From: ty @ 2022-12-21 9:44 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Rob Herring, Peter Geis, Krzysztof Kozlowski,
devicetree, linux-kernel, linux-arm-kernel, linux-rockchip,
DHDAXCW
Dear Kozlowski,
Before making a new PATCH v5 with the whole .dts file, here is a small
patch base on the current v4.
This node name was missed in this PATCH.
---
@@ -74,7 +74,7 @@
vin-supply = <&usb_5v>;
};
- vcc3v3_sys: vcc3v3-sys {
+ vcc3v3_sys: vcc3v3-sys-regulator {
compatible = "regulator-fixed";
regulator-name = "vcc3v3_sys";
regulator-always-on;
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 于2022年12月21日周三 16:15写道：
>
> On 21/12/2022 06:46, Yuteng Zhong wrote:
> > from: DHDAXCW <lasstp5011@gmail.com>
> >
> > LubanCat 1 is a Rockchip RK3566 SBC based
> > is developed by EmbedFire Electronics Co., Ltd.
> > Mini Linux Card Type Cheap Computer Development Board
> >
> > It has the following characteristics:
> > - MicroSD card slot, onboard eMMC flash memory
> > - 1GbE Realtek RTL8211F Ethernet Transceiver
> > - 1 USB Type-C port (power and USB2.0 OTG)
> > - 1 USB 3.0 Host port
> > - 3 USB 2.0 Host ports
> > - 1 HDMI
> > - 1 infrared receiver
> > - 1 MIPI DSI
> > - 1 MIPI CSI
> > - 1 x 4-section headphone jack
> > - Mini PCIe socket (USB or PCIe)
> > - 1 SIM Card slot
> > - 1 SYS LED and 1 PWR LED
> > - 40-pin GPIO expansion header
> >
> > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> > Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
> > ---
> >
> > Changed in V2:
> > - Remove RNG node
> > Changed in V3:
> > - Sent E-mail with a wrong attachment
> > Changed in V4:
> > - Modify all node names
> >
> > ---
> > arch/arm64/boot/dts/rockchip/Makefile | 1 +
> > .../boot/dts/rockchip/rk3566-lubancat-1.dts | 598 ++++++++++++++++++
> > 2 files changed, 599 insertions(+)
> > create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> >
> > diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> > index 0a76a2ebb5f6..e52bda04d45a 100644
> > --- a/arch/arm64/boot/dts/rockchip/Makefile
> > +++ b/arch/arm64/boot/dts/rockchip/Makefile
> > @@ -78,6 +78,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-blade.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-cm4.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb
> > +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
> > dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-odroid-m1.dtb
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> > new file mode 100644
> > index 000000000000..443fcfabbd16
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> > @@ -0,0 +1,598 @@
> > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> > +/*
> > +* Copyright (c) 2021 Rockchip Electronics Co., Ltd.
> > +*/
> > +
> > +/dts-v1/;
> > +#include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/leds/common.h>
> > +#include <dt-bindings/pinctrl/rockchip.h>
> > +#include <dt-bindings/soc/rockchip,vop2.h>
> > +#include "rk3566.dtsi"
> > +
> > +/ {
> > + model = "EmbedFire LubanCat 1";
> > + compatible = "embedfire,lubancat-1", "rockchip,rk3566";
> > +
> > + aliases {
> > + ethernet0 = &gmac1;
> > + mmc0 = &sdmmc0;
> > + mmc1 = &sdhci;
> > + };
> > +
> > + chosen: chosen {
> > + stdout-path = "serial2:1500000n8";
> > + };
> > +
> > + gmac1_clkin: external-gmac1-clock {
> > + compatible = "fixed-clock";
> > + clock-frequency = <125000000>;
> > + clock-output-names = "gmac1_clkin";
> > + #clock-cells = <0>;
> > + };
> > +
> > + hdmi-con {
> > + compatible = "hdmi-connector";
> > + type = "a";
> > +
> > + port {
> > + hdmi_con_in: endpoint {
> > + remote-endpoint = <&hdmi_out_con>;
> > + };
> > + };
> > + };
> > +
> > + gpio-leds {
> > + compatible = "gpio-leds";
> > +
> > + sys_led: sys-led {
> > + label = "sys_led";
> > + linux,default-trigger = "heartbeat";
> > + default-state = "on";
> > + gpios = <&gpio0 RK_PC5 GPIO_ACTIVE_LOW>;
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&sys_led_pin>;
> > + };
> > + };
> > +
> > + usb_5v: usb-5v-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "usb_5v";
> > + regulator-always-on;
> > + regulator-boot-on;
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + };
> > +
> > + vcc5v0_sys: vcc5v0-sys-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc5v0_sys";
> > + regulator-always-on;
> > + regulator-boot-on;
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + vin-supply = <&usb_5v>;
> > + };
> > +
> > + vcc3v3_sys: vcc3v3-sys {
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
>
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc3v3_sys";
> > + regulator-always-on;
> > + regulator-boot-on;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + vin-supply = <&vcc5v0_sys>;
> > + };
> > +
> > + vcc3v3_pcie: vcc3v3-pcie-regulator {
>
>
> Best regards,
> Krzysztof
>
--
Y. T. Zhong
Student of The University of Hong Kong, major in Computer Science.
E-mail: zonyitoo@gmail.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1
2022-12-21 8:16 ` Krzysztof Kozlowski
@ 2022-12-21 10:46 ` ty
2022-12-21 11:41 ` Krzysztof Kozlowski
2022-12-21 11:44 ` Heiko Stübner
0 siblings, 2 replies; 10+ messages in thread
From: ty @ 2022-12-21 10:46 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Heiko Stuebner, Rob Herring, Peter Geis, Krzysztof Kozlowski,
devicetree, linux-kernel, linux-arm-kernel, linux-rockchip,
DHDAXCW
Dear Kozlowski,
Sorry that we didn't fully get the idea in your previous comments.
>
> On 21/12/2022 06:52, Yuteng Zhong wrote:
> > from: DHDAXCW <lasstp5011@gmail.com>
> >
> > LubanCat 1 is a Rockchip RK3566 SBC based
> > is developed by EmbedFire Electronics Co., Ltd.
> > Mini Linux Card Type Cheap Computer Development Board
>
> This is a friendly reminder during the review process.
>
> It seems my previous comments were not fully addressed. Maybe my
> feedback got lost between the quotes, maybe you just forgot to apply it.
> Please go back to the previous discussion and either implement all
> requested changes or keep discussing them.
>
> Thank you.
Your pervious comment were:
> Please wrap commit message according to Linux coding style / submission
> process:
> https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
So I think there must be something wrong in the message but I didn't
notice. This message has a `from` line, and the body was wrapped at 75
columns. Please help me make it better.
> >
> > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> > Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
> > ---
> > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > index 88ff4422a8c1..84d39a3a8843 100644
> > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > @@ -781,6 +781,11 @@ properties:
> > - const: rockchip,rk3568-bpi-r2pro
> > - const: rockchip,rk3568
> >
> > + - description: EmbedFire LubanCat 1
> > + items:
> > + - const: embedfire,lubancat-1
> > + - const: rockchip,rk3566
>
> Here as well.
This change was addressing the previous comment in V2:
> This is separate patch. Does not look like properly ordered. Don't add
> stuff at the end of files/lists.
The previous PATCH v2 merged changes in 3 diffent files:
1. arch/arm64/boot/dts/rockchip/Makefile
2. arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
3. Documentation/devicetree/bindings/arm/rockchip.yaml
What we do in this PATCH v4 was separated the 3 into a separated patch.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1
2022-12-21 10:46 ` ty
@ 2022-12-21 11:41 ` Krzysztof Kozlowski
2022-12-21 11:44 ` Heiko Stübner
1 sibling, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-21 11:41 UTC (permalink / raw)
To: ty
Cc: Heiko Stuebner, Rob Herring, Peter Geis, Krzysztof Kozlowski,
devicetree, linux-kernel, linux-arm-kernel, linux-rockchip,
DHDAXCW
On 21/12/2022 11:46, ty wrote:
> Dear Kozlowski,
>
> Sorry that we didn't fully get the idea in your previous comments.
>
>>
>> On 21/12/2022 06:52, Yuteng Zhong wrote:
>>> from: DHDAXCW <lasstp5011@gmail.com>
>>>
>>> LubanCat 1 is a Rockchip RK3566 SBC based
>>> is developed by EmbedFire Electronics Co., Ltd.
>>> Mini Linux Card Type Cheap Computer Development Board
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my
>> feedback got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all
>> requested changes or keep discussing them.
>>
>> Thank you.
>
> Your pervious comment were:
>
>> Please wrap commit message according to Linux coding style / submission
>> process:
>> https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
>
> So I think there must be something wrong in the message but I didn't
> notice. This message has a `from` line, and the body was wrapped at 75
> columns. Please help me make it better.
You do not wrap at 75, but at some other place. Just put it to editor
and check where is wrapping (count characters).
>
>
>
>>>
>>> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
>>> Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
>>> ---
>>> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> index 88ff4422a8c1..84d39a3a8843 100644
>>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>>> @@ -781,6 +781,11 @@ properties:
>>> - const: rockchip,rk3568-bpi-r2pro
>>> - const: rockchip,rk3568
>>>
>>> + - description: EmbedFire LubanCat 1
>>> + items:
>>> + - const: embedfire,lubancat-1
>>> + - const: rockchip,rk3566
>>
>> Here as well.
>
> This change was addressing the previous comment in V2:
>
>> This is separate patch. Does not look like properly ordered. Don't add
>> stuff at the end of files/lists.
>
> The previous PATCH v2 merged changes in 3 diffent files:
>
> 1. arch/arm64/boot/dts/rockchip/Makefile
> 2. arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts
> 3. Documentation/devicetree/bindings/arm/rockchip.yaml
>
> What we do in this PATCH v4 was separated the 3 into a separated patch.
So how did you solve the comment "Does not look like properly ordered.
Don't add stuff at the end of files/lists."? What did you change to
solve it?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1
2022-12-21 10:46 ` ty
2022-12-21 11:41 ` Krzysztof Kozlowski
@ 2022-12-21 11:44 ` Heiko Stübner
2022-12-21 12:12 ` ty
1 sibling, 1 reply; 10+ messages in thread
From: Heiko Stübner @ 2022-12-21 11:44 UTC (permalink / raw)
To: Krzysztof Kozlowski, ty
Cc: Rob Herring, Peter Geis, Krzysztof Kozlowski, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip, DHDAXCW
Am Mittwoch, 21. Dezember 2022, 11:46:36 CET schrieb ty:
> Dear Kozlowski,
>
> Sorry that we didn't fully get the idea in your previous comments.
>
> >
> > On 21/12/2022 06:52, Yuteng Zhong wrote:
> > > from: DHDAXCW <lasstp5011@gmail.com>
> > >
> > > LubanCat 1 is a Rockchip RK3566 SBC based
> > > is developed by EmbedFire Electronics Co., Ltd.
> > > Mini Linux Card Type Cheap Computer Development Board
> >
> > This is a friendly reminder during the review process.
> >
> > It seems my previous comments were not fully addressed. Maybe my
> > feedback got lost between the quotes, maybe you just forgot to apply it.
> > Please go back to the previous discussion and either implement all
> > requested changes or keep discussing them.
> >
> > Thank you.
>
> Your pervious comment were:
>
> > Please wrap commit message according to Linux coding style / submission
> > process:
> > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
>
> So I think there must be something wrong in the message but I didn't
> notice. This message has a `from` line, and the body was wrapped at 75
> columns. Please help me make it better.
>
>
>
> > >
> > > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> > > Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
> > > ---
> > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > index 88ff4422a8c1..84d39a3a8843 100644
> > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > @@ -781,6 +781,11 @@ properties:
> > > - const: rockchip,rk3568-bpi-r2pro
> > > - const: rockchip,rk3568
> > >
> > > + - description: EmbedFire LubanCat 1
> > > + items:
> > > + - const: embedfire,lubancat-1
> > > + - const: rockchip,rk3566
> >
> > Here as well.
>
> This change was addressing the previous comment in V2:
>
> > This is separate patch. Does not look like properly ordered. Don't add
> > stuff at the end of files/lists.
for context sorting order in that file is alphabetical by description
Heiko
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1
2022-12-21 11:44 ` Heiko Stübner
@ 2022-12-21 12:12 ` ty
2022-12-21 12:15 ` Krzysztof Kozlowski
0 siblings, 1 reply; 10+ messages in thread
From: ty @ 2022-12-21 12:12 UTC (permalink / raw)
To: Heiko Stübner
Cc: Krzysztof Kozlowski, Rob Herring, Peter Geis, Krzysztof Kozlowski,
devicetree, linux-kernel, linux-arm-kernel, linux-rockchip,
DHDAXCW
Hi, Kozlowski and Stübner,
Thank you very much for pointing me in the right direction.
> So how did you solve the comment "Does not look like properly ordered.
> Don't add stuff at the end of files/lists."? What did you change to
> solve it?
> for context sorting order in that file is alphabetical by description
I finally got it. It should be put right after the "Elgin RV1108 R1".
> You do not wrap at 75, but at some other place. Just put it to editor
> and check where is wrapping (count characters).
The original message was:
> from: DHDAXCW <lasstp5011@gmail.com>
>
> LubanCat 1 is a Rockchip RK3566 SBC based
> is developed by EmbedFire Electronics Co., Ltd.
> Mini Linux Card Type Cheap Computer Development Board
>
> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
The longest line is "Mini Linux Card Type Cheap Computer Development
Board", which has 53 characters. Or ... I should use the whole line as
much as possible? Then I see why I was doing wrong. It will be fixed
in the PATCH v5.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1
2022-12-21 12:12 ` ty
@ 2022-12-21 12:15 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-21 12:15 UTC (permalink / raw)
To: ty, Heiko Stübner
Cc: Rob Herring, Peter Geis, Krzysztof Kozlowski, devicetree,
linux-kernel, linux-arm-kernel, linux-rockchip, DHDAXCW
On 21/12/2022 13:12, ty wrote:
> Hi, Kozlowski and Stübner,
>
> Thank you very much for pointing me in the right direction.
>
>> So how did you solve the comment "Does not look like properly ordered.
>> Don't add stuff at the end of files/lists."? What did you change to
>> solve it?
>
>> for context sorting order in that file is alphabetical by description
>
> I finally got it. It should be put right after the "Elgin RV1108 R1".
>
>> You do not wrap at 75, but at some other place. Just put it to editor
>> and check where is wrapping (count characters).
>
> The original message was:
>
>> from: DHDAXCW <lasstp5011@gmail.com>
>>
>> LubanCat 1 is a Rockchip RK3566 SBC based
>> is developed by EmbedFire Electronics Co., Ltd.
>> Mini Linux Card Type Cheap Computer Development Board
>>
>> Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
>> Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
>
> The longest line is "Mini Linux Card Type Cheap Computer Development
> Board", which has 53 characters. Or ... I should use the whole line as
> much as possible? Then I see why I was doing wrong. It will be fixed
> in the PATCH v5.
Yes,
because
such
commit
msg
is
also
within
75
characters
but
it
is
not
correct,
right?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-12-21 12:15 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-21 5:46 [PATCH v4 1/2] arm64: dts: rockchip: Add EmbedFire LubanCat 1 Yuteng Zhong
2022-12-21 5:52 ` [PATCH v4 2/2] dt-bindings: arm: " Yuteng Zhong
2022-12-21 8:16 ` Krzysztof Kozlowski
2022-12-21 10:46 ` ty
2022-12-21 11:41 ` Krzysztof Kozlowski
2022-12-21 11:44 ` Heiko Stübner
2022-12-21 12:12 ` ty
2022-12-21 12:15 ` Krzysztof Kozlowski
2022-12-21 8:15 ` [PATCH v4 1/2] arm64: dts: " Krzysztof Kozlowski
2022-12-21 9:44 ` ty
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).