From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Jagadeesh Kona <quic_jkona@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] clk: qcom: videocc: Add support to attach multiple power domains
Date: Thu, 20 Feb 2025 10:21:47 +0000 [thread overview]
Message-ID: <5a86cb82-e313-4f50-a6ff-17181a2dd274@linaro.org> (raw)
In-Reply-To: <3da96df2-1127-49bf-8114-282cc488c194@quicinc.com>
On 20/02/2025 07:15, Jagadeesh Kona wrote:
>> Yes, its logically the same just done in core code.
>>
> Yes, this code attaches domains before configuring the PLLs, but it attaches PDs after get_sync()
> is called on device. As I mentioned in other patch earlier, if we attach PDS after get_sync() is
> already called on device, then power domains are not getting enabled during the probe, leading to
> the same improper PLL configuration issue. But the current patch series posted will fix this issue
That's not what I see.
The PLLs start and the GDSCs which depend also start.
Perhaps you could give the code a try and comment ?
---
bod
next prev parent reply other threads:[~2025-02-20 10:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 14:26 [PATCH 0/5] clk: qcom: Add support to attach multiple power domains in cc probe Jagadeesh Kona
2025-02-18 14:26 ` [PATCH 1/5] dt-bindings: clock: qcom,sm8450-videocc: Add MXC power domain Jagadeesh Kona
2025-02-18 15:49 ` Bryan O'Donoghue
2025-02-21 20:54 ` Rob Herring (Arm)
2025-02-18 14:26 ` [PATCH 2/5] clk: qcom: common: Add support to attach multiple power domains Jagadeesh Kona
2025-02-18 14:26 ` [PATCH 3/5] clk: qcom: common: Attach clock power domains conditionally Jagadeesh Kona
2025-02-18 17:18 ` Dmitry Baryshkov
2025-02-19 11:36 ` Jagadeesh Kona
2025-02-19 11:57 ` Dmitry Baryshkov
2025-02-20 7:13 ` Jagadeesh Kona
2025-02-20 10:48 ` Dmitry Baryshkov
2025-02-21 11:42 ` Jagadeesh Kona
2025-02-21 13:35 ` Dmitry Baryshkov
2025-02-18 14:26 ` [PATCH 4/5] clk: qcom: videocc: Add support to attach multiple power domains Jagadeesh Kona
2025-02-18 15:46 ` Bryan O'Donoghue
2025-02-18 16:44 ` Bryan O'Donoghue
2025-02-18 17:19 ` Dmitry Baryshkov
2025-02-19 1:21 ` Bryan O'Donoghue
2025-02-19 11:41 ` Jagadeesh Kona
2025-02-19 11:59 ` Dmitry Baryshkov
2025-02-19 12:07 ` Bryan O'Donoghue
2025-02-20 7:15 ` Jagadeesh Kona
2025-02-20 10:21 ` Bryan O'Donoghue [this message]
2025-02-20 22:31 ` Bryan O'Donoghue
2025-02-20 22:34 ` Bryan O'Donoghue
2025-02-21 0:10 ` Dmitry Baryshkov
2025-02-21 9:42 ` Bryan O'Donoghue
2025-02-21 11:43 ` Jagadeesh Kona
2025-02-21 12:32 ` Bryan O'Donoghue
2025-02-24 6:37 ` Jagadeesh Kona
2025-02-19 11:38 ` Jagadeesh Kona
2025-02-19 12:02 ` Dmitry Baryshkov
2025-02-20 7:13 ` Jagadeesh Kona
2025-02-21 19:19 ` Konrad Dybcio
2025-02-24 6:37 ` Jagadeesh Kona
2025-02-18 14:26 ` [PATCH 5/5] arm64: dts: qcom: Add MXC power domain to videocc nodes Jagadeesh Kona
2025-02-18 15:41 ` Bryan O'Donoghue
2025-02-18 17:32 ` Dmitry Baryshkov
2025-02-20 7:08 ` Jagadeesh Kona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a86cb82-e313-4f50-a6ff-17181a2dd274@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox