From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2799EC433FE for ; Tue, 3 May 2022 09:30:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233399AbiECJdc (ORCPT ); Tue, 3 May 2022 05:33:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233272AbiECJdb (ORCPT ); Tue, 3 May 2022 05:33:31 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5889F36318 for ; Tue, 3 May 2022 02:29:56 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id p18so19186978edr.7 for ; Tue, 03 May 2022 02:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=zB5e/Eye7NKTiR0iDf6A/QHPDIG8VOEpDlGbZQKTb30=; b=BR6BitziOi0WXcjIJLa6fbzR99D1RO1QuZQlrMCVfu5IezrVdh94Je492bhD3tuePW Vblf0IULaKsW3hkFdtR/JnR7P830V9R0yRz7ZsYDIngTVZA0O/Re1G+Q9y7ET6yAgTPX tRpx+VIlUGwMeQHSYoyDWAm1BwalfVQyq3/DGy1iy+qaFlcLfCbGxL81eKnPmG/8w7Ww n+lrtGmFl+HBIYtq5rWpKLfTU++lasaMTHN0TscdXYkcLRRcfbtXZSmhXwtOXKFR4/Rl MbRT/oQFm7HNGHtoFhLEKxL95g0ZoNIAxQ7e8M2SdHtOBJvZKT/01Zcej5S4gQ6VnPN7 REUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=zB5e/Eye7NKTiR0iDf6A/QHPDIG8VOEpDlGbZQKTb30=; b=gy2ohuhKYUaEptz7DD9J8ukhnadECKtHbd9QDW3HIneXiK1sYFKKLWS8RRGMZs7wjt 61/ztlgRe4Ay1d7P98p/OE+avh9zCQKRwtgC+jChdX9NYVe6NzH/+QEk7RWkSrcsA3ON TaC0KrFPWpsBMqZJDRHkv6hdgjjCG0Qc3287MnV6jpjtKcYtIuMPSSrJWQxwyx8QQpG/ vszYj9Pqwur7jGT6woNZMcqEbpkpRKzoRU1oAgGHx4mJCUBWAs2EI6glajCIalxrCSFl 4s45kptU5lqChfmUCmoWh/r1LBqKCZz4A7btMBpKK6qWV2xcS1UVcls5HAbFxm9rkjiB 3Akw== X-Gm-Message-State: AOAM531iyb72umrVQF6NOMywbHsgHjhEC1W9LZ5QvSecrLRejup7n/Oy pP7IYY2nKghTGwWjNkUy9mmW/g== X-Google-Smtp-Source: ABdhPJw0CvtF1J8tlcNgNaOLoUi82bOqMVPxdlnIrx9IBPryH5dVXVAGmSZQkuKIy+RfCoXWk/K6Rw== X-Received: by 2002:a50:9f06:0:b0:425:c1ba:5037 with SMTP id b6-20020a509f06000000b00425c1ba5037mr17363890edf.285.1651570194908; Tue, 03 May 2022 02:29:54 -0700 (PDT) Received: from [192.168.0.201] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id og13-20020a1709071dcd00b006f3ef214e3fsm4398405ejc.165.2022.05.03.02.29.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 May 2022 02:29:54 -0700 (PDT) Message-ID: <5a89e9bf-1004-500a-75e1-995732629937@linaro.org> Date: Tue, 3 May 2022 11:29:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032 Content-Language: en-US To: Geert Uytterhoeven , Rob Herring Cc: Krzysztof Kozlowski , Herve Codina , Marek Vasut , Yoshihiro Shimoda , Bjorn Helgaas , Krzysztof Kozlowski , Magnus Damm , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , linux-pci , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Sergey Shtylyov , Thomas Petazzoni , Clement Leger , Miquel Raynal References: <20220429134143.628428-1-herve.codina@bootlin.com> <20220429134143.628428-4-herve.codina@bootlin.com> <29ba3db6-e5c7-06d3-29d9-918ee5b34555@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/05/2022 08:51, Geert Uytterhoeven wrote: >>>> This should not be a reason why a property is or is not required. Either >>>> this is required for device operation or not. If it is required, should >>>> be in the bindings. Otherwise what are you going to do in the future? >>>> Add a required property breaking the ABI? >>> >>> The problem is that there are no bindings for the reset controller >>> (actually the reset controller feature of the system-controller) yet. >>> Yeah, we can just add #reset-cells = <1> to the system-controller >>> device node, but we cannot add the actual resets properties to the >>> consumers, until the actual cell values are defined. >> >> Sounds like you should implement providers first. Or just live with the >> warning as a reminder to implement the reset provider? > > I'd go for the latter. The upstream r9a06g032.dtsi is still under active > development. Until very recently, the only device supported was the > serial console. For clocks we use in such cases fixed-clock placeholders or empty phandles. Maybe something like that would work here as well? Best regards, Krzysztof