From: "André Draszik" <andre.draszik@linaro.org>
To: Tudor Ambarus <tudor.ambarus@linaro.org>,
peter.griffin@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, conor+dt@kernel.org, andi.shyti@kernel.org,
alim.akhtar@samsung.com, gregkh@linuxfoundation.org,
jirislaby@kernel.org, s.nawrocki@samsung.com,
tomasz.figa@gmail.com, cw00.choi@samsung.com, arnd@arndb.de,
semen.protsenko@linaro.org
Cc: saravanak@google.com, willmcvicker@google.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org,
kernel-team@android.com
Subject: Re: [PATCH v2 10/12] arm64: dts: exynos: gs101: update USI UART to use peric0 clocks
Date: Thu, 28 Dec 2023 14:22:22 +0000 [thread overview]
Message-ID: <5a961a6992d7661e6c7589496438cad7b68d4f5a.camel@linaro.org> (raw)
In-Reply-To: <20231228125805.661725-11-tudor.ambarus@linaro.org>
Hi Tudor,
On Thu, 2023-12-28 at 12:58 +0000, Tudor Ambarus wrote:
>
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> [...]
> @@ -380,7 +373,8 @@ serial_0: serial@10a00000 {
> reg = <0x10a00000 0xc0>;
> interrupts = <GIC_SPI 634
> IRQ_TYPE_LEVEL_HIGH 0>;
> - clocks = <&dummy_clk 0>, <&dummy_clk 0>;
> + clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI0_UART_CLK>,
> + <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP1_IPCLK_0>;
I suspect these two should be the other way around, given the clock-names below?
> clock-names = "uart", "clk_uart_baud0";
> samsung,uart-fifosize = <256>;
> status = "disabled";
Cheers,
A.
next prev parent reply other threads:[~2023-12-28 14:22 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 12:57 [PATCH v2 00/12] GS101 Oriole: CMU_PERIC0 support and USI updates Tudor Ambarus
2023-12-28 12:57 ` [PATCH v2 01/12] dt-bindings: clock: google,gs101-clock: add PERIC0 clock management unit Tudor Ambarus
2024-01-08 14:18 ` Peter Griffin
2024-01-09 4:08 ` Rob Herring
2024-01-09 4:03 ` Rob Herring
2024-01-09 11:09 ` Krzysztof Kozlowski
2024-01-09 11:58 ` Tudor Ambarus
2024-01-09 15:01 ` Krzysztof Kozlowski
2024-01-09 16:12 ` Tudor Ambarus
2024-01-09 18:38 ` Krzysztof Kozlowski
2024-01-10 7:25 ` Tudor Ambarus
2023-12-28 12:57 ` [PATCH v2 02/12] dt-bindings: i2c: exynos5: add google,gs101-hsi2c compatible Tudor Ambarus
2024-01-08 14:20 ` Peter Griffin
2023-12-28 12:57 ` [PATCH v2 03/12] dt-bindings: serial: samsung: do not allow reg-io-width for gs101 Tudor Ambarus
2024-01-08 14:25 ` Peter Griffin
2023-12-28 12:57 ` [PATCH v2 04/12] tty: serial: samsung: prepare for different IO types Tudor Ambarus
2024-01-04 15:32 ` Greg KH
2024-01-04 15:41 ` Tudor Ambarus
2024-01-04 15:56 ` Greg KH
2024-01-05 10:22 ` Tudor Ambarus
2023-12-28 12:57 ` [PATCH v2 05/12] tty: serial: samsung: set UPIO_MEM32 iotype for gs101 Tudor Ambarus
2024-01-08 14:29 ` Peter Griffin
2023-12-28 12:57 ` [PATCH v2 06/12] tty: serial: samsung: add gs101 earlycon support Tudor Ambarus
2024-01-08 14:34 ` Peter Griffin
2023-12-28 12:58 ` [PATCH v2 07/12] clk: samsung: gs101: add support for cmu_peric0 Tudor Ambarus
2024-01-08 14:52 ` Peter Griffin
2023-12-28 12:58 ` [PATCH v2 08/12] arm64: dts: exynos: gs101: remove reg-io-width from serial Tudor Ambarus
2024-01-08 15:30 ` Peter Griffin
2023-12-28 12:58 ` [PATCH v2 09/12] arm64: dts: exynos: gs101: enable cmu-peric0 clock controller Tudor Ambarus
2024-01-08 15:36 ` Peter Griffin
2023-12-28 12:58 ` [PATCH v2 10/12] arm64: dts: exynos: gs101: update USI UART to use peric0 clocks Tudor Ambarus
2023-12-28 14:22 ` André Draszik [this message]
2023-12-29 8:26 ` Tudor Ambarus
2023-12-28 12:58 ` [PATCH v2 11/12] arm64: dts: exynos: gs101: define USI8 with I2C configuration Tudor Ambarus
2023-12-28 14:04 ` André Draszik
2023-12-29 8:04 ` Tudor Ambarus
2023-12-29 14:21 ` Tudor Ambarus
2023-12-28 12:58 ` [PATCH v2 12/12] arm64: dts: exynos: gs101: enable eeprom on gs101-oriole Tudor Ambarus
2024-01-08 16:15 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a961a6992d7661e6c7589496438cad7b68d4f5a.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel-team@android.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=tomasz.figa@gmail.com \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).