From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBDC949B21D for ; Fri, 11 Sep 2026 15:48:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789141683; cv=none; b=Ti7icYt551owNZUa+CDXS4lT0EYeLHMtDtMBJoi5m7mPET3zYHX/SiyQFIUd4ICnkwtSeSQ2jOqGY2upMu4VGgydCMSS1wqKGm1ts/lSjQnaqxQUCTGl4r+rGMbsXZnjNH7s5/PSY0MSiOuOzUGB5Cx4ze6cY9Kp388ao6gpqeI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789141683; c=relaxed/simple; bh=Gf1Q0sTU/UBy5u52sv5kJvv2O4ZJCxnZRcFqED9rhiY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JQZxXwxJp7+kX5zU3jVheXozytYHXH67VgdD+MZzdKYJbLX+SajS4g06rybFWBNl1NoZ6pi7G6c07NdNST31oQDK1d+qT5LBOtP7qEgUkPDjKEwBOSwoC8m9gdYf1jayk9+JaytbYheTKsCz/CL3GNjKODD9HGqTAd4CCIu8P7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NCpPo+MJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cBIf8h8d; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NCpPo+MJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cBIf8h8d" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68BEmAim222576 for ; Fri, 11 Sep 2026 15:48:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UfwvCJZ18lp93+WPqAxfERzMxNsd00Xm06mrFwnyhZs=; b=NCpPo+MJDgFf29jc jKcs3c7NPOXvzixt1cRi/VTasJ3xtoZZbYy/22fn4N0GiRKcaW4/kTtajBvta1fj bzGVpSwg+dCjMrhUn19SM14/L83MLfmuDpmVJfw6MkLo8drwuJhVNXJKWhfN69b+ D9b+AC2fUKo3J6J0mcgSfZL+YUvCoU3gC5WvYzJ0px7mTqh2mm80dxAxLWCFuTte +diXadbQUlcpQT3bxwfD/8+eEkbtFzABNB9Cw8b20Uinr+6S7arO+KVENv8659GD wRaU8ubXpBt9cFkrKoFKZ4VbhxPW06t254skdkxJy9FEkGUIQ6y20sbN83qFAM18 ol9atg== Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gmbdrahjk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 11 Sep 2026 15:48:00 +0000 (GMT) Received: by mail-vk1-f200.google.com with SMTP id 71dfb90a1353d-5c7d6767d06so37573e0c.2 for ; Fri, 11 Sep 2026 08:48:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1789141680; x=1789746480; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UfwvCJZ18lp93+WPqAxfERzMxNsd00Xm06mrFwnyhZs=; b=cBIf8h8dFTycAWsYO3LpCfAChfRgFAR8KoBqSYc5bDInilr48ND/AHtHziQCeihboU czGHIW3qT9spUfd70c5p4veNDDjqw8Hq/Zr9IA61tcUMGE6VPkS82IfkBRlQ2WC9zhf2 scdty1mFsNouD80HNmncSG7S5HngMKpXc0/Q15TMD80QqHhoQYob6VYEEpsdhIrmPWmO Xm8iLK0XxZVPS5xJnXmB7SdRjm0NClG147X25MjxA7NLEcL4lfTU/hEIsMOWfgTv/9/u K6+DUo8o12eR53rewtErUGloP4LQdo9FpHTdEXxwBr9uOZ+wAs1KiZzY8oecxUxKqYk4 a5DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789141680; x=1789746480; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UfwvCJZ18lp93+WPqAxfERzMxNsd00Xm06mrFwnyhZs=; b=a8ru/oDXAt0s5Zbt3GyR14tYEHOe4oPkEw6nYnL6leNosSnkknKfpzdKKTeDS6H22U ki7u2r2+1hy//mYiLcf3LdN469tsbkchyLTErMB5GgNJPmkKqnicAwC9kQ9Wn8hfusti NpkQGjUYj2IcoFJKXJTDxrppHylg5k6iWV7MLbOBadElT5M3ssGTq09gXB1oFchr0jUI XeDjEWT9ahEqBJdQMbXNveuGJ5/BMOAI0IdZDMd8u0Z8+vZheI5CpQih03PPNlEfivG7 gqmCNeAj5/tT8fy0I8mQ/xMwxIVPJtFAgQxE5pTPiPLu6Fi3WiSqGjmqP4zbHlQjDq7S NuEA== X-Forwarded-Encrypted: i=1; AKwUvBwIylqoY6kjpQMwnQMJToBhKmfanf8lZlspXd29W0W3RC9/z1CX87wIaHphWfRbuQdKsBsImY6MO02M@vger.kernel.org X-Gm-Message-State: AFuF++lzmhLsO/KvMk1/TFsLPBpSdQROhWT/oY0Af5tbtGD0Sq99zkVu AUbP5bxTN6ZW17NkppqhH9vuoeyt7NIU6YtcGXEscZplSLxYZS8C2IG3Aq5hxG0H1g+d0Nzz0mJ xq6upKPqhDbV9lTK6p9MgXdMw98l+l/yITtNY/1Q260CIVLZuCX+u1YffOnte6VHd X-Gm-Gg: AYBFou3FivIiLGXComm/hLuNscHlkla/GI7brlCfJqy4DClh77mCrjKU/eg1xPKYNZM z4yHp1+bUzBXPhmG2GOg2Hw9uP7N+PD/ktLlR5UVP9KpLbChYm/9YAzmrGn4sYchKw/IZSAzQlO tAKgYbrnGpRx6lisen6w8tlhU0Iq+bBxLikH5YI4a+xhUqB1LeZMw6oTzYmOkFiMCLw/rt4VelR 0/PHAR4WEp5Gi1p0rFaQIEIyTDh66PmesTPcBnxE/S3Iv8QQoIZ2sBADTFGCXpM0824IDp0udgK gaczahonEk6VAj84dSUqbbEF8NOxf69oHnkiBbFXiwH8PyUUEuk6AyBARsECtOOhkdgaeSxDlxw JoTKfLUBZGd4r7fvbr/Sgdw== X-Received: by 2002:a05:6122:4a1b:10b0:5c3:a1f5:7569 with SMTP id 71dfb90a1353d-5c8460814acmr1634000e0c.1.1789141680161; Fri, 11 Sep 2026 08:48:00 -0700 (PDT) X-Received: by 2002:a05:6122:4a1b:10b0:5c3:a1f5:7569 with SMTP id 71dfb90a1353d-5c8460814acmr1633976e0c.1.1789141679590; Fri, 11 Sep 2026 08:47:59 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b8a047fd69sm716054e87.83.2026.09.11.08.47.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2026 08:47:58 -0700 (PDT) Message-ID: <5ab7084b-1bbf-4e1d-a8b6-fa29dd9ba5ea@oss.qualcomm.com> Date: Fri, 11 Sep 2026 17:47:55 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/7] drm/msm/hdmi_phy: Cleanup after msm_hdmi_phy_resource_enable() failure To: Krzysztof Kozlowski , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Archit Taneja , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable@vger.kernel.org References: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-0-87bdb9f1987f@oss.qualcomm.com> <20260911-drm-msm-hdmi-fixes-before-eliza-v4-1-87bdb9f1987f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260911-drm-msm-hdmi-fixes-before-eliza-v4-1-87bdb9f1987f@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: zi5vi14vCtNdQixFZveTHCcRRLbakKQf X-Authority-Analysis: v=2.4 cv=PLmaavqC c=1 sm=1 tr=0 ts=6aa422b0 cx=c_pps a=wuOIiItHwq1biOnFUQQHKA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=5N7f0bWkOQp0pCbeU4sA:9 a=QEXdDO2ut3YA:10 a=XD7yVLdPMpWraOa8Un9W:22 X-Proofpoint-ORIG-GUID: zi5vi14vCtNdQixFZveTHCcRRLbakKQf X-Proofpoint-Spam-Info: AW1haW4tMjYwOTExMDIyMCBTYWx0ZWRfX/Fsb4SFAuX/7 Y7ksTB5cTGn6KSifTY1cRAYW9aw79Fz7g6WroA7uMDg87vOujyZUcdaRxs1n4ja+rK0PKQaBcMn Gqc86rz19raoa5NH8lvOpEvyaRXIsz4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTExMDIyMCBTYWx0ZWRfX1A2BAB6tbmaz PNSJudDCs+ZGaQ5qiFR18+jnGWvKfNgQOevO4Pel09x0852Ic9TZPaj/Mxrv7WUPdsZP8q5fDMA jCTnoR9dcc7XA3NVrm7Lf0IHBPaUilET9UIoFu2KfRZ1ZhQc5Mh/zsgts8b1i9zz2bOTJ6F/vh3 JrK8UMd9bOSWDcjoteAR4FFVuGJs8MOyODN0oLqvyikq/6Y8EHalm2FwsxStJzMb1WK6XfrRuxY Q4zqU3ZvLLCgNjrgvA4WRvOo1pq6AE5Ayi81m/ylsgqiDrNn8Y9CEDelZDKHxtD98I5PhdW1qWZ tieVBJ2abq1yyOjcdK2SnFGQMFd3RzJ3upvFmubl+CpoVS4THBcFmua8ORvJ3zERrETik3APMdC MUO+U317F0d2w3eIsY1RQiJ9yvIwsptIkwoUb4+j/Bzd+Uu2kBHvy3x/HFUS6xhmNTd13szpZfk eJ0t8JY3n+g4a393GEw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-11_05,2026-09-11_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 suspectscore=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609110220 On 9/11/26 12:29 PM, Krzysztof Kozlowski wrote: > If msm_hdmi_phy_resource_enable() fails, e.g. when enabling regulators, > it should reverse the state of things already changed. > msm_hdmi_phy_resource_enable() is used also in probe path, thus such > failure, which could be simple deferred probe, would leave these > resources permanently enabled for the rest of the runtime. > > Cc: > Fixes: 15b4a4523859 ("drm/msm/hdmi: Create a separate HDMI PHY driver") > Signed-off-by: Krzysztof Kozlowski > --- [...] > +err_clk_unprepare: > + for (; i > 0; i--) > + clk_disable_unprepare(phy->clks[i - 1]); > + regulator_bulk_disable(cfg->num_regs, phy->regs); > + > +err_pm_put: > + pm_runtime_put_sync(dev); This can apparently fail too.. one more argument for PM_RUNTIME_ACQUIRE_xxx Konrad