[PATCH] ARM: dts: bcm2711: Don't mark timer regs unconfigured

[PATCH] ARM: dts: bcm2711: Don't mark timer regs unconfigured

[Stefan Wahren]

From: Phil Elwell <phil@raspberrypi.com>

During upstream process of Raspberry Pi 4 back in 2019 the ARMv7 stubs
didn't configured the ARM architectural timer. This firmware issue has
been fixed in 2020, which gave users enough time to update their system.

So drop this property to allow the use of the vDSO version of
clock_gettime.

Link: https://github.com/raspberrypi/tools/pull/113
Fixes: 7dbe8c62ceeb ("ARM: dts: Add minimal Raspberry Pi 4 support")
Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
---
 arch/arm/boot/dts/broadcom/bcm2711.dtsi | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/broadcom/bcm2711.dtsi b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
index e4e42af21ef3..7cf93fdc676c 100644
--- a/arch/arm/boot/dts/broadcom/bcm2711.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
@@ -451,8 +451,6 @@ IRQ_TYPE_LEVEL_LOW)>,
 					  IRQ_TYPE_LEVEL_LOW)>,
 			     <GIC_PPI 10 (GIC_CPU_MASK_SIMPLE(4) |
 					  IRQ_TYPE_LEVEL_LOW)>;
-		/* This only applies to the ARMv7 stub */
-		arm,cpu-registers-not-fw-configured;
 	};

 	cpus: cpus {
--
2.34.1

Re: [PATCH] ARM: dts: bcm2711: Don't mark timer regs unconfigured

[Krzysztof Kozlowski]

On 22/02/2025 10:41, Stefan Wahren wrote:
> From: Phil Elwell <phil@raspberrypi.com>
> 
> During upstream process of Raspberry Pi 4 back in 2019 the ARMv7 stubs
> didn't configured the ARM architectural timer. This firmware issue has
> been fixed in 2020, which gave users enough time to update their system.
> 
> So drop this property to allow the use of the vDSO version of
> clock_gettime.
> 
> Link: https://github.com/raspberrypi/tools/pull/113
> Fixes: 7dbe8c62ceeb ("ARM: dts: Add minimal Raspberry Pi 4 support")
> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH] ARM: dts: bcm2711: Don't mark timer regs unconfigured

[Phil Elwell]

On Sat, 22 Feb 2025 at 10:44, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 22/02/2025 10:41, Stefan Wahren wrote:
> > From: Phil Elwell <phil@raspberrypi.com>
> >
> > During upstream process of Raspberry Pi 4 back in 2019 the ARMv7 stubs
> > didn't configured the ARM architectural timer. This firmware issue has
> > been fixed in 2020, which gave users enough time to update their system.
> >
> > So drop this property to allow the use of the vDSO version of
> > clock_gettime.
> >
> > Link: https://github.com/raspberrypi/tools/pull/113
> > Fixes: 7dbe8c62ceeb ("ARM: dts: Add minimal Raspberry Pi 4 support")
> > Signed-off-by: Phil Elwell <phil@raspberrypi.com>
> > Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
> > ---
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

FYI, although the patch was written by me, the commit message has been
completely rewritten.

Phil

Re: [PATCH] ARM: dts: bcm2711: Don't mark timer regs unconfigured

[Stefan Wahren]

Am 23.02.25 um 17:11 schrieb Phil Elwell:
> On Sat, 22 Feb 2025 at 10:44, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 22/02/2025 10:41, Stefan Wahren wrote:
>>> From: Phil Elwell <phil@raspberrypi.com>
>>>
>>> During upstream process of Raspberry Pi 4 back in 2019 the ARMv7 stubs
>>> didn't configured the ARM architectural timer. This firmware issue has
>>> been fixed in 2020, which gave users enough time to update their system.
>>>
>>> So drop this property to allow the use of the vDSO version of
>>> clock_gettime.
>>>
>>> Link: https://github.com/raspberrypi/tools/pull/113
>>> Fixes: 7dbe8c62ceeb ("ARM: dts: Add minimal Raspberry Pi 4 support")
>>> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
>>> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
>>> ---
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> FYI, although the patch was written by me, the commit message has been
> completely rewritten.
Sorry, for mention this in the commit log, but i thought this was
necessary to explain why this property was accepted in the first place.

This is the original one:

https://github.com/raspberrypi/linux/commit/d06cb3534b6553a1f76bef2ddaf833e23dc12a4c

>
> Phil

Re: [PATCH] ARM: dts: bcm2711: Don't mark timer regs unconfigured

[Florian Fainelli]

On 2/22/25 01:41, Stefan Wahren wrote:
> From: Phil Elwell <phil@raspberrypi.com>
> 
> During upstream process of Raspberry Pi 4 back in 2019 the ARMv7 stubs
> didn't configured the ARM architectural timer. This firmware issue has
> been fixed in 2020, which gave users enough time to update their system.
> 
> So drop this property to allow the use of the vDSO version of
> clock_gettime.
> 
> Link: https://github.com/raspberrypi/tools/pull/113
> Fixes: 7dbe8c62ceeb ("ARM: dts: Add minimal Raspberry Pi 4 support")
> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>

Applied to devicetree/fixes, thanks!
-- 
Florian