From: "Nuno Sá" <noname.nuno@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
nuno.sa@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: adi,ad5791.yaml: Add support for controlling RBUF
Date: Tue, 28 Nov 2023 11:11:18 +0100 [thread overview]
Message-ID: <5ad34779b6ad50f7f00c99f27e171f34628cebe0.camel@gmail.com> (raw)
In-Reply-To: <30a74f59-6230-48d5-a872-a9bee0cc5b4f@linaro.org>
On Tue, 2023-11-28 at 10:33 +0100, Krzysztof Kozlowski wrote:
> On 27/11/2023 16:55, Nuno Sa via B4 Relay wrote:
> > From: Michael Hennerich <michael.hennerich@analog.com>
> >
>
> Subject: drop ".yaml"
Will do...
>
> > This patch adds support for an external amplifier to be connected in a
>
> Please do not use "This commit/patch", but imperative mood. See longer
> explanation here:
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
ack...
>
> > gain of two configuration.
> >
> > Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> > Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> > ---
> > Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> > b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> > index 3a84739736f6..c81285d84db7 100644
> > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5791.yaml
> > @@ -26,6 +26,11 @@ properties:
> > vdd-supply: true
> > vss-supply: true
> >
> > + adi,rbuf-gain2-en:
> > + description: Specify to allow an external amplifier to be connected in
> > a
> > + gain of two configuration.
>
> I don't understand this. Without this property external amplifier is not
> allowed to be connected? This sounds like some policy, but should rather
> focus on hardware.
>
Well, this really translates in a different configuration in the device. If this
is set then the device is configured to allow an external amplifier to be
connected in a gain of two configuration which depends on the HW setup you want
the chip to be.
The description already states pretty much what the datasheet says. So while I
understand it's a fair question from you (you don't have the time to check all
datasheets for reviews you do), I'm not sure there's much more to add into the
description of the property.
- Nuno Sá
next prev parent reply other threads:[~2023-11-28 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 15:55 [PATCH 0/2] iio: dac: ad5791: Add support for controlling RBUF via devicetree Nuno Sa via B4 Relay
2023-11-27 15:55 ` [PATCH 1/2] dt-bindings: adi,ad5791.yaml: Add support for controlling RBUF Nuno Sa via B4 Relay
2023-11-28 9:33 ` Krzysztof Kozlowski
2023-11-28 10:11 ` Nuno Sá [this message]
2023-11-28 10:09 ` Krzysztof Kozlowski
2023-11-27 15:55 ` [PATCH 2/2] iio: dac: ad5791: Add support for controlling RBUF via devicetree Nuno Sa via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ad34779b6ad50f7f00c99f27e171f34628cebe0.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).