Re: [PATCH] feat: Add 'hold-in-reset-in-suspend' property to goodix touchscreen binding

[Jan Jasper de Kroon <jajadekroon@gmail.com>]

Op 14-03-2023 om 15:10 schreef Rob Herring:
> On Sat, 11 Mar 2023 14:46:55 +0100, Jan Jasper de Kroon wrote:
>> This patch adds a new property, 'hold-in-reset-in-suspend', to the Goodix touchscreen
>> device tree binding. When set to true, the touchscreen controller will be held in
>> reset mode during system suspend, reducing power consumption. The property is optional
>> and defaults to false if not present.
>>
>> I am submitting this patch to the Device Tree mailing list to add a new property to
>> the Goodix touchscreen device tree binding. This patch supplements a related patch
>> sent to the linux-input mailing list, which updates the Goodix touchscreen driver to
>> use this new property.
>> The linux-input patch can be found at:
>> https://lore.kernel.org/all/20230311131534.484700-1-jajadekroon@gmail.com/
>>
>> Signed-off-by: Jan Jasper de Kroon <jajadekroon@gmail.com>
>> ---
>>   .../devicetree/bindings/input/touchscreen/goodix.yaml    | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/input/touchscreen/goodix.example.dts:31.41-42 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/input/touchscreen/goodix.example.dtb] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1512: dt_binding_check] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230311134655.486973-1-jajadekroon@gmail.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
Hello Rob,

Thank you for your time checking out the patch.
In the meantime I already had a new patch up.
Accidentally I send it as a follow-up comment to Krzysztof's earlier 
comment.
I can see that your bot also already tried it:
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230312183106.551840-1-jajadekroon@gmail.com/
Do I need to resend the patch as a follow-up to my main patchset?
I'm quite new to the LKML, so I'm still getting the hang of it and am 
still a bit clumsy.

Kind Regards

Jasper