[PATCH 00/10] Grab IPA IMEM slice through DT, part 2

[PATCH 00/10] Grab IPA IMEM slice through DT, part 2

[Konrad Dybcio]

The IPA IMEM slice addresses/sizes are hardcoded in the driver. That's
mucho no bueno, especially since the same versions of IPA are used
across a number of vastly different platforms, which invalidates that
approach completely.

This series wires up the IMEM slices in DT on almost all platforms
(need some more time for SDX55/65) and fills in the necessary bindings
holes.

Tested on SC7280 only, FWIW.

Patches 1-3 are good to go instantly, the rest must wait for the
bindings changes that were submitted in the series marked as a
dependency.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
Konrad Dybcio (10):
      dt-bindings: sram: qcom,imem: Add a number of missing compatibles
      arm64: dts: qcom: sdm845: Expand IMEM region
      arm64: dts: qcom: sc7180: Expand IMEM region
      arm64: dts: qcom: sc7180: Explicitly describe the IPA IMEM slice
      arm64: dts: qcom: sc7280: Explicitly describe the IPA IMEM slice
      arm64: dts: qcom: sdm845: Explicitly describe the IPA IMEM slice
      arm64: dts: qcom: sm6350: Explicitly describe the IPA IMEM slice
      arm64: dts: qcom: sm8350: Explicitly describe the IPA IMEM slice
      arm64: dts: qcom: sm8550: Explicitly describe the IPA IMEM slice
      arm64: dts: qcom: sm8650: Explicitly describe the IPA IMEM slice

 Documentation/devicetree/bindings/sram/qcom,imem.yaml | 13 +++++++++++++
 arch/arm64/boot/dts/qcom/sc7180.dtsi                  | 16 +++++++++++-----
 arch/arm64/boot/dts/qcom/sc7280.dtsi                  |  6 ++++++
 arch/arm64/boot/dts/qcom/sdm845.dtsi                  | 16 +++++++++++-----
 arch/arm64/boot/dts/qcom/sm6350.dtsi                  | 16 ++++++++++++++++
 arch/arm64/boot/dts/qcom/sm8350.dtsi                  | 16 ++++++++++++++++
 arch/arm64/boot/dts/qcom/sm8550.dtsi                  | 16 ++++++++++++++++
 arch/arm64/boot/dts/qcom/sm8650.dtsi                  | 16 ++++++++++++++++
 8 files changed, 105 insertions(+), 10 deletions(-)
---
base-commit: 6add743d2854d744c3037235b87c1c9d164fd132
change-id: 20250523-topic-ipa_mem_dts-58f5d73a1f21
prerequisite-message-id: <20250523-topic-ipa_imem-v1-0-b5d536291c7f@oss.qualcomm.com>
prerequisite-patch-id: f6aa0c354d434ec11dd88b93528c05cb3a45bb07
prerequisite-patch-id: 89f72ef0c3d3f29753b0cb9e290a4036ba380cc1
prerequisite-patch-id: 330c94ac7c2b42dd86c5f763b133f0d2598fda40

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

[PATCH 01/10] dt-bindings: sram: qcom,imem: Add a number of missing compatibles

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Currently described or not, IMEM is present on *all* Qualcomm SoCs.
Preemptively add a number of compatibles to ease integration.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/sram/qcom,imem.yaml | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/Documentation/devicetree/bindings/sram/qcom,imem.yaml b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
index 2711f90d9664b70fcd1e2f7e2dfd3386ed5c1952..70f934e3569068c0781d9ebad16e7da2f7932d6f 100644
--- a/Documentation/devicetree/bindings/sram/qcom,imem.yaml
+++ b/Documentation/devicetree/bindings/sram/qcom,imem.yaml
@@ -25,14 +25,27 @@ properties:
           - qcom,qcs8300-imem
           - qcom,qdu1000-imem
           - qcom,sa8775p-imem
+          - qcom,sar2130p-imem
           - qcom,sc7180-imem
           - qcom,sc7280-imem
+          - qcom,sc8280xp-imem
           - qcom,sdm630-imem
           - qcom,sdm845-imem
           - qcom,sdx55-imem
           - qcom,sdx65-imem
+          - qcom,sdx75-imem
+          - qcom,sm6115-imem
+          - qcom,sm6125-imem
+          - qcom,sm6350-imem
           - qcom,sm6375-imem
+          - qcom,sm8150-imem
+          - qcom,sm8250-imem
+          - qcom,sm8350-imem
           - qcom,sm8450-imem
+          - qcom,sm8550-imem
+          - qcom,sm8650-imem
+          - qcom,sm8750-imem
+          - qcom,x1e80100-imem
       - const: syscon
       - const: simple-mfd
 

-- 
2.49.0

Re: [PATCH 01/10] dt-bindings: sram: qcom,imem: Add a number of missing compatibles

[Krzysztof Kozlowski]

On Fri, May 23, 2025 at 01:18:16AM GMT, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> Currently described or not, IMEM is present on *all* Qualcomm SoCs.
> Preemptively add a number of compatibles to ease integration.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/sram/qcom,imem.yaml | 13 +++++++++++++
>  1 file changed, 13 insertions(+)

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

[PATCH 02/10] arm64: dts: qcom: sdm845: Expand IMEM region

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

We need more than what is currently described, expand the region to its
actual boundaries.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 3bc8471c658bda987d6fcff3359d63b367148e89..6ee97cfecc705c317164fbba8df426f6be52e932 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -5081,18 +5081,18 @@ spmi_bus: spmi@c440000 {
 			#interrupt-cells = <4>;
 		};
 
-		sram@146bf000 {
+		sram@14680000 {
 			compatible = "qcom,sdm845-imem", "syscon", "simple-mfd";
-			reg = <0 0x146bf000 0 0x1000>;
+			reg = <0 0x14680000 0 0x40000>;
 
 			#address-cells = <1>;
 			#size-cells = <1>;
 
-			ranges = <0 0 0x146bf000 0x1000>;
+			ranges = <0 0 0x14680000 0x40000>;
 
-			pil-reloc@94c {
+			pil-reloc@3f94c {
 				compatible = "qcom,pil-reloc-info";
-				reg = <0x94c 0xc8>;
+				reg = <0x3f94c 0xc8>;
 			};
 		};
 

-- 
2.49.0

Re: [PATCH 02/10] arm64: dts: qcom: sdm845: Expand IMEM region

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 01:18:17AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> We need more than what is currently described, expand the region to its
> actual boundaries.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Fixes: 948f6161c6ab ("arm64: dts: qcom: sdm845: Add IMEM and PIL info region")

BTW, are you sure about the address? msm-4.9 agrees with the current
one.

> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 3bc8471c658bda987d6fcff3359d63b367148e89..6ee97cfecc705c317164fbba8df426f6be52e932 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -5081,18 +5081,18 @@ spmi_bus: spmi@c440000 {
>  			#interrupt-cells = <4>;
>  		};
>  
> -		sram@146bf000 {
> +		sram@14680000 {
>  			compatible = "qcom,sdm845-imem", "syscon", "simple-mfd";
> -			reg = <0 0x146bf000 0 0x1000>;
> +			reg = <0 0x14680000 0 0x40000>;
>  
>  			#address-cells = <1>;
>  			#size-cells = <1>;
>  
> -			ranges = <0 0 0x146bf000 0x1000>;
> +			ranges = <0 0 0x14680000 0x40000>;
>  
> -			pil-reloc@94c {
> +			pil-reloc@3f94c {
>  				compatible = "qcom,pil-reloc-info";
> -				reg = <0x94c 0xc8>;
> +				reg = <0x3f94c 0xc8>;
>  			};
>  		};
>  
> 
> -- 
> 2.49.0
> 

-- 
With best wishes
Dmitry

Re: [PATCH 02/10] arm64: dts: qcom: sdm845: Expand IMEM region

[Konrad Dybcio]

On 5/23/25 12:40 PM, Dmitry Baryshkov wrote:
> On Fri, May 23, 2025 at 01:18:17AM +0200, Konrad Dybcio wrote:
>> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>>
>> We need more than what is currently described, expand the region to its
>> actual boundaries.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>> ---
>>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Fixes: 948f6161c6ab ("arm64: dts: qcom: sdm845: Add IMEM and PIL info region")
> 
> BTW, are you sure about the address? msm-4.9 agrees with the current
> one.

we talked offline, but for the record, it is intentional - parts of IMEM
are not accessible to the OS and were previously not described

Konrad

Re: [PATCH 02/10] arm64: dts: qcom: sdm845: Expand IMEM region

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 08:12:38PM +0200, Konrad Dybcio wrote:
> On 5/23/25 12:40 PM, Dmitry Baryshkov wrote:
> > On Fri, May 23, 2025 at 01:18:17AM +0200, Konrad Dybcio wrote:
> >> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >>
> >> We need more than what is currently described, expand the region to its
> >> actual boundaries.
> >>
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> >> ---
> >>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 10 +++++-----
> >>  1 file changed, 5 insertions(+), 5 deletions(-)
> > 
> > Fixes: 948f6161c6ab ("arm64: dts: qcom: sdm845: Add IMEM and PIL info region")
> > 
> > BTW, are you sure about the address? msm-4.9 agrees with the current
> > one.
> 
> we talked offline, but for the record, it is intentional - parts of IMEM
> are not accessible to the OS and were previously not described

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

[PATCH 03/10] arm64: dts: qcom: sc7180: Expand IMEM region

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

We need more than what is currently described, expand the region to its
actual boundaries.

Fixes: ede638c42c82 ("arm64: dts: qcom: sc7180: Add IMEM and pil info regions")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 01e727b021ec587f7b3384f7301620a21ddef281..3afb69921be363bd35a996bc1d6f70ff007c6af8 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3526,18 +3526,18 @@ spmi_bus: spmi@c440000 {
 			#interrupt-cells = <4>;
 		};
 
-		sram@146aa000 {
+		sram@14680000 {
 			compatible = "qcom,sc7180-imem", "syscon", "simple-mfd";
-			reg = <0 0x146aa000 0 0x2000>;
+			reg = <0 0x14680000 0 0x2e000>;
 
 			#address-cells = <1>;
 			#size-cells = <1>;
 
-			ranges = <0 0 0x146aa000 0x2000>;
+			ranges = <0 0 0x14680000 0x2e000>;
 
-			pil-reloc@94c {
+			pil-reloc@2a94c {
 				compatible = "qcom,pil-reloc-info";
-				reg = <0x94c 0xc8>;
+				reg = <0x2a94c 0xc8>;
 			};
 		};
 

-- 
2.49.0

Re: [PATCH 03/10] arm64: dts: qcom: sc7180: Expand IMEM region

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 01:18:18AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> We need more than what is currently described, expand the region to its
> actual boundaries.
> 
> Fixes: ede638c42c82 ("arm64: dts: qcom: sc7180: Add IMEM and pil info regions")
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

[PATCH 04/10] arm64: dts: qcom: sc7180: Explicitly describe the IPA IMEM slice

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

As part of stepping away from crazy hardcoding in the driver, move
define the slice explicitly and pass it to the IPA node.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 3afb69921be363bd35a996bc1d6f70ff007c6af8..84b032dc09d36e56eeaf182125cceb44e7333765 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1640,6 +1640,8 @@ ipa: ipa@1e40000 {
 			qcom,smem-state-names = "ipa-clock-enabled-valid",
 						"ipa-clock-enabled";
 
+			sram = <&ipa_modem_tables>;
+
 			status = "disabled";
 		};
 
@@ -3535,6 +3537,10 @@ sram@14680000 {
 
 			ranges = <0 0 0x14680000 0x2e000>;
 
+			ipa_modem_tables: modem-tables@28000 {
+				reg = <0x28000 0x2000>;
+			};
+
 			pil-reloc@2a94c {
 				compatible = "qcom,pil-reloc-info";
 				reg = <0x2a94c 0xc8>;

-- 
2.49.0

Re: [PATCH 04/10] arm64: dts: qcom: sc7180: Explicitly describe the IPA IMEM slice

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 01:18:19AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH 04/10] arm64: dts: qcom: sc7180: Explicitly describe the IPA IMEM slice

[Bjorn Andersson]

On Fri, May 23, 2025 at 01:18:19AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 3afb69921be363bd35a996bc1d6f70ff007c6af8..84b032dc09d36e56eeaf182125cceb44e7333765 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1640,6 +1640,8 @@ ipa: ipa@1e40000 {
>  			qcom,smem-state-names = "ipa-clock-enabled-valid",
>  						"ipa-clock-enabled";
>  
> +			sram = <&ipa_modem_tables>;

Please resubmit the second half of this series, once sram is an accepted
property.

Thanks,
Bjorn

> +
>  			status = "disabled";
>  		};
>  
> @@ -3535,6 +3537,10 @@ sram@14680000 {
>  
>  			ranges = <0 0 0x14680000 0x2e000>;
>  
> +			ipa_modem_tables: modem-tables@28000 {
> +				reg = <0x28000 0x2000>;
> +			};
> +
>  			pil-reloc@2a94c {
>  				compatible = "qcom,pil-reloc-info";
>  				reg = <0x2a94c 0xc8>;
> 
> -- 
> 2.49.0
> 

[PATCH 05/10] arm64: dts: qcom: sc7280: Explicitly describe the IPA IMEM slice

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

As part of stepping away from crazy hardcoding in the driver, move
define the slice explicitly and pass it to the IPA node.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index b1cc3bc1aec8b769021cdc25c8d66845e7bebe70..3df93a256a18e5500f3278d96be5ff5ba57c73b9 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2499,6 +2499,8 @@ ipa: ipa@1e40000 {
 			qcom,smem-state-names = "ipa-clock-enabled-valid",
 						"ipa-clock-enabled";
 
+			sram = <&ipa_modem_tables>;
+
 			status = "disabled";
 		};
 
@@ -6022,6 +6024,10 @@ sram@146a5000 {
 
 			ranges = <0 0 0x146a5000 0x6000>;
 
+			ipa_modem_tables: modem-tables@3000 {
+				reg = <0x3000 0x2000>;
+			};
+
 			pil-reloc@594c {
 				compatible = "qcom,pil-reloc-info";
 				reg = <0x594c 0xc8>;

-- 
2.49.0

Re: [PATCH 05/10] arm64: dts: qcom: sc7280: Explicitly describe the IPA IMEM slice

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 01:18:20AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH 05/10] arm64: dts: qcom: sc7280: Explicitly describe the IPA IMEM slice

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 01:18:20AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
-- 
With best wishes
Dmitry

[PATCH 06/10] arm64: dts: qcom: sdm845: Explicitly describe the IPA IMEM slice

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

As part of stepping away from crazy hardcoding in the driver, move
define the slice explicitly and pass it to the IPA node.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 6ee97cfecc705c317164fbba8df426f6be52e932..eb49e18fba62755d56543b4bf3ecdd643a03a256 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2743,6 +2743,8 @@ ipa: ipa@1e40000 {
 			qcom,smem-state-names = "ipa-clock-enabled-valid",
 						"ipa-clock-enabled";
 
+			sram = <&ipa_modem_tables>;
+
 			status = "disabled";
 		};
 
@@ -5090,6 +5092,10 @@ sram@14680000 {
 
 			ranges = <0 0 0x14680000 0x40000>;
 
+			ipa_modem_tables: modem-tables@3d000 {
+				reg = <0x3d000 0x2000>;
+			};
+
 			pil-reloc@3f94c {
 				compatible = "qcom,pil-reloc-info";
 				reg = <0x3f94c 0xc8>;

-- 
2.49.0

Re: [PATCH 06/10] arm64: dts: qcom: sdm845: Explicitly describe the IPA IMEM slice

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 01:18:21AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

It seems yesterday I was blind...

-- 
With best wishes
Dmitry

[PATCH 07/10] arm64: dts: qcom: sm6350: Explicitly describe the IPA IMEM slice

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

As part of stepping away from crazy hardcoding in the driver, move
define the slice explicitly and pass it to the IPA node.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm6350.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
index f80b21d28a929619fc91b4e9d659acce40a0957b..257bda19060936f4cb7c1f7aa9b481e77545f395 100644
--- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
@@ -1273,6 +1273,8 @@ ipa: ipa@1e40000 {
 			qcom,smem-state-names = "ipa-clock-enabled-valid",
 						"ipa-clock-enabled";
 
+			sram = <&ipa_modem_tables>;
+
 			status = "disabled";
 		};
 
@@ -2603,6 +2605,20 @@ qup_uart1_tx: qup-uart1-tx-default-state {
 			};
 		};
 
+		sram@14680000 {
+			compatible = "qcom,sm6350-imem", "syscon", "simple-mfd";
+			reg = <0 0x14680000 0 0x2e000>;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			ranges = <0 0 0x14680000 0x2e000>;
+
+			ipa_modem_tables: modem-tables@28000 {
+				reg = <0x28000 0x2000>;
+			};
+		};
+
 		apps_smmu: iommu@15000000 {
 			compatible = "qcom,sm6350-smmu-500", "arm,mmu-500";
 			reg = <0x0 0x15000000 0x0 0x100000>;

-- 
2.49.0

Re: [PATCH 07/10] arm64: dts: qcom: sm6350: Explicitly describe the IPA IMEM slice

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 01:18:22AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm6350.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

[PATCH 08/10] arm64: dts: qcom: sm8350: Explicitly describe the IPA IMEM slice

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

As part of stepping away from crazy hardcoding in the driver, move
define the slice explicitly and pass it to the IPA node.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8350.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index 971c828a7555885aa2f05647634eb7132333fb47..bbe225f339753a03a268b1089b4c35a1a1107cb2 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -1862,6 +1862,8 @@ ipa: ipa@1e40000 {
 			qcom,smem-state-names = "ipa-clock-enabled-valid",
 						"ipa-clock-enabled";
 
+			sram = <&ipa_modem_tables>;
+
 			status = "disabled";
 		};
 
@@ -3432,6 +3434,20 @@ qup_i2c19_default: qup-i2c19-default-state {
 			};
 		};
 
+		sram@14680000 {
+			compatible = "qcom,sm8350-imem", "syscon", "simple-mfd";
+			reg = <0 0x14680000 0 0x40000>;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			ranges = <0 0 0x14680000 0x40000>;
+
+			ipa_modem_tables: modem-tables@3d000 {
+				reg = <0x3d000 0x2000>;
+			};
+		};
+
 		apps_smmu: iommu@15000000 {
 			compatible = "qcom,sm8350-smmu-500", "arm,mmu-500";
 			reg = <0 0x15000000 0 0x100000>;

-- 
2.49.0

Re: [PATCH 08/10] arm64: dts: qcom: sm8350: Explicitly describe the IPA IMEM slice

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 01:18:23AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8350.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

[PATCH 09/10] arm64: dts: qcom: sm8550: Explicitly describe the IPA IMEM slice

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

As part of stepping away from crazy hardcoding in the driver, move
define the slice explicitly and pass it to the IPA node.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8550.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 71a7e3b57ecedd86d798e71b781451fe11f9c1ce..17d755daba4141d3a8716cd6ff4483c34dc0f660 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -2659,6 +2659,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 			qcom,smem-state-names = "ipa-clock-enabled-valid",
 						"ipa-clock-enabled";
 
+			sram = <&ipa_modem_tables>;
+
 			status = "disabled";
 		};
 
@@ -4737,6 +4739,20 @@ data-pins {
 			};
 		};
 
+		sram@14680000 {
+			compatible = "qcom,sm8350-imem", "syscon", "simple-mfd";
+			reg = <0 0x14680000 0 0x2c000>;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			ranges = <0 0 0x14680000 0x2c000>;
+
+			ipa_modem_tables: modem-tables@8000 {
+				reg = <0x8000 0x2000>;
+			};
+		};
+
 		apps_smmu: iommu@15000000 {
 			compatible = "qcom,sm8550-smmu-500", "qcom,smmu-500", "arm,mmu-500";
 			reg = <0 0x15000000 0 0x100000>;

-- 
2.49.0

Re: [PATCH 09/10] arm64: dts: qcom: sm8550: Explicitly describe the IPA IMEM slice

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 01:18:24AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8550.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH 09/10] arm64: dts: qcom: sm8550: Explicitly describe the IPA IMEM slice

[neil.armstrong]

On 23/05/2025 01:18, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>   arch/arm64/boot/dts/qcom/sm8550.dtsi | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 71a7e3b57ecedd86d798e71b781451fe11f9c1ce..17d755daba4141d3a8716cd6ff4483c34dc0f660 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -2659,6 +2659,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>   			qcom,smem-state-names = "ipa-clock-enabled-valid",
>   						"ipa-clock-enabled";
>   
> +			sram = <&ipa_modem_tables>;
> +
>   			status = "disabled";
>   		};
>   
> @@ -4737,6 +4739,20 @@ data-pins {
>   			};
>   		};
>   
> +		sram@14680000 {
> +			compatible = "qcom,sm8350-imem", "syscon", "simple-mfd";
> +			reg = <0 0x14680000 0 0x2c000>;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			ranges = <0 0 0x14680000 0x2c000>;
> +
> +			ipa_modem_tables: modem-tables@8000 {
> +				reg = <0x8000 0x2000>;
> +			};
> +		};
> +
>   		apps_smmu: iommu@15000000 {
>   			compatible = "qcom,sm8550-smmu-500", "qcom,smmu-500", "arm,mmu-500";
>   			reg = <0 0x15000000 0 0x100000>;
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

[PATCH 10/10] arm64: dts: qcom: sm8650: Explicitly describe the IPA IMEM slice

[Konrad Dybcio]

From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

As part of stepping away from crazy hardcoding in the driver, move
define the slice explicitly and pass it to the IPA node.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sm8650.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
index 495ea9bfd008500dd2c9f46ceca94cf5f972beca..7b80d281cac4349ffc2adac0650e07329da461aa 100644
--- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
@@ -4344,6 +4344,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
 			qcom,smem-state-names = "ipa-clock-enabled-valid",
 						"ipa-clock-enabled";
 
+			sram = <&ipa_modem_tables>;
+
 			status = "disabled";
 		};
 
@@ -6637,6 +6639,20 @@ funnel_apss_out_funnel_in1: endpoint {
 			};
 		};
 
+		sram@14680000 {
+			compatible = "qcom,sm8350-imem", "syscon", "simple-mfd";
+			reg = <0 0x14680000 0 0x2c000>;
+
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			ranges = <0 0 0x14680000 0x2c000>;
+
+			ipa_modem_tables: modem-tables@8000 {
+				reg = <0x8000 0x2000>;
+			};
+		};
+
 		apps_smmu: iommu@15000000 {
 			compatible = "qcom,sm8650-smmu-500", "qcom,smmu-500", "arm,mmu-500";
 			reg = <0 0x15000000 0 0x100000>;

-- 
2.49.0

Re: [PATCH 10/10] arm64: dts: qcom: sm8650: Explicitly describe the IPA IMEM slice

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 01:18:25AM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8650.dtsi | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH 10/10] arm64: dts: qcom: sm8650: Explicitly describe the IPA IMEM slice

[neil.armstrong]

On 23/05/2025 01:18, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> As part of stepping away from crazy hardcoding in the driver, move
> define the slice explicitly and pass it to the IPA node.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>   arch/arm64/boot/dts/qcom/sm8650.dtsi | 16 ++++++++++++++++
>   1 file changed, 16 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8650.dtsi b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> index 495ea9bfd008500dd2c9f46ceca94cf5f972beca..7b80d281cac4349ffc2adac0650e07329da461aa 100644
> --- a/arch/arm64/boot/dts/qcom/sm8650.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8650.dtsi
> @@ -4344,6 +4344,8 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>   			qcom,smem-state-names = "ipa-clock-enabled-valid",
>   						"ipa-clock-enabled";
>   
> +			sram = <&ipa_modem_tables>;
> +
>   			status = "disabled";
>   		};
>   
> @@ -6637,6 +6639,20 @@ funnel_apss_out_funnel_in1: endpoint {
>   			};
>   		};
>   
> +		sram@14680000 {
> +			compatible = "qcom,sm8350-imem", "syscon", "simple-mfd";
> +			reg = <0 0x14680000 0 0x2c000>;
> +
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +
> +			ranges = <0 0 0x14680000 0x2c000>;
> +
> +			ipa_modem_tables: modem-tables@8000 {
> +				reg = <0x8000 0x2000>;
> +			};
> +		};
> +
>   		apps_smmu: iommu@15000000 {
>   			compatible = "qcom,sm8650-smmu-500", "qcom,smmu-500", "arm,mmu-500";
>   			reg = <0 0x15000000 0 0x100000>;
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

Re: [PATCH 00/10] Grab IPA IMEM slice through DT, part 2

[Dmitry Baryshkov]

On Fri, May 23, 2025 at 01:18:15AM +0200, Konrad Dybcio wrote:
> The IPA IMEM slice addresses/sizes are hardcoded in the driver. That's
> mucho no bueno, especially since the same versions of IPA are used
> across a number of vastly different platforms, which invalidates that
> approach completely.
> 
> This series wires up the IMEM slices in DT on almost all platforms
> (need some more time for SDX55/65) and fills in the necessary bindings
> holes.
> 
> Tested on SC7280 only, FWIW.
> 
> Patches 1-3 are good to go instantly, the rest must wait for the
> bindings changes that were submitted in the series marked as a
> dependency.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
> Konrad Dybcio (10):
>       dt-bindings: sram: qcom,imem: Add a number of missing compatibles
>       arm64: dts: qcom: sdm845: Expand IMEM region

You've expanded IMEM region for SDM845, but you didn't add IPA slice. Is
that expected?

>       arm64: dts: qcom: sc7180: Expand IMEM region
>       arm64: dts: qcom: sc7180: Explicitly describe the IPA IMEM slice
>       arm64: dts: qcom: sc7280: Explicitly describe the IPA IMEM slice
>       arm64: dts: qcom: sdm845: Explicitly describe the IPA IMEM slice
>       arm64: dts: qcom: sm6350: Explicitly describe the IPA IMEM slice
>       arm64: dts: qcom: sm8350: Explicitly describe the IPA IMEM slice
>       arm64: dts: qcom: sm8550: Explicitly describe the IPA IMEM slice
>       arm64: dts: qcom: sm8650: Explicitly describe the IPA IMEM slice
> 
>  Documentation/devicetree/bindings/sram/qcom,imem.yaml | 13 +++++++++++++
>  arch/arm64/boot/dts/qcom/sc7180.dtsi                  | 16 +++++++++++-----
>  arch/arm64/boot/dts/qcom/sc7280.dtsi                  |  6 ++++++
>  arch/arm64/boot/dts/qcom/sdm845.dtsi                  | 16 +++++++++++-----
>  arch/arm64/boot/dts/qcom/sm6350.dtsi                  | 16 ++++++++++++++++
>  arch/arm64/boot/dts/qcom/sm8350.dtsi                  | 16 ++++++++++++++++
>  arch/arm64/boot/dts/qcom/sm8550.dtsi                  | 16 ++++++++++++++++
>  arch/arm64/boot/dts/qcom/sm8650.dtsi                  | 16 ++++++++++++++++
>  8 files changed, 105 insertions(+), 10 deletions(-)
> ---
> base-commit: 6add743d2854d744c3037235b87c1c9d164fd132
> change-id: 20250523-topic-ipa_mem_dts-58f5d73a1f21
> prerequisite-message-id: <20250523-topic-ipa_imem-v1-0-b5d536291c7f@oss.qualcomm.com>
> prerequisite-patch-id: f6aa0c354d434ec11dd88b93528c05cb3a45bb07
> prerequisite-patch-id: 89f72ef0c3d3f29753b0cb9e290a4036ba380cc1
> prerequisite-patch-id: 330c94ac7c2b42dd86c5f763b133f0d2598fda40
> 
> Best regards,
> -- 
> Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 

-- 
With best wishes
Dmitry

Re: [PATCH 00/10] Grab IPA IMEM slice through DT, part 2

[Bjorn Andersson]

On Fri, 23 May 2025 01:18:15 +0200, Konrad Dybcio wrote:
> The IPA IMEM slice addresses/sizes are hardcoded in the driver. That's
> mucho no bueno, especially since the same versions of IPA are used
> across a number of vastly different platforms, which invalidates that
> approach completely.
> 
> This series wires up the IMEM slices in DT on almost all platforms
> (need some more time for SDX55/65) and fills in the necessary bindings
> holes.
> 
> [...]

Applied, thanks!

[01/10] dt-bindings: sram: qcom,imem: Add a number of missing compatibles
        commit: 9cea10a4f5a39fde32bf7b8addfa5f9175174e0e
[02/10] arm64: dts: qcom: sdm845: Expand IMEM region
        commit: 81a4a7de3d4031e77b5796479ef21aefb0862807
[03/10] arm64: dts: qcom: sc7180: Expand IMEM region
        commit: 965e28cad4739b11f1bc58c0a9935e025938bb1f
[04/10] arm64: dts: qcom: sc7180: Explicitly describe the IPA IMEM slice
        (no commit info)
[05/10] arm64: dts: qcom: sc7280: Explicitly describe the IPA IMEM slice
        (no commit info)
[06/10] arm64: dts: qcom: sdm845: Explicitly describe the IPA IMEM slice
        (no commit info)
[07/10] arm64: dts: qcom: sm6350: Explicitly describe the IPA IMEM slice
        (no commit info)
[08/10] arm64: dts: qcom: sm8350: Explicitly describe the IPA IMEM slice
        (no commit info)
[09/10] arm64: dts: qcom: sm8550: Explicitly describe the IPA IMEM slice
        (no commit info)
[10/10] arm64: dts: qcom: sm8650: Explicitly describe the IPA IMEM slice
        (no commit info)

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>