From: David Collins <collinsd@codeaurora.org>
To: Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Taniya Das <tdas@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Odelu Kukatla <okukatla@codeaurora.org>,
Amit Nischal <anischal@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] clk: qcom: clk-rpmh: Add QCOM RPMh clock driver
Date: Mon, 16 Apr 2018 14:47:42 -0700 [thread overview]
Message-ID: <5af35710-b521-e22e-055b-798cbe343dc6@codeaurora.org> (raw)
In-Reply-To: <152390031768.51482.12790579493617671456@swboyd.mtv.corp.google.com>
Hello Taniya,
On 04/16/2018 10:38 AM, Stephen Boyd wrote:
> Quoting Taniya Das (2018-04-13 19:36:41)
>> Add the RPMh clock driver to control the RPMh managed clock resources on
>> some of the Qualcomm Technologies, Inc. SoCs.
>>
>> Signed-off-by: David Collins <collinsd@codeaurora.org>
>> Signed-off-by: Amit Nischal <anischal@codeaurora.org>
>
> Your signoff chain is very confused. The first signoff should match the
> "From:" header but that doesn't seem to be the case here. And the sender
> should be the last in the chain.
It looks like the provenance of this driver go muddled during downstream
propagation between branches. The original downstream version of the
clk-rpmh driver was written by Osvaldo Banuelos [1]. I think that the
best course of action here would be to remove my Signed-off-by, add
Osvaldo's, and add yours.
Thanks,
David
[1]:
https://source.codeaurora.org/quic/la/kernel/msm-4.9/commit/?id=11d3623c37afb945ce36755501812a44efeb6cd9
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-04-16 21:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 2:36 [PATCH v3 0/2] clk: qcom: clk-rpmh: Add QCOM RPMh clock driver Taniya Das
2018-04-14 2:36 ` [PATCH v3 1/2] dt-bindings: clock: Introduce QCOM RPMh clock bindings Taniya Das
2018-04-16 17:39 ` Stephen Boyd
2018-04-16 20:45 ` Rob Herring
2018-04-14 2:36 ` [PATCH v3 2/2] clk: qcom: clk-rpmh: Add QCOM RPMh clock driver Taniya Das
2018-04-16 17:38 ` Stephen Boyd
2018-04-16 21:47 ` David Collins [this message]
2018-04-23 16:50 ` Taniya Das
2018-04-24 15:40 ` Stephen Boyd
2018-04-17 23:57 ` [v3,2/2] " Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5af35710-b521-e22e-055b-798cbe343dc6@codeaurora.org \
--to=collinsd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=anischal@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=okukatla@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=sboyd@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).