Devicetree
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
	Liviu Dudau <liviu.dudau@arm.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	Sudeep Holla <sudeep.holla@arm.com>
Subject: [Query] DT warnings with ranges and sub-nodes
Date: Wed, 5 Apr 2017 14:58:13 +0100	[thread overview]
Message-ID: <5b1fc8af-b5e1-75bd-6cf3-84ea75e4987f@arm.com> (raw)

Hi Rob,

I am seeing some warning in juno DTS files. I would like to get your
feedback on how to resolve them.

Warning messages:

Warning (simple_bus_reg): Node /smb@8000000/motherboard/flash@0,00000000
simple-bus unit address format error, expected "0"
Warning (simple_bus_reg): Node
/smb@8000000/motherboard/ethernet@2,00000000 simple-bus unit address
format error, expected "200000000"
Warning (simple_bus_reg): Node
/smb@8000000/motherboard/iofpga@3,00000000 simple-bus unit address
format error, expected "300000000"

We have

        smb@8000000 {
                compatible = "simple-bus";
                #address-cells = <2>;
                #size-cells = <1>;
                ranges = <0 0 0 0x08000000 0x04000000>,
                         <1 0 0 0x14000000 0x04000000>,
                         <2 0 0 0x18000000 0x04000000>,
                         <3 0 0 0x1c000000 0x04000000>,
                         <4 0 0 0x0c000000 0x04000000>,
                         <5 0 0 0x10000000 0x04000000>;
		...
	
		flash@0,00000000 {
			...
		};
		ethernet@2,00000000 {
			...
		};
		iofpga@3,00000000 {
			...
		};
	};

All of which are @offset 0x0 in their respective ranges.

How do we specify the range as well as the offset ? Does the below
look like correct way of fixing those warnings ?
	flash@0
	ethernet@200000000
	iofpga@300000000

Or can I ignore these warning as I see the syntax to be correct as
provided in example in ePAPR(page 99 under Appendix B1 Ebony Device
Tree). Sorry if I have missed to follow any other thread on the same.

-- 
Regards,
Sudeep

                 reply	other threads:[~2017-04-05 13:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b1fc8af-b5e1-75bd-6cf3-84ea75e4987f@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=Lorenzo.Pieralisi@arm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=liviu.dudau@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox