From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E03F63A9DB5; Tue, 31 Mar 2026 10:18:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774952287; cv=none; b=e0YIcL0w2ouuf90NGXWZG4ZzNNNfDzV3KTSsD1TQgGDXEGvNAv4DK6ci+xHHIdGZ1c2PKNtgQAuZSFaFuJp1PskPWsXvvwLFBFUOo5LP8DThLMmyBQouaJCn9cf54Mwjwx9Zj2BS9N4FA1exYCcBXUVFZo3EfZT87yCEFkZwxCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774952287; c=relaxed/simple; bh=UfnCUS1B045T6Jje4Q/g4OmqqOXfLZGiks3Jd6gia+U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CsTQhXncggrXxbn6OqaFWp1v4FNamixvW6w1GYMyGeSfmogoxn/0vDk/rqmCTrzFlaCY7692rcF8D4DyJl55icKM32C9r9TwYHAaQ2OB3f65ddY6GB149ArY2A+vB3ZpD/pDf/EsMMQWYM3ntqEIocBgKuhLwuDXO7WNibnBdLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pCO7wA3S; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pCO7wA3S" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CBBB3C19423; Tue, 31 Mar 2026 10:18:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774952286; bh=UfnCUS1B045T6Jje4Q/g4OmqqOXfLZGiks3Jd6gia+U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pCO7wA3SruUGVcT08Q5ZzFKnXjBvTCLft3TIorP9G/1enn3KNqyd602skGtKV48v5 2tTH4IN1T5PMcWL0ZCeRIOyzLHFaU7St+bzVqjj4M3q1d8TmCasEDdjcR+M+gu/uI6 f3CP2Tsj9U8RLja+8kX8COHidczSRgKn3ObDKANKTxS0af70t8G1EfTqHoszo9GQfq +vcURX/L04EhhmzJeazpp+0IPh1E1Q6RzYCtY4T11SEsAhOZj0SvFe8FZ21nedEHKu M+n3mIoN3TGOpz4sdZlMmhCCopgS0rVhOnBpkuRVRroc+AWyLlRSSRjL3pZrd5OYhs 9EcOgv6Wn4xiw== Message-ID: <5b3eaba5-eba2-43f9-8ef5-d305ca50ddf0@kernel.org> Date: Tue, 31 Mar 2026 12:18:01 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 1/3] net: stmmac: Fix PTP ref clock for Tegra234 To: Jon Hunter Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org References: <20260325135811.148480-1-jonathanh@nvidia.com> <20260325135811.148480-2-jonathanh@nvidia.com> <20260326-gigantic-tentacled-hornet-cbdb8d@quoll> <01f56e6f-5459-4a96-9042-8a003a340fab@nvidia.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <01f56e6f-5459-4a96-9042-8a003a340fab@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 31/03/2026 12:14, Jon Hunter wrote: > > On 26/03/2026 08:32, Krzysztof Kozlowski wrote: > > ... > >>> @@ -257,9 +258,23 @@ static int tegra_mgbe_probe(struct platform_device *pdev) >>> if (!mgbe->clks) >>> return -ENOMEM; >>> >>> - for (i = 0; i < ARRAY_SIZE(mgbe_clks); i++) >>> + /* >>> + * Older device-trees use 'ptp-ref' rather than 'ptp_ref'. >>> + * Fall back to the legacy name when 'ptp_ref' is absent. >>> + */ >>> + use_legacy_ptp = of_property_match_string(pdev->dev.of_node, >>> + "clock-names", "ptp_ref") < 0; >>> + >>> + for (i = 0; i < ARRAY_SIZE(mgbe_clks); i++) { >>> mgbe->clks[i].id = mgbe_clks[i]; >>> >>> + if (use_legacy_ptp && !strcmp(mgbe_clks[i], "ptp_ref")) { >> >> Why index 0 is not valid? And why -EINVAL would be considered as legacy >> clock present? > > Index 0 is valid. However, yes I guess that treating an -EINVAL from > of_property_match_string() is not correct. I will switch the logic to be ... > > use_legacy_ptp = of_property_match_string(pdev->dev.of_node, > "clock-names", "ptp-ref") >= 0; No, apologies, I think my comment was not correct and your reply made me rethink. I missed final "< 0" in of_property_match_string(). So the code is good, you do not store index in 'use_legacy_ptp', but the error return value. Can you however make it more obvious code, so something like: if (of_property_match_string...)) use_legacy_ptp = true;; Best regards, Krzysztof