From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Jaewon Kim" <jaewon02.kim@samsung.com>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>
Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible
Date: Mon, 17 Jul 2023 14:22:58 +0200 [thread overview]
Message-ID: <5b5299b6-a0b9-2ece-6c8c-5374ec18cd1c@linaro.org> (raw)
In-Reply-To: <68aacadd-f27d-76d3-36a1-78f5662ecb97@samsung.com>
On 17/07/2023 13:26, Jaewon Kim wrote:
>
> On 23. 7. 17. 19:59, Krzysztof Kozlowski wrote:
>> On 17/07/2023 11:42, Jaewon Kim wrote:
>>> Add samsung,exynosautov9-pwm compatible string to binding document.
>>>
>>> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com>
>>> ---
>>> .../devicetree/bindings/pwm/pwm-samsung.yaml | 16 ++++++++++------
>>> 1 file changed, 10 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>>> index fe603fb1b2cc..6f65e2b52f52 100644
>>> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>>> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml
>>> @@ -20,12 +20,16 @@ description: |+
>>>
>>> properties:
>>> compatible:
>>> - enum:
>>> - - samsung,s3c2410-pwm # 16-bit, S3C24xx
>>> - - samsung,s3c6400-pwm # 32-bit, S3C64xx
>>> - - samsung,s5p6440-pwm # 32-bit, S5P64x0
>>> - - samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs
>>> - - samsung,exynos4210-pwm # 32-bit, Exynos
>>> + oneOf:
>>> + - const: samsung,s3c2410-pwm # 16-bit
>>> + - const: samsung,s3c6400-pwm # 32-bit, S3C64xx
>>> + - const: samsung,s5p6440-pwm # 32-bit, S5P64x0
>>> + - const: samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs
>>> + - const: samsung,exynos4210-pwm # 32-bit, Exynos
>> These are still an enum.
> Okay I will change const to enum.
>>
>>> + - items:
>>> + - enum:
>>> + - samsung,exynosautov9-pwm # 32-bit, ExynosAutov9
>> Let's drop the comment?
>
> Should I just delete this comment or delete all comments in the
> enum(16-bit,S3C24xx, .....).
No, the other can stay. Here it is redundant, since Autov9 is obvious -
comes from compatible - and rest is coming from compatibility with older
models.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-17 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230717094721epcas2p238ffd2f218899dc3c43f3fe68a079c54@epcas2p2.samsung.com>
2023-07-17 9:42 ` [PATCH v4 0/2] support PWM for exynosautov9 Jaewon Kim
[not found] ` <CGME20230717094721epcas2p1c5c1254e24d4a1d0fb366e1b4d551536@epcas2p1.samsung.com>
2023-07-17 9:42 ` [PATCH v4 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible Jaewon Kim
2023-07-17 10:59 ` Krzysztof Kozlowski
2023-07-17 11:26 ` Jaewon Kim
2023-07-17 12:22 ` Krzysztof Kozlowski [this message]
[not found] ` <CGME20230717094722epcas2p4408dc5ab0aca55e1da1a9eafdd3486f7@epcas2p4.samsung.com>
2023-07-17 9:42 ` [PATCH v4 2/2] arm64: dts: exynos: add pwm node for exynosautov9-sadk Jaewon Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b5299b6-a0b9-2ece-6c8c-5374ec18cd1c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jaewon02.kim@samsung.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).