From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40BC5C001DC for ; Mon, 17 Jul 2023 12:23:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229471AbjGQMXF (ORCPT ); Mon, 17 Jul 2023 08:23:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229659AbjGQMXE (ORCPT ); Mon, 17 Jul 2023 08:23:04 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D90E8E1 for ; Mon, 17 Jul 2023 05:23:02 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id a640c23a62f3a-98e39784a85so1187164466b.1 for ; Mon, 17 Jul 2023 05:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689596581; x=1692188581; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2vhwu1zp3S5PiRdDu32pUjkHXYPNpSh6XO9BtN9Bqmk=; b=x8Kpuu7atosaYgXr1dMB4cVtN0RBwRi9X2gwVon76DSiXtTX2vvl23/e5Svst2LMSL ixVyWJ/mvM/mxMBMFHgiGZuxaXrxuce+QMW3iFsWK/5UHiLWpPvQ30p2fPuXezclwT5u JwQ9JD+HZhA24SSm73STxLXKlzHYSGgSDoXy7pemnb7O2TCa/HkDGYY+Mu9SVen1VfHJ R2T80S64RwZy9CXAlDjxrDJzVxxQuPSWzhFeDlrqIJoVxpqeSVssAbIhDRcsYgPmviyO /+2IHLKIEd4GFmKMwaJBHMZvV1G8BNagDL4NRvHx+PO5KQnBlcJQ11fFwvvybNrFxVEs fxNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689596581; x=1692188581; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2vhwu1zp3S5PiRdDu32pUjkHXYPNpSh6XO9BtN9Bqmk=; b=Jp22C7DFgRLaxxw3lszKdrNXwXC62yVkhWaSf94V5l7bPNB2y7NxgaHH7mfQWs6UPv 6SsO5uArOJZZi3I+qRseZkk5u1NkaSV00ny6B+n4JEbTQhnJfajGH0XT9b1i7Enp+P+X 7/43rMev1ZgMI+4Yu38AZW/PzMB7sg6AFaIeh7gcEiRewlQXDHf83Sk6NFlJCQgJ2baa /O9pvkbKD2UT3lvxF/wqeCag/ZRTKYt5JevBIthTo1aEOXDeEw6sw1f4hRRneYF7Va0S YWjltHLAxTEDTjKeOkIQRouZ/HzuEwj2Cao9aD6wz2ENB22+AzemhTDYkiFOsa2DNm5f G8fw== X-Gm-Message-State: ABy/qLZKuKrq4SlvOSk7EubhV9E1DxtP+9VzvxG4EV/mK8jpS2uANEiv aNt/fH5O6HIiUaHd5KM10cztTA== X-Google-Smtp-Source: APBJJlHPBiZufczBjnjB/8OgazGqsfTjzsPvN3r4urbCM8aFAGsuynBEWcPDR8TS01nu7v5Oot8HmA== X-Received: by 2002:a17:906:2d1:b0:994:5457:269e with SMTP id 17-20020a17090602d100b009945457269emr9126055ejk.0.1689596581219; Mon, 17 Jul 2023 05:23:01 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id y27-20020a1709063a9b00b00992ca779f42sm9171089ejd.97.2023.07.17.05.22.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jul 2023 05:23:00 -0700 (PDT) Message-ID: <5b5299b6-a0b9-2ece-6c8c-5374ec18cd1c@linaro.org> Date: Mon, 17 Jul 2023 14:22:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 1/2] dt-bindings: pwm: samsung: add exynosautov9 compatible Content-Language: en-US To: Jaewon Kim , Thierry Reding , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar Cc: linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org References: <20230717094202.18296-1-jaewon02.kim@samsung.com> <20230717094202.18296-2-jaewon02.kim@samsung.com> <9b09afec-4e0e-a600-92e1-2104a1b2e36e@linaro.org> <68aacadd-f27d-76d3-36a1-78f5662ecb97@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <68aacadd-f27d-76d3-36a1-78f5662ecb97@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/07/2023 13:26, Jaewon Kim wrote: > > On 23. 7. 17. 19:59, Krzysztof Kozlowski wrote: >> On 17/07/2023 11:42, Jaewon Kim wrote: >>> Add samsung,exynosautov9-pwm compatible string to binding document. >>> >>> Signed-off-by: Jaewon Kim >>> --- >>> .../devicetree/bindings/pwm/pwm-samsung.yaml | 16 ++++++++++------ >>> 1 file changed, 10 insertions(+), 6 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >>> index fe603fb1b2cc..6f65e2b52f52 100644 >>> --- a/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >>> +++ b/Documentation/devicetree/bindings/pwm/pwm-samsung.yaml >>> @@ -20,12 +20,16 @@ description: |+ >>> >>> properties: >>> compatible: >>> - enum: >>> - - samsung,s3c2410-pwm # 16-bit, S3C24xx >>> - - samsung,s3c6400-pwm # 32-bit, S3C64xx >>> - - samsung,s5p6440-pwm # 32-bit, S5P64x0 >>> - - samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs >>> - - samsung,exynos4210-pwm # 32-bit, Exynos >>> + oneOf: >>> + - const: samsung,s3c2410-pwm # 16-bit >>> + - const: samsung,s3c6400-pwm # 32-bit, S3C64xx >>> + - const: samsung,s5p6440-pwm # 32-bit, S5P64x0 >>> + - const: samsung,s5pc100-pwm # 32-bit, S5PC100, S5PV210, Exynos4210 rev0 SoCs >>> + - const: samsung,exynos4210-pwm # 32-bit, Exynos >> These are still an enum. > Okay I will change const to enum. >> >>> + - items: >>> + - enum: >>> + - samsung,exynosautov9-pwm # 32-bit, ExynosAutov9 >> Let's drop the comment? > > Should I just delete this comment or delete all comments in the > enum(16-bit,S3C24xx, .....). No, the other can stay. Here it is redundant, since Autov9 is obvious - comes from compatible - and rest is coming from compatibility with older models. Best regards, Krzysztof