From: Rob Herring <robh@kernel.org>
To: krzk@kernel.org
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Javier Martinez Canillas <javier@dowhile0.org>,
Sangbeom Kim <sbkim73@samsung.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] regulator: maxim: Add SPDX license identifiers
Date: Thu, 09 Aug 2018 16:41:34 -0600 [thread overview]
Message-ID: <5b6cc31f.1c69fb81.183a5.f380@mx.google.com> (raw)
In-Reply-To: <20180807161826.2222-1-krzk@kernel.org>
Hi, this is an automated email from Rob's (experimental) review bot. I
found a couple of common problems with your patch. Please see below.
On Tue, 7 Aug 2018 18:18:25 +0200, Krzysztof Kozlowski wrote:
> Replace GPL v2.0 and v2.0+ license statements with SPDX license
> identifiers.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
> drivers/regulator/max14577-regulator.c | 22 +++++------------
> drivers/regulator/max77686-regulator.c | 32 +++++++-----------------
> drivers/regulator/max77693-regulator.c | 32 +++++++-----------------
> drivers/regulator/max77802-regulator.c | 34 +++++++++-----------------
> drivers/regulator/max8997-regulator.c | 30 ++++++-----------------
> drivers/regulator/max8998.c | 28 ++++++---------------
> include/dt-bindings/regulator/maxim,max77802.h | 5 +---
> 7 files changed, 52 insertions(+), 131 deletions(-)
>
DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.
next prev parent reply other threads:[~2018-08-09 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 16:18 [PATCH 1/2] regulator: maxim: Add SPDX license identifiers Krzysztof Kozlowski
2018-08-07 16:18 ` [PATCH 2/2] regulator: samsung: " Krzysztof Kozlowski
2018-08-09 22:41 ` Rob Herring [this message]
2018-08-14 20:39 ` [PATCH 1/2] regulator: maxim: " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b6cc31f.1c69fb81.183a5.f380@mx.google.com \
--to=robh@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@dowhile0.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).