Devicetree
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@mailbox.org>
To: Sai Krishna Gajula <saikrishnag@marvell.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Aleksander Jan Bajkowski <olek2@wp.pl>,
	Andrew Lunn <andrew@lunn.ch>, Conor Dooley <conor+dt@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Ivan Galkin <ivan.galkin@axis.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Michael Klein <michael@fossekall.de>,
	Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [net-next,PATCH v2 3/3] net: phy: realtek: Add property to enable SSC
Date: Thu, 18 Dec 2025 18:33:02 +0100	[thread overview]
Message-ID: <5b6cdd76-30a7-49be-8ccf-b90ede78b15a@mailbox.org> (raw)
In-Reply-To: <BY3PR18MB47076A26714A7AC5A34D7F32A0A1A@BY3PR18MB4707.namprd18.prod.outlook.com>

On 12/11/25 7:39 PM, Sai Krishna Gajula wrote:

[...]

>> +	ret = phy_write_paged(phydev, RTL8211F_SSC_PAGE,
>> RTL8211F_SSC_RXC, 0x5f00);
>> +	if (ret < 0) {
>> +		dev_err(dev, "RXC SCC configuration failed: %pe\n",
>> ERR_PTR(ret));
>> +		return ret;
>> +	}
>> +
>> +	return 0;
>> +}
>> +
>> +static int rtl8211f_config_sysclk_ssc(struct phy_device *phydev) {
> 
> Minor nit:   Kernel style requires the opening brace on the next line, also in other places.
> static int rtl8211f_config_sysclk_ssc(struct phy_device *phydev)
> {
The patch looks correctly in lore archive, see:

https://lore.kernel.org/all/20251203210857.113328-3-marek.vasut@mailbox.org/

The patch also looks correctly in my mailer, it is only the 
aforementioned quoted text that seems mangled. Maybe your mailer did 
something odd with the patch ?

  reply	other threads:[~2025-12-18 17:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-03 21:08 [net-next,PATCH v2 1/3] dt-bindings: net: realtek,rtl82xx: Keep property list sorted Marek Vasut
2025-12-03 21:08 ` [net-next,PATCH v2 2/3] dt-bindings: net: realtek,rtl82xx: Document realtek,ssc-enable property Marek Vasut
2025-12-05  9:04   ` Krzysztof Kozlowski
2025-12-18 17:20     ` Marek Vasut
2025-12-03 21:08 ` [net-next,PATCH v2 3/3] net: phy: realtek: Add property to enable SSC Marek Vasut
2025-12-04 14:27   ` Ivan Galkin
2025-12-11 18:39   ` Sai Krishna Gajula
2025-12-18 17:33     ` Marek Vasut [this message]
2025-12-04 11:04 ` [net-next,PATCH v2 1/3] dt-bindings: net: realtek,rtl82xx: Keep property list sorted Paolo Abeni
2025-12-05  9:03 ` Krzysztof Kozlowski
2025-12-18 17:11   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b6cdd76-30a7-49be-8ccf-b90ede78b15a@mailbox.org \
    --to=marek.vasut@mailbox.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=ivan.galkin@axis.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=michael@fossekall.de \
    --cc=netdev@vger.kernel.org \
    --cc=olek2@wp.pl \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    --cc=saikrishnag@marvell.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox