From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Johan Hovold <johan@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 16/43] dt-bindings: phy: qcom,qmp-pcie: drop unused vddp-ref-clk supply
Date: Tue, 5 Jul 2022 20:13:55 +0200 [thread overview]
Message-ID: <5b6f5e15-f3fd-badb-3ada-eb2f58053857@linaro.org> (raw)
In-Reply-To: <YsQx1SMEsMnmoQ2d@hovoldconsulting.com>
On 05/07/2022 14:43, Johan Hovold wrote:
> On Tue, Jul 05, 2022 at 01:59:26PM +0200, Krzysztof Kozlowski wrote:
>> On 05/07/2022 13:46, Johan Hovold wrote:
>>>> It's okay to copy existing bindings which are applicable and then in
>>>> separate patch deprecate things or remove pieces which are not correct.
>>>> But all this in assumption that the first copy already selected only
>>>> applicable parts.
>>>
>>> But how would you be able to tell what parts I left out from the
>>> original copy
>>
>> They are obvious and immediately visible. I see old bindings and new
>> bindings - no troubles to compare. I review new bindings - everything in
>> place.
>
> Heh, with all these conditionals in place that may be harder than it
> sounds.
True and your patchset split does not make it easier.
>
>> I don't want to review old code, inapplicable code. The patch I am
>> reviewing (the one doing the split) must bring correct bindings, except
>> these few differences like deprecated stuff.
>
> Sure, I get that. But this very patch is an example of why I tried to
> remove things explicitly instead folding this into the original patch
> and risking it not being noticed.
>
> It's not always obvious what is applicable and what is not, especially
> when the old schema is in the state it is.
Unless bindings are very precise, usually it's not visible what is
applicable or not, so there is just no benefit in multi-step approach in
split from old bindings. The same as with conversion of bindings, the
assumption is that original file was not correct, so we review the final
file.
>
>>> unless I first do the split and then explicitly remove
>>> things that were presumably *never* applicable and just happened to be
>>> added because all bindings where combined in one large mess of a schema?
>
> So you suggest we keep this regulator for all PHY variants even though
> it was probably only needed for UFS on some older SoCs?
No. I commented only that reason is not a good one. The proper reason
could be: there is or there is no such pin in the device or the history
tells that adding it for all variants was a mistake.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-05 18:14 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 9:41 [PATCH 00/43] phy: qcom,qmp: fix dt-bindings and deprecate lane suffix Johan Hovold
2022-07-05 9:41 ` [PATCH 01/43] dt-bindings: phy: qcom,qmp: fix bogus clock-cells property Johan Hovold
2022-07-05 10:01 ` Krzysztof Kozlowski
2022-07-05 9:41 ` [PATCH 02/43] dt-bindings: phy: qcom,qmp: sort compatible strings Johan Hovold
2022-07-05 10:02 ` Krzysztof Kozlowski
2022-07-05 9:41 ` [PATCH 03/43] dt-bindings: phy: qcom,qmp: clean up descriptions Johan Hovold
2022-07-05 10:02 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 04/43] dt-bindings: phy: qcom,qmp: clean up example Johan Hovold
2022-07-05 10:03 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 05/43] dt-bindings: phy: qcom,qmp: drop child-node comment Johan Hovold
2022-07-05 10:03 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 06/43] dt-bindings: phy: qcom,qmp: split out msm8996-qmp-pcie-phy Johan Hovold
2022-07-05 10:08 ` Krzysztof Kozlowski
2022-07-05 10:20 ` Johan Hovold
2022-07-05 10:23 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 07/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: clean up constraints Johan Hovold
2022-07-05 10:09 ` Krzysztof Kozlowski
2022-07-05 10:21 ` Johan Hovold
2022-07-05 10:23 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 08/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: add missing child node schema Johan Hovold
2022-07-05 10:10 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 09/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: add example node Johan Hovold
2022-07-05 10:10 ` Krzysztof Kozlowski
2022-07-05 10:22 ` Johan Hovold
2022-07-05 11:32 ` Krzysztof Kozlowski
2022-07-05 12:00 ` Johan Hovold
2022-07-05 9:42 ` [PATCH 10/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate PIPE clock names Johan Hovold
2022-07-05 10:10 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 11/43] dt-bindings: phy: qcom,msm8996-qmp-pcie: deprecate reset names Johan Hovold
2022-07-05 10:12 ` Krzysztof Kozlowski
2022-07-05 12:14 ` Johan Hovold
2022-07-05 9:42 ` [PATCH 12/43] dt-bindings: phy: qcom,qmp: split out PCIe PHY binding Johan Hovold
2022-07-05 10:13 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 13/43] dt-bindings: phy: qcom,qmp-pcie: clean up register constraints Johan Hovold
2022-07-05 10:13 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 14/43] dt-bindings: phy: qcom,qmp-pcie: clean up clock constraints Johan Hovold
2022-07-05 10:14 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 15/43] dt-bindings: phy: qcom,qmp-pcie: clean up reset constraints Johan Hovold
2022-07-05 10:14 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 16/43] dt-bindings: phy: qcom,qmp-pcie: drop unused vddp-ref-clk supply Johan Hovold
2022-07-05 10:16 ` Krzysztof Kozlowski
2022-07-05 11:46 ` Johan Hovold
2022-07-05 11:59 ` Krzysztof Kozlowski
2022-07-05 12:43 ` Johan Hovold
2022-07-05 18:13 ` Krzysztof Kozlowski [this message]
2022-07-06 6:03 ` Johan Hovold
2022-07-05 9:42 ` [PATCH 17/43] dt-bindings: phy: qcom,qmp-pcie: add missing child node schema Johan Hovold
2022-07-05 10:18 ` Krzysztof Kozlowski
2022-07-05 11:51 ` Johan Hovold
2022-07-05 11:56 ` Krzysztof Kozlowski
2022-07-05 12:11 ` Johan Hovold
2022-07-05 18:21 ` Krzysztof Kozlowski
2022-07-06 6:06 ` Johan Hovold
2022-07-05 14:14 ` Rob Herring
2022-07-05 9:42 ` [PATCH 18/43] dt-bindings: phy: qcom,qmp-pcie: add example node Johan Hovold
2022-07-05 10:18 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 19/43] dt-bindings: phy: qcom,qmp-pcie: deprecate PIPE clock name Johan Hovold
2022-07-05 9:42 ` [PATCH 20/43] dt-bindings: phy: qcom,qmp: split out UFS PHY binding Johan Hovold
2022-07-05 10:19 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 21/43] dt-bindings: phy: qcom,qmp-ufs: clean up supplies Johan Hovold
2022-07-05 9:42 ` [PATCH 22/43] dt-bindings: phy: qcom,qmp-ufs: clean up reset providers Johan Hovold
2022-07-05 9:42 ` [PATCH 23/43] dt-bindings: phy: qcom,qmp-ufs: clean up clock constraints Johan Hovold
2022-07-05 9:42 ` [PATCH 24/43] dt-bindings: phy: qcom,qmp-ufs: clean up register constraints Johan Hovold
2022-07-05 9:42 ` [PATCH 25/43] dt-bindings: phy: qcom,qmp-ufs: add missing SM8450 clock Johan Hovold
2022-07-05 9:42 ` [PATCH 26/43] dt-bindings: phy: qcom,qmp-ufs: add missing SM8150 power domain Johan Hovold
2022-07-05 9:42 ` [PATCH 27/43] dt-bindings: phy: qcom,qmp-ufs: add missing child node schema Johan Hovold
2022-07-05 9:42 ` [PATCH 28/43] dt-bindings: phy: qcom,qmp-ufs: add example node Johan Hovold
2022-07-05 9:42 ` [PATCH 29/43] dt-bindings: phy: qcom,qmp: split out USB binding Johan Hovold
2022-07-05 9:42 ` [PATCH 30/43] dt-bindings: phy: qcom,qmp-usb: clean up clock constraints Johan Hovold
2022-07-05 9:42 ` [PATCH 31/43] dt-bindings: phy: qcom,qmp-usb: clean up supplies Johan Hovold
2022-07-05 9:42 ` [PATCH 32/43] dt-bindings: phy: qcom,qmp-usb: drop unused vddp-ref-clk supply Johan Hovold
2022-07-05 9:42 ` [PATCH 33/43] dt-bindings: phy: qcom,qmp-usb: clean up reset providers Johan Hovold
2022-07-05 9:42 ` [PATCH 34/43] dt-bindings: phy: qcom,qmp-usb: add missing child node schema Johan Hovold
2022-07-05 9:42 ` [PATCH 35/43] dt-bindings: phy: qcom,qmp-usb: deprecate PIPE clock name Johan Hovold
2022-07-05 9:42 ` [PATCH 36/43] dt-bindings: phy: qcom,qmp-usb3-dp: fix bogus clock-cells property Johan Hovold
2022-07-05 9:42 ` [PATCH 37/43] dt-bindings: phy: qcom,qmp-usb3-dp: deprecate USB PIPE clock name Johan Hovold
2022-07-05 9:42 ` [PATCH 38/43] phy: qcom-qmp-pcie: drop pipe clock lane suffix Johan Hovold
2022-07-05 10:20 ` Krzysztof Kozlowski
2022-07-05 11:13 ` Dmitry Baryshkov
2022-07-05 11:58 ` Johan Hovold
2022-07-05 12:06 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 39/43] phy: qcom-qmp-combo: drop unused lane reset Johan Hovold
2022-07-05 11:10 ` Dmitry Baryshkov
2022-07-05 9:42 ` [PATCH 40/43] phy: qcom-qmp-combo: drop pipe clock lane suffix Johan Hovold
2022-07-05 10:20 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 41/43] phy: qcom-qmp-pcie-msm8996: " Johan Hovold
2022-07-05 9:42 ` [PATCH 42/43] phy: qcom-qmp-pcie-msm8996: drop reset " Johan Hovold
2022-07-05 10:21 ` Krzysztof Kozlowski
2022-07-05 9:42 ` [PATCH 43/43] phy: qcom-qmp-usb: drop pipe clock " Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b6f5e15-f3fd-badb-3ada-eb2f58053857@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).