devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: E Shattow <e@freeshell.de>
To: "Hal Feng" <hal.feng@starfivetech.com>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Paul Walmsley" <pjw@kernel.org>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Emil Renner Berthing" <emil.renner.berthing@canonical.com>,
	"Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/8] riscv: dts: starfive: jh711x-common: Move out some nodes to jh7110 common dtsi
Date: Fri, 7 Nov 2025 03:24:24 -0800	[thread overview]
Message-ID: <5b7c7ecc-38db-483b-87fc-4199a8bd52c3@freeshell.de> (raw)
In-Reply-To: <20251107095530.114775-6-hal.feng@starfivetech.com>



On 11/7/25 01:55, Hal Feng wrote:
> Some nodes in this file are not used by the upcoming VisionFive 2 Lite
> board. Move them to the jh7110 common dtsi to prepare for adding the
> new VisionFive 2 Lite device tree.
> 
> Signed-off-by: Hal Feng <hal.feng@starfivetech.com>
> ---
>  arch/riscv/boot/dts/starfive/jh7110-common.dtsi | 14 ++++++++++++++
>  arch/riscv/boot/dts/starfive/jh711x-common.dtsi |  8 --------
>  2 files changed, 14 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> index dd5805ef70a1..cdc362b8d58b 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh7110-common.dtsi
> @@ -25,3 +25,17 @@ opp-1500000000 {
>  		opp-microvolt = <1040000>;
>  	};
>  };
> +
> +&mmc0 {
> +	cap-mmc-highspeed;
> +	cap-mmc-hw-reset;
> +	mmc-ddr-1_8v;
> +	mmc-hs200-1_8v;
> +	vmmc-supply = <&vcc_3v3>;
> +	vqmmc-supply = <&emmc_vdd>;
> +};
> +
> +&mmc1 {
> +	cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>;
> +	disable-wp;
> +};
> diff --git a/arch/riscv/boot/dts/starfive/jh711x-common.dtsi b/arch/riscv/boot/dts/starfive/jh711x-common.dtsi
> index 809274625615..42b8f60725fb 100644
> --- a/arch/riscv/boot/dts/starfive/jh711x-common.dtsi
> +++ b/arch/riscv/boot/dts/starfive/jh711x-common.dtsi
> @@ -281,14 +281,8 @@ &mmc0 {
>  	assigned-clock-rates = <50000000>;
>  	bus-width = <8>;
>  	bootph-pre-ram;
> -	cap-mmc-highspeed;
> -	mmc-ddr-1_8v;
> -	mmc-hs200-1_8v;
> -	cap-mmc-hw-reset;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&mmc0_pins>;
> -	vmmc-supply = <&vcc_3v3>;
> -	vqmmc-supply = <&emmc_vdd>;
>  	status = "okay";
>  };
>  
> @@ -298,8 +292,6 @@ &mmc1 {
>  	assigned-clock-rates = <50000000>;
>  	bus-width = <4>;
>  	bootph-pre-ram;
> -	cd-gpios = <&sysgpio 41 GPIO_ACTIVE_LOW>;
> -	disable-wp;
>  	cap-sd-highspeed;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&mmc1_pins>;

Reviewed-by: E Shattow <e@freeshell.de>

  reply	other threads:[~2025-11-07 11:24 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07  9:55 [PATCH v2 0/8] Add support for StarFive VisionFive 2 Lite board Hal Feng
2025-11-07  9:55 ` [PATCH v2 1/8] dt-bindings: PCI: starfive,jh7110-pcie: Add enable-gpios property Hal Feng
2025-11-07  9:55 ` [PATCH v2 2/8] dt-bindings: riscv: Add StarFive JH7110S SoC and VisionFive 2 Lite board Hal Feng
2025-11-07  9:55 ` [PATCH v2 3/8] riscv: dts: starfive: Rename jh7110.dtsi to jh711x.dtsi Hal Feng
2025-11-07 11:18   ` E Shattow
2025-11-07  9:55 ` [PATCH v2 4/8] riscv: dts: starfive: Split jh7110-common.dtsi and move opp table to it Hal Feng
2025-11-07 11:20   ` E Shattow
2025-11-18 15:12   ` Heinrich Schuchardt
2025-11-07  9:55 ` [PATCH v2 5/8] riscv: dts: starfive: jh711x-common: Move out some nodes to jh7110 common dtsi Hal Feng
2025-11-07 11:24   ` E Shattow [this message]
2025-11-07  9:55 ` [PATCH v2 6/8] riscv: dts: starfive: Add common board dtsi for JH7110s and VisionFive 2 Lite variants Hal Feng
2025-11-07  9:55 ` [PATCH v2 7/8] riscv: dts: starfive: Add VisionFive 2 Lite board device tree Hal Feng
2025-11-07  9:55 ` [PATCH v2 8/8] riscv: dts: starfive: Add VisionFive 2 Lite eMMC " Hal Feng
2025-11-07 11:11 ` [PATCH v2 0/8] Add support for StarFive VisionFive 2 Lite board E Shattow
2025-11-07 11:21   ` Heinrich Schuchardt
2025-11-07 12:01     ` E Shattow
2025-11-12  7:24       ` Hal Feng
2025-11-12 13:29         ` E Shattow
2025-11-07 17:20     ` Conor Dooley
2025-11-12  7:47       ` Hal Feng
2025-11-12 13:54 ` Emil Renner Berthing
2025-11-12 14:36   ` Conor Dooley
2025-11-13  3:42   ` Hal Feng
2025-11-13 10:42     ` Emil Renner Berthing
2025-11-13 15:16       ` E Shattow
2025-11-15 16:28         ` Emil Renner Berthing
2025-11-17  6:54           ` Hal Feng
2025-11-17 21:54             ` E Shattow
2025-11-18  2:12               ` Hal Feng
2025-11-18 23:10                 ` Conor Dooley
2025-11-19  7:04                   ` Heinrich Schuchardt
2025-11-19  8:26                     ` E Shattow
2025-11-19 13:27                   ` Emil Renner Berthing
2025-11-20  0:47                     ` Conor Dooley
2025-11-20  2:47                       ` Hal Feng
2025-11-20  2:38                     ` Hal Feng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b7c7ecc-38db-483b-87fc-4199a8bd52c3@freeshell.de \
    --to=e@freeshell.de \
    --cc=aou@eecs.berkeley.edu \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=emil.renner.berthing@canonical.com \
    --cc=hal.feng@starfivetech.com \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=krzk+dt@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).