devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jim Liu <jim.t90615@gmail.com>, Linus Walleij <linus.walleij@linaro.org>
Cc: JJLIU0@nuvoton.com, KWLIU@nuvoton.com, brgl@bgdev.pl,
	robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH v2 3/3] dt-bindings: gpio: Add Nuvoton NPCM750 serial I/O expansion interface(SGPIO)
Date: Tue, 15 Nov 2022 10:55:33 +0100	[thread overview]
Message-ID: <5b7f035c-807b-a6d4-30ec-e5467ff4ea47@linaro.org> (raw)
In-Reply-To: <CAKUZ0+Hy5suFg9VZ8-+cH7kGc5KLqUnf9hjnT+iaw+a1HF8x0A@mail.gmail.com>

On 14/11/2022 09:38, Jim Liu wrote:
> Hi Linus
> 
> Thanks for your reply.
> 
> let me explain the gpio pin as below:
> 
> Our sgpio module has 64 pins output and 64 pins input.
> Soc have 8 reg to control 64 output pins
> and  8 reg to control 64 input pins.
> so the pin is only for gpi or gpo.
> 
> The common property ngpio can be out or in.
> so i need to create d_out and d_in to control it.
> customers can set the number of output or input pins to use.

Aren't customers interested in specific pins, not the number? IOW, why
do you assume pins should be set to output in ascending order (e.g. 1, 2
and 3) and not in a flexible way?

> the driver will open the ports to use.
> ex: if  i set d_out=9   and d_in=20

Why 20 means three input ports? 9 opening two outputs could have sense
if it was a mask but you did not say it is a mask.



Best regards,
Krzysztof


      parent reply	other threads:[~2022-11-15  9:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08  9:28 [PATCH v2 0/3] Support Nuvoton NPCM750 SGPIO Jim Liu
2022-11-08  9:28 ` [PATCH v2 1/3] gpio:gpio-npcm-sgpio: Add Nuvoton sgpio driver Jim Liu
2022-11-08 13:02   ` Linus Walleij
2022-11-08 18:17   ` kernel test robot
2022-11-12 22:52   ` kernel test robot
2022-11-08  9:28 ` [PATCH v2 2/3] arm: dts: nuvoton: npcm7xx: add sgpio node Jim Liu
2022-11-08 15:24   ` Krzysztof Kozlowski
2022-11-08  9:28 ` [PATCH v2 3/3] dt-bindings: gpio: Add Nuvoton NPCM750 serial I/O expansion interface(SGPIO) Jim Liu
2022-11-08 12:54   ` Rob Herring
2022-11-08 12:59   ` Linus Walleij
2022-11-08 15:21   ` Krzysztof Kozlowski
2022-11-09  9:14   ` Linus Walleij
2022-11-11  9:30     ` Jim Liu
2022-11-11 14:20       ` Linus Walleij
2022-11-14  8:38         ` Jim Liu
2022-11-14 10:13           ` Linus Walleij
2022-11-15  9:21             ` Jim Liu
2022-11-15  9:58               ` Krzysztof Kozlowski
2022-11-16  7:57                 ` Jim Liu
2022-11-15  9:55           ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b7f035c-807b-a6d4-30ec-e5467ff4ea47@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=JJLIU0@nuvoton.com \
    --cc=KWLIU@nuvoton.com \
    --cc=brgl@bgdev.pl \
    --cc=devicetree@vger.kernel.org \
    --cc=jim.t90615@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).