From mboxrd@z Thu Jan 1 00:00:00 1970 From: shuah Subject: Re: [PATCH v13 00/18] kunit: introduce KUnit, the Linux kernel unit testing framework Date: Tue, 20 Aug 2019 11:24:45 -0600 Message-ID: <5b880f49-0213-1a6e-9c9f-153e6ab91eeb@kernel.org> References: <20190814055108.214253-1-brendanhiggins@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190814055108.214253-1-brendanhiggins@google.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Brendan Higgins , frowand.list@gmail.com, gregkh@linuxfoundation.org, jpoimboe@redhat.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, peterz@infradead.org, robh@kernel.org, sboyd@kernel.org, tytso@mit.edu, yamada.masahiro@socionext.com Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, Tim.Bird@sony.com, amir73il@gmail.com, dan.carpenter@oracle.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, mpe@ellerman.id.au, pmladek@suse.com, rdunlap@infradead.org, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com, Bjorn Helgaas , shuah List-Id: devicetree@vger.kernel.org On 8/13/19 11:50 PM, Brendan Higgins wrote: > ## TL;DR > > This revision addresses comments from Stephen and Bjorn Helgaas. Most > changes are pretty minor stuff that doesn't affect the API in anyway. > One significant change, however, is that I added support for freeing > kunit_resource managed resources before the test case is finished via > kunit_resource_destroy(). Additionally, Bjorn pointed out that I broke > KUnit on certain configurations (like the default one for x86, whoops). > > Based on Stephen's feedback on the previous change, I think we are > pretty close. I am not expecting any significant changes from here on > out. > Hi Brendan, I found checkpatch errors in one or two patches. Can you fix those and send v14. thanks, -- Shuah