devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Urja Rannikko <urjaman@gmail.com>
Cc: devicetree@vger.kernel.org, heiko@sntech.de,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] dt-bindings: clock: rk3288-cru: Add property to dedicate NPLL for VOPx
Date: Mon, 3 Sep 2018 19:31:59 -0500	[thread overview]
Message-ID: <5b8e8a5a.1c69fb81.1c56d.877e@mx.google.com> (raw)
In-Reply-To: <20180828185513.13216-3-urjaman@gmail.com>

On Tue, Aug 28, 2018 at 06:55:08PM +0000, Urja Rannikko wrote:
> Signed-off-by: Urja Rannikko <urjaman@gmail.com>
> ---
>  .../devicetree/bindings/clock/rockchip,rk3288-cru.txt          | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3288-cru.txt b/Documentation/devicetree/bindings/clock/rockchip,rk3288-cru.txt
> index 8cb47c39ba53..20724584e0a4 100644
> --- a/Documentation/devicetree/bindings/clock/rockchip,rk3288-cru.txt
> +++ b/Documentation/devicetree/bindings/clock/rockchip,rk3288-cru.txt
> @@ -16,6 +16,9 @@ Optional Properties:
>  
>  - rockchip,grf: phandle to the syscon managing the "general register files"
>    If missing pll rates are not changeable, due to the missing pll lock status.
> +- rockchip,npll-for-vop: u32 0 or 1, dedicates NPLL to a VOP output unit for
> +  more frequency flexibility for the selected VOP output at a cost of
> +  flexibility for other devices. Disabled if not present or -1.

It can't be a u32 and negative. Just drop the "or -1" part.


>  
>  Each clock is assigned an identifier and client nodes can use this identifier
>  to specify the clock which they consume. All available clocks are defined as
> -- 
> 2.18.0
> 

  reply	other threads:[~2018-09-04  0:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-28 18:55 [PATCH 0/7] [RFC] rk3288 veyron chromebook hdmi frequencies Urja Rannikko
2018-08-28 18:55 ` [PATCH 1/7] clk: rockchip: improve rk3288 pll rates for better hdmi output Urja Rannikko
2018-08-31  8:05   ` Heiko Stübner
2018-08-28 18:55 ` [PATCH 2/7] dt-bindings: clock: rk3288-cru: Add property to dedicate NPLL for VOPx Urja Rannikko
2018-09-04  0:31   ` Rob Herring [this message]
2018-08-28 18:55 ` [PATCH 3/7] drivers: clk-rk3288: support for dedicating NPLL to a VOP Urja Rannikko
2018-08-28 18:55 ` [PATCH 4/7] dt-bindings: display/rockchip: dw_hdmi: Add property for HDMI frequency list Urja Rannikko
2018-09-04  0:34   ` Rob Herring
2018-08-28 18:55 ` [PATCH 5/7] drm: dw_hdmi-rockchip: better clock selection logic and dts-based rate list Urja Rannikko
2018-08-28 18:55 ` [PATCH 6/7] dts: rk3288: support for dedicating npll to a vop Urja Rannikko
2018-08-28 18:55 ` [PATCH 7/7] dts: rk3288-veyron-chromebook: dedicate npll to VOP0/HDMI + HDMI rates Urja Rannikko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b8e8a5a.1c69fb81.1c56d.877e@mx.google.com \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=urjaman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).