devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	Grant Likely <grant.likely@secretlab.ca>,
	Kumar Gala <galak@kernel.crashing.org>
Subject: Re: [PATCH] gpio: OF: Cut painful BNF experiments from bindings
Date: Sun, 16 Sep 2018 22:44:07 -0500	[thread overview]
Message-ID: <5b9f3f86.1c69fb81.c8019.1190@mx.google.com> (raw)
In-Reply-To: <20180913074702.5724-1-linus.walleij@linaro.org>

On Thu, Sep 13, 2018 at 09:47:02AM +0200, Linus Walleij wrote:
> In 2011 the commit bf859f84a19f
> ("gpio/dt: Refine GPIO device tree binding") introduced an
> experimental BNF notation for defining a regular grammar for
> the GPIO phandles used by different devices.
> 
> This was an interesting approach, and shows that we have long
> nutured the idea to formally verify device tree files using
> regular grammar.
> 
> Most if not all other bindings use natural language to define
> the bindings, and the recent thinking for verifying device
> tree files is to use JSON schemas in separate definitions.

The plan is json-schema will replace/incorporate all this. Of course, it 
will still have human readable prose.

> Cut the BNF business and replace it with natural language
> so that it becomes more human-readable for now.
> 
> Cc: devicetree@vger.kernel.org
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Kumar Gala <galak@kernel.crashing.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  .../devicetree/bindings/gpio/gpio.txt         | 114 ++++++++++--------
>  1 file changed, 64 insertions(+), 50 deletions(-)

Otherwise, this all looks fine to me. Would be nice to get some comment 
from Grant on this given he wrote it.

Reviewed-by: Rob Herring <robh@kernel.org>

Rob

      reply	other threads:[~2018-09-17  3:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-13  7:47 [PATCH] gpio: OF: Cut painful BNF experiments from bindings Linus Walleij
2018-09-17  3:44 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b9f3f86.1c69fb81.c8019.1190@mx.google.com \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@kernel.crashing.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).