From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>,
lee@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, sre@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org
Cc: Nurettin.Bolucu@analog.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 4/6] dt-bindings: power: supply: add MAX77659 charger binding
Date: Tue, 20 Dec 2022 15:54:10 +0100 [thread overview]
Message-ID: <5ba4295f-1197-913c-b1eb-a23798c3badf@linaro.org> (raw)
In-Reply-To: <20221220132250.19383-5-Zeynep.Arslanbenzer@analog.com>
On 20/12/2022 14:22, Zeynep Arslanbenzer wrote:
> This patch adds device tree binding documentation for MAX77659 charger.
Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> Signed-off-by: Nurettin Bolucu <Nurettin.Bolucu@analog.com>
> Signed-off-by: Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
> ---
> .../power/supply/adi,max77659-charger.yaml | 42 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 43 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/adi,max77659-charger.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/adi,max77659-charger.yaml b/Documentation/devicetree/bindings/power/supply/adi,max77659-charger.yaml
> new file mode 100644
> index 000000000000..24f8b5a2bd84
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/adi,max77659-charger.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/adi,max77659-charger.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Battery charger for MAX77659 PMIC from ADI.
Drop full stop.
> +
> +maintainers:
> + - Nurettin Bolucu <Nurettin.Bolucu@analog.com>
> + - Zeynep Arslanbenzer <Zeynep.Arslanbenzer@analog.com>
> +
> +description: |
> + This module is part of the MAX77659 MFD device. For more details
> + see Documentation/devicetree/bindings/mfd/adi,max77659.yaml.
> +
> + The charger is represented as a sub-node of the PMIC node on the device tree.
> +
> +properties:
> + compatible:
> + const: adi,max77659-charger
> +
> + reg:
> + maxItems: 1
> +
> + adi,fast-charge-timer:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Fast-charge safety timer value (in hours).
No, use suffixes for common units.
> +
> + adi,fast-charge-microamp:
> + description: Fast-charge constant current value.
> +
> + adi,topoff-timer:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: Top-Off timer value (in minutes).
No, use suffixes for common units.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-20 14:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 13:22 [PATCH 0/6] drivers: mfd: Add MAX77659 MFD and related device drivers Zeynep Arslanbenzer
2022-12-20 13:22 ` [PATCH 1/6] drivers: mfd: add MAX77659 PMIC support Zeynep Arslanbenzer
2022-12-20 14:47 ` Krzysztof Kozlowski
2022-12-20 13:22 ` [PATCH 2/6] dt-bindings: mfd: add MAX77659 binding Zeynep Arslanbenzer
2022-12-20 14:43 ` Krzysztof Kozlowski
2022-12-20 16:40 ` Rob Herring
2022-12-20 13:22 ` [PATCH 3/6] drivers: power: supply: add MAX77659 charger support Zeynep Arslanbenzer
2022-12-20 14:51 ` Krzysztof Kozlowski
2023-01-02 20:44 ` Sebastian Reichel
2022-12-20 13:22 ` [PATCH 4/6] dt-bindings: power: supply: add MAX77659 charger binding Zeynep Arslanbenzer
2022-12-20 14:54 ` Krzysztof Kozlowski [this message]
2023-04-17 21:43 ` Arslanbenzer, Zeynep
2023-04-18 7:09 ` Krzysztof Kozlowski
2023-04-18 9:41 ` Arslanbenzer, Zeynep
2023-04-18 12:30 ` Krzysztof Kozlowski
2022-12-20 13:22 ` [PATCH 5/6] drivers: regulator: add MAX77659 regulator support Zeynep Arslanbenzer
2022-12-20 13:22 ` [PATCH 6/6] dt-bindings: regulator: add MAX77659 regulator binding Zeynep Arslanbenzer
2022-12-20 14:55 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ba4295f-1197-913c-b1eb-a23798c3badf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Nurettin.Bolucu@analog.com \
--cc=Zeynep.Arslanbenzer@analog.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).