[PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Marek Vasut]

CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
This chip is present e.g. on muRata 1YN module.

Extend the binding with its DT compatible using fallback
compatible string to "brcm,bcm4329-bt" which seems to be
the oldest compatible device. This should also prevent the
growth of compatible string tables in drivers. The existing
block of compatible strings is retained.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: Marcel Holtmann <marcel@holtmann.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Cc: linux-bluetooth@vger.kernel.org
Cc: netdev@vger.kernel.org
---
V2: - Introduce fallback compatible string
    - Reword the second half of commit message to reflect that
---
 .../bindings/net/broadcom-bluetooth.yaml      | 33 +++++++++++--------
 1 file changed, 19 insertions(+), 14 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
index cc70b00c6ce57..4a1bfc2b35849 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
@@ -14,20 +14,25 @@ description:
 
 properties:
   compatible:
-    enum:
-      - brcm,bcm20702a1
-      - brcm,bcm4329-bt
-      - brcm,bcm4330-bt
-      - brcm,bcm4334-bt
-      - brcm,bcm43430a0-bt
-      - brcm,bcm43430a1-bt
-      - brcm,bcm43438-bt
-      - brcm,bcm4345c5
-      - brcm,bcm43540-bt
-      - brcm,bcm4335a0
-      - brcm,bcm4349-bt
-      - cypress,cyw4373a0-bt
-      - infineon,cyw55572-bt
+    oneOf:
+      - items:
+          - enum:
+              - infineon,cyw43439-bt
+          - const: brcm,bcm4329-bt
+      - enum:
+          - brcm,bcm20702a1
+          - brcm,bcm4329-bt
+          - brcm,bcm4330-bt
+          - brcm,bcm4334-bt
+          - brcm,bcm43430a0-bt
+          - brcm,bcm43430a1-bt
+          - brcm,bcm43438-bt
+          - brcm,bcm4345c5
+          - brcm,bcm43540-bt
+          - brcm,bcm4335a0
+          - brcm,bcm4349-bt
+          - cypress,cyw4373a0-bt
+          - infineon,cyw55572-bt
 
   shutdown-gpios:
     maxItems: 1
-- 
2.43.0

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Krzysztof Kozlowski]

On 19/03/2024 05:20, Marek Vasut wrote:
> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
> This chip is present e.g. on muRata 1YN module.
> 
> Extend the binding with its DT compatible using fallback
> compatible string to "brcm,bcm4329-bt" which seems to be
> the oldest compatible device. This should also prevent the
> growth of compatible string tables in drivers. The existing
> block of compatible strings is retained.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Marek Vasut]

On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
> On 19/03/2024 05:20, Marek Vasut wrote:
>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>> This chip is present e.g. on muRata 1YN module.
>>
>> Extend the binding with its DT compatible using fallback
>> compatible string to "brcm,bcm4329-bt" which seems to be
>> the oldest compatible device. This should also prevent the
>> growth of compatible string tables in drivers. The existing
>> block of compatible strings is retained.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Is there any action necessary from me to get this applied ?

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Krzysztof Kozlowski]

On 29/04/2024 17:10, Marek Vasut wrote:
> On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
>> On 19/03/2024 05:20, Marek Vasut wrote:
>>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>>> This chip is present e.g. on muRata 1YN module.
>>>
>>> Extend the binding with its DT compatible using fallback
>>> compatible string to "brcm,bcm4329-bt" which seems to be
>>> the oldest compatible device. This should also prevent the
>>> growth of compatible string tables in drivers. The existing
>>> block of compatible strings is retained.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Is there any action necessary from me to get this applied ?

I recommend resending with proper PATCH prefix matching net-next
expectations.

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Marek Vasut]

On 4/29/24 8:22 PM, Krzysztof Kozlowski wrote:
> On 29/04/2024 17:10, Marek Vasut wrote:
>> On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
>>> On 19/03/2024 05:20, Marek Vasut wrote:
>>>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>>>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>>>> This chip is present e.g. on muRata 1YN module.
>>>>
>>>> Extend the binding with its DT compatible using fallback
>>>> compatible string to "brcm,bcm4329-bt" which seems to be
>>>> the oldest compatible device. This should also prevent the
>>>> growth of compatible string tables in drivers. The existing
>>>> block of compatible strings is retained.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> Is there any action necessary from me to get this applied ?
> 
> I recommend resending with proper PATCH prefix matching net-next
> expectations.

I don't think bluetooth is net-next , it has its own ML and its own 
'Bluetooth:' subject prefix. Its patchwork.k.o project also doesn't seem 
to contain many patches with 'net'/'net-next' prefix. Also DT bindings 
do not seem to use it per 'git log 
Documentation/devicetree/bindings/net/bluetooth/'. But the bot is 
complaining about the prefix. Hence my confusion.

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Luiz Augusto von Dentz]

Hi Marek,

On Mon, Apr 29, 2024 at 4:44 PM Marek Vasut <marex@denx.de> wrote:
>
> On 4/29/24 8:22 PM, Krzysztof Kozlowski wrote:
> > On 29/04/2024 17:10, Marek Vasut wrote:
> >> On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
> >>> On 19/03/2024 05:20, Marek Vasut wrote:
> >>>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
> >>>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
> >>>> This chip is present e.g. on muRata 1YN module.
> >>>>
> >>>> Extend the binding with its DT compatible using fallback
> >>>> compatible string to "brcm,bcm4329-bt" which seems to be
> >>>> the oldest compatible device. This should also prevent the
> >>>> growth of compatible string tables in drivers. The existing
> >>>> block of compatible strings is retained.
> >>>>
> >>>> Signed-off-by: Marek Vasut <marex@denx.de>
> >>>
> >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>
> >> Is there any action necessary from me to get this applied ?
> >
> > I recommend resending with proper PATCH prefix matching net-next
> > expectations.
>
> I don't think bluetooth is net-next , it has its own ML and its own
> 'Bluetooth:' subject prefix. Its patchwork.k.o project also doesn't seem
> to contain many patches with 'net'/'net-next' prefix. Also DT bindings
> do not seem to use it per 'git log
> Documentation/devicetree/bindings/net/bluetooth/'. But the bot is
> complaining about the prefix. Hence my confusion.

Well usually we require Bluetooth: prefix to indicate this patch is
for bluetooth/bluetooth-next trees, or you can do via subject e.g.
[bluetooth-next v1...] otherwise it could be merged via other trees.

-- 
Luiz Augusto von Dentz

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Marek Vasut]

On 4/29/24 10:57 PM, Luiz Augusto von Dentz wrote:
> Hi Marek,

Hello Luiz,

> On Mon, Apr 29, 2024 at 4:44 PM Marek Vasut <marex@denx.de> wrote:
>>
>> On 4/29/24 8:22 PM, Krzysztof Kozlowski wrote:
>>> On 29/04/2024 17:10, Marek Vasut wrote:
>>>> On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
>>>>> On 19/03/2024 05:20, Marek Vasut wrote:
>>>>>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>>>>>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>>>>>> This chip is present e.g. on muRata 1YN module.
>>>>>>
>>>>>> Extend the binding with its DT compatible using fallback
>>>>>> compatible string to "brcm,bcm4329-bt" which seems to be
>>>>>> the oldest compatible device. This should also prevent the
>>>>>> growth of compatible string tables in drivers. The existing
>>>>>> block of compatible strings is retained.
>>>>>>
>>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>>
>>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>>
>>>> Is there any action necessary from me to get this applied ?
>>>
>>> I recommend resending with proper PATCH prefix matching net-next
>>> expectations.
>>
>> I don't think bluetooth is net-next , it has its own ML and its own
>> 'Bluetooth:' subject prefix. Its patchwork.k.o project also doesn't seem
>> to contain many patches with 'net'/'net-next' prefix. Also DT bindings
>> do not seem to use it per 'git log
>> Documentation/devicetree/bindings/net/bluetooth/'. But the bot is
>> complaining about the prefix. Hence my confusion.
> 
> Well usually we require Bluetooth: prefix to indicate this patch is
> for bluetooth/bluetooth-next trees, or you can do via subject e.g.
> [bluetooth-next v1...] otherwise it could be merged via other trees.

Thank you for clarification. Hopefully the V3 is better.

Re: [PATCH v2] dt-bindings: net: broadcom-bluetooth: Add CYW43439 DT binding

[Krzysztof Kozlowski]

On 29/04/2024 22:44, Marek Vasut wrote:
> On 4/29/24 8:22 PM, Krzysztof Kozlowski wrote:
>> On 29/04/2024 17:10, Marek Vasut wrote:
>>> On 3/19/24 6:41 AM, Krzysztof Kozlowski wrote:
>>>> On 19/03/2024 05:20, Marek Vasut wrote:
>>>>> CYW43439 is a Wi-Fi + Bluetooth combo device from Infineon.
>>>>> The Bluetooth part is capable of Bluetooth 5.2 BR/EDR/LE .
>>>>> This chip is present e.g. on muRata 1YN module.
>>>>>
>>>>> Extend the binding with its DT compatible using fallback
>>>>> compatible string to "brcm,bcm4329-bt" which seems to be
>>>>> the oldest compatible device. This should also prevent the
>>>>> growth of compatible string tables in drivers. The existing
>>>>> block of compatible strings is retained.
>>>>>
>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>
>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>>> Is there any action necessary from me to get this applied ?
>>
>> I recommend resending with proper PATCH prefix matching net-next
>> expectations.
> 
> I don't think bluetooth is net-next , it has its own ML and its own 

True, indeed. The net prefix confused me.

Best regards,
Krzysztof