From: Florian Fainelli <f.fainelli@gmail.com>
To: Al Cooper <alcooperx@gmail.com>, linux-kernel@vger.kernel.org
Cc: devicetree@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Sasi Kumar <sasi.kumar@broadcom.com>
Subject: Re: [PATCH 5/7] usb: bdc: driver runs out of buffer descriptors on large ADB transfers
Date: Fri, 17 Jul 2020 09:58:05 -0700 [thread overview]
Message-ID: <5bc7603c-0e1f-762f-0d67-1c817c03c5ca@gmail.com> (raw)
In-Reply-To: <20200717152307.36705-6-alcooperx@gmail.com>
On 7/17/2020 8:23 AM, Al Cooper wrote:
> Version v1.0.40 of the Android host ADB software increased maximum
> transfer sizes from 256K to 1M. Since the STB ADB gadget driver
> requests only 16K at a time, the BDC driver ran out of buffer
> descriptors (BDs) if the queuing happens faster than the incoming
> 16K transfers. This issue is fixed by doubling the number of BDs
> that can be queued so that the entire 1M request can be queued
> without running out of buffers.
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
You can certainly remove my SoB here, since you are carrying your own
patch, thanks!
--
Florian
next prev parent reply other threads:[~2020-07-17 16:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 15:23 [PATCH 0/7] usb: bdc: Updates and fixes to the USB BDC driver Al Cooper
2020-07-17 15:23 ` [PATCH 1/7] dt-bindings: usb: bdc: Update compatible strings Al Cooper
2020-07-17 15:23 ` [PATCH 2/7] usb: bdc: Add compatible string for new style USB DT nodes Al Cooper
2020-07-17 16:55 ` Florian Fainelli
2020-07-17 15:23 ` [PATCH 3/7] bdc: Fix bug causing crash after multiple disconnects Al Cooper
2020-07-17 16:56 ` Florian Fainelli
2020-07-17 15:23 ` [PATCH 4/7] usb: bdc: Adb shows offline after resuming from S2 Al Cooper
2020-07-17 15:23 ` [PATCH 5/7] usb: bdc: driver runs out of buffer descriptors on large ADB transfers Al Cooper
2020-07-17 16:58 ` Florian Fainelli [this message]
2020-07-17 15:23 ` [PATCH 6/7] usb: bdc: Halt controller on suspend Al Cooper
2020-07-17 15:23 ` [PATCH 7/7] usb: bdc: Use devm_clk_get_optional() Al Cooper
2020-07-17 16:57 ` Florian Fainelli
2020-07-21 9:33 ` [PATCH 0/7] usb: bdc: Updates and fixes to the USB BDC driver Felipe Balbi
2020-07-21 13:45 ` Alan Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bc7603c-0e1f-762f-0d67-1c817c03c5ca@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alcooperx@gmail.com \
--cc=balbi@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sasi.kumar@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).