From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Praveen Talari <quic_ptalari@quicinc.com>,
agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: quic_msavaliy@quicinc.com, quic_vtanuku@quicinc.com,
quic_vnivarth@quicinc.com, quic_arandive@quicinc.com
Subject: Re: [PATCH v3 2/3] spi: dt-bindings: qcom,spi-geni-qcom: Add SPI device mode support for GENI based QuPv3
Date: Fri, 23 Jun 2023 10:47:23 +0200 [thread overview]
Message-ID: <5bcf1c7a-c5d6-67f6-ac81-b143af748fa6@linaro.org> (raw)
In-Reply-To: <20230622135955.941-3-quic_ptalari@quicinc.com>
On 22/06/2023 15:59, Praveen Talari wrote:
> Add a property to configure QUPv3 SE as SPI Device mode.
>
> Signed-off-by: Praveen Talari <quic_ptalari@quicinc.com>
> ---
> v2 -> v3:
> - modified commit message to use device mode instead of slave mode
> ---
> Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> index 2e20ca313ec1..5c7d0293bbf7 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-geni-qcom.yaml
> @@ -66,6 +66,10 @@ properties:
> reg:
> maxItems: 1
>
> + qcom,slv-ctrl:
> + description: configure QUPv3 SE as Device mode
There is already property for this. Look at spi-controller.yaml. If it
is not enough, explain WHY.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-06-23 8:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-22 13:59 [PATCH v3 0/3] spi-geni-qcom: Add SPI device mode support for GENI based QuPv3 Praveen Talari
2023-06-22 13:59 ` [PATCH v3 1/3] soc: qcom: geni-se: Add SPI Device " Praveen Talari
2023-06-22 13:59 ` [PATCH v3 2/3] spi: dt-bindings: qcom,spi-geni-qcom: Add SPI device " Praveen Talari
2023-06-22 19:05 ` Conor Dooley
2023-07-06 5:07 ` Praveen Talari
2023-06-23 8:47 ` Krzysztof Kozlowski [this message]
2023-06-22 13:59 ` [PATCH v3 3/3] spi: spi-geni-qcom: Add SPI Device " Praveen Talari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bcf1c7a-c5d6-67f6-ac81-b143af748fa6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=quic_arandive@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_ptalari@quicinc.com \
--cc=quic_vnivarth@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox