From: Georgi Djakov <georgi.djakov@linaro.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Rob Herring <robh+dt@kernel.org>,
Kevin Hilman <khilman@baylibre.com>,
Michael Turquette <mturquette@baylibre.com>,
Greg KH <gregkh@linuxfoundation.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
skannan@codeaurora.org, Stephen Boyd <sboyd@codeaurora.org>,
Andy Gross <andy.gross@linaro.org>,
seansw@qti.qualcomm.com, davidai@quicinc.com,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect provider driver
Date: Tue, 16 May 2017 17:59:02 +0300 [thread overview]
Message-ID: <5bd5fbd9-ee12-a414-88ce-32b286318616@linaro.org> (raw)
In-Reply-To: <CAMuHMdXM3f+P8ZyydxnO5z2g3F2n2c3KzfDFbC6jYgZJt+1ULw@mail.gmail.com>
On 05/15/2017 07:01 PM, Geert Uytterhoeven wrote:
> Hi Georgi,
>
> On Mon, May 15, 2017 at 5:35 PM, Georgi Djakov <georgi.djakov@linaro.org> wrote:
>> --- /dev/null
>> +++ b/drivers/interconnect/qcom/interconnect_msm8916.c
>
>> +struct qcom_interconnect_node {
>> + struct interconnect_node node;
>> + unsigned int id;
>
> 4 byte gap due to alignment rules on 64-bit.
>
>> + unsigned char *name;
>> + struct interconnect_node *links[8];
>> + int num_links;
>> + int port;
>> + int buswidth;
>
> 4 byte gap due to alignment rules.
>
>> + u64 ib;
>> + u64 ab;
>> + u64 rate;
>> +};
>
> You can avoid the gaps by putting members of the same size and alignment
> together.
Thanks Geert, i will rearrange this to reduce the padding bytes!
BR,
Georgi
next prev parent reply other threads:[~2017-05-16 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 15:35 [RFC v1 0/3] Introduce on-chip interconnect API Georgi Djakov
2017-05-15 15:35 ` [RFC v1 1/3] interconnect: Add generic interconnect controller API Georgi Djakov
2017-05-31 16:02 ` Vincent Guittot
[not found] ` <20170515153527.27649-1-georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-05-15 15:35 ` [RFC v1 2/3] interconnect: Add Qualcomm msm8916 interconnect provider driver Georgi Djakov
[not found] ` <20170515153527.27649-3-georgi.djakov-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-05-15 16:01 ` Geert Uytterhoeven
2017-05-16 14:59 ` Georgi Djakov [this message]
2017-05-15 15:35 ` [RFC v1 3/3] dt-binding: Interconnect device-tree bindings draft Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5bd5fbd9-ee12-a414-88ce-32b286318616@linaro.org \
--to=georgi.djakov@linaro.org \
--cc=andy.gross@linaro.org \
--cc=davidai@quicinc.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=seansw@qti.qualcomm.com \
--cc=skannan@codeaurora.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).