From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman <horms@verge.net.au>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-renesas-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add MMC support
Date: Fri, 20 Apr 2018 22:06:03 +0300 [thread overview]
Message-ID: <5be1ecdb-8f36-ca1e-aba6-012fbb263894@cogentembedded.com> (raw)
In-Reply-To: <20180420095857.latofivdh3dnvu2z@verge.net.au>
On 04/20/2018 12:58 PM, Simon Horman wrote:
>> Define the generic R8A77980 part of the MMC0 (SDHI2) device node.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi
>> @@ -371,6 +371,18 @@
>> dma-channels = <16>;
>> };
>>
>> + mmc0: mmc@ee140000 {
>
> Please use sdhi2: sd@ee140000 for consistency with other SoCs
> (I refereed to the r8a7795).
Mmm... note that this controller has MMC signals (8 data bits, DS, no CD/WP),
see manual v0.55. I think it's more correct to call it MMC0 (trken from the
manual as well)...
MBR, Sergei
next prev parent reply other threads:[~2018-04-20 19:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-14 19:24 [PATCH 0/2] Add R8A77980/Condor eMMC support Sergei Shtylyov
2018-04-14 19:27 ` [PATCH 1/2] arm64: dts: renesas: r8a77980: add MMC support Sergei Shtylyov
2018-04-20 9:58 ` Simon Horman
2018-04-20 19:06 ` Sergei Shtylyov [this message]
2018-04-24 9:22 ` Simon Horman
2018-04-14 19:28 ` [PATCH 2/2] arm64: dts: renesas: condor: add eMMC support Sergei Shtylyov
2018-04-20 10:03 ` Simon Horman
2018-04-20 18:51 ` Sergei Shtylyov
2018-04-24 9:22 ` Simon Horman
2018-04-24 19:25 ` [PATCH v2] " Sergei Shtylyov
2018-04-30 8:01 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5be1ecdb-8f36-ca1e-aba6-012fbb263894@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).