From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 1/2] arm64: dts: renesas: r8a77980: add MMC support Date: Fri, 20 Apr 2018 22:06:03 +0300 Message-ID: <5be1ecdb-8f36-ca1e-aba6-012fbb263894@cogentembedded.com> References: <611daf1f-42a2-d463-0814-ebf762871018@cogentembedded.com> <20180420095857.latofivdh3dnvu2z@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180420095857.latofivdh3dnvu2z@verge.net.au> Content-Language: en-MW List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Simon Horman Cc: Mark Rutland , devicetree@vger.kernel.org, Magnus Damm , Catalin Marinas , Will Deacon , linux-renesas-soc@vger.kernel.org, Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On 04/20/2018 12:58 PM, Simon Horman wrote: >> Define the generic R8A77980 part of the MMC0 (SDHI2) device node. >> >> Signed-off-by: Sergei Shtylyov >> >> --- >> arch/arm64/boot/dts/renesas/r8a77980.dtsi | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> Index: renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi >> =================================================================== >> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77980.dtsi >> +++ renesas/arch/arm64/boot/dts/renesas/r8a77980.dtsi >> @@ -371,6 +371,18 @@ >> dma-channels = <16>; >> }; >> >> + mmc0: mmc@ee140000 { > > Please use sdhi2: sd@ee140000 for consistency with other SoCs > (I refereed to the r8a7795). Mmm... note that this controller has MMC signals (8 data bits, DS, no CD/WP), see manual v0.55. I think it's more correct to call it MMC0 (trken from the manual as well)... MBR, Sergei