Re: [PATCH v5 5/5] PCI: altera: Add Agilex support

[matthew.gerlach@linux.intel.com]

On Wed, 29 Jan 2025, Krzysztof Kozlowski wrote:

> On 27/01/2025 18:35, Matthew Gerlach wrote:
>> +
>>  static const struct of_device_id altera_pcie_of_match[] = {
>>  	{.compatible = "altr,pcie-root-port-1.0",
>>  	 .data = &altera_pcie_1_0_data },
>>  	{.compatible = "altr,pcie-root-port-2.0",
>>  	 .data = &altera_pcie_2_0_data },
>> +	{.compatible = "altr,pcie-root-port-3.0-f-tile",
>> +	 .data = &altera_pcie_3_0_f_tile_data },
>> +	{.compatible = "altr,pcie-root-port-3.0-p-tile",
>> +	 .data = &altera_pcie_3_0_p_tile_data },
>> +	{.compatible = "altr,pcie-root-port-3.0-r-tile",
>> +	 .data = &altera_pcie_3_0_r_tile_data },
>
> Please run scripts/checkpatch.pl and fix reported warnings. After that,
> run also `scripts/checkpatch.pl --strict` and (probably) fix more
> warnings. Some warnings can be ignored, especially from --strict run,
> but the code here looks like it needs a fix. Feel free to get in touch
> if the warning is not clear.
I will fix the duplicate signature warning.

Thanks,
Matthew Gerlach
>
> Best regards,
> Krzysztof
>