From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61387C10F1B for ; Wed, 21 Dec 2022 12:30:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231703AbiLUMaS (ORCPT ); Wed, 21 Dec 2022 07:30:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230296AbiLUMaQ (ORCPT ); Wed, 21 Dec 2022 07:30:16 -0500 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 742FEB7D for ; Wed, 21 Dec 2022 04:30:15 -0800 (PST) Received: by mail-lj1-x233.google.com with SMTP id l8so15423125ljh.13 for ; Wed, 21 Dec 2022 04:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fRZOrty5MgfXDX5Qq5G+s7U6FuXGETTST3AS0wLJyjE=; b=w9bW7mJQ98C/1sGABi6FE2EoLYodXp1Ksn/JipkCzZfM889fycz/RIRqNqm44kiCWB 1sbFIoW6x3xebfswBOAaLnKnLXONK8QGGKC1mSjSA/qXNKUdath+1GDuPieQjAP1QDjX hPB4UBehx0gYO0kOMcA8sty7QwKWZ37V0TvJ5U4iVCIOAeG9MDiISrARxKiYbrtLfJlJ u9tDXRVUU+pCQn4axbnhUROiNqY25nUl87nu70F+WaUjsfQvcFGBTgSUIbLM0DcOQ0jB gEAw+M8S6wgJYdQNfugQaMMyMjHCp3wGFw7VB68jrdLPB0nsT81i8DcWxfUx8Rxn0hQ1 rOGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fRZOrty5MgfXDX5Qq5G+s7U6FuXGETTST3AS0wLJyjE=; b=CqW1xTnLLYtCegidWwM3SQ+bNu9zBZ6uktrCQS/jC80xUe4LeDvFMPqSFfyv5JXpUQ PaoQyvdL+SGwx5zuRX81aaXrxWjIg5QVda4e9bAdpPNc442UnKDOFRtXR6JU5HtEa8OL hHsVGL+PcOGVSlL4ylhFgi5sS5AfoHksNYkVW5BgG6ALjfB/9y23JeCsB0aPZtejnat6 b1dm/S1KCD3xtGlFXjAU9NxWvYxChGebFjndZ+vUOR2hcPqFvBnESdKpIIagwd1puGVz Vu3e5mffVIVVQqo8IrotojHdvHRTVu03SC+xkdZ7xzuz7ai2pjnNTx9QQDc8iRwHLSju 131g== X-Gm-Message-State: AFqh2kpNQMPK7aHJW5m3M7N1CbdfLzSr/BUUD49R4sqcfAtNCFXSVkU0 vTL6+kGy2hA0+JAO6KqjaCmSmA== X-Google-Smtp-Source: AMrXdXtvztDDZB4uZQJgNyxRmxBHPk71MN5H9Vyhw7koQDZIqCIqCblN9RI9ix8HjRyFOHE6ZPZPyw== X-Received: by 2002:a2e:f19:0:b0:277:3de:f78a with SMTP id 25-20020a2e0f19000000b0027703def78amr379185ljp.27.1671625813877; Wed, 21 Dec 2022 04:30:13 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id m23-20020a2e97d7000000b0027973ba8718sm1284085ljj.37.2022.12.21.04.30.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 04:30:13 -0800 (PST) Message-ID: <5c0e7f2f-94e1-c6d4-d848-f90e29eead10@linaro.org> Date: Wed, 21 Dec 2022 13:30:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs Content-Language: en-US To: Andrei Stefanescu , Chester Lin , Rob Herring , Linus Walleij , Krzysztof Kozlowski , =?UTF-8?Q?Andreas_F=c3=a4rber?= Cc: dl-S32 , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Larisa Ileana Grigore , "Ghennadi Procopciuc (OSS)" , Matthias Brugger References: <20221221073232.21888-1-clin@suse.com> <20221221073232.21888-2-clin@suse.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/12/2022 13:28, Andrei Stefanescu wrote: > Hi Chester, > >> +patternProperties: >> + '-pins$': > > Sorry, I missed this in the previous versions. Could you change it to '_pins' (underscore)? In our .dts files we use underscore in the names for pinctrl configuration nodes e.g. i2c4_pins, usbotg_pins. You cannot have underscores as node names, so what do you mean here? You need to fix your DTS not introduce bad practices to mainline kernel. Best regards, Krzysztof